AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
	"Li, Yunxiang (Teddy)" <Yunxiang.Li@amd.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime
Date: Wed, 23 Oct 2024 14:56:24 +0200	[thread overview]
Message-ID: <c80eb8ff-3965-4036-b763-20c4c2550e04@amd.com> (raw)
In-Reply-To: <2141a4f4-bcf4-4419-8756-fb5afd6c7f3a@igalia.com>

Am 23.10.24 um 14:24 schrieb Tvrtko Ursulin:
> [SNIP]
>>> To fold or not the special placements (GWS, GDS & co) is also 
>>> tangential. In my patch I just preserved the legacy behaviour so it 
>>> can easily be tweaked on top.
>>
>> Yeah, but again the original behavior is completely broken.
>>
>> GWS, GDS and OA are counted in blocks of HW units (multiplied by 
>> PAGE_SIZE IIRC to avoid some GEM&TTM warnings).
>>
>> When you accumulate that anywhere in the memory stats then that is 
>> just completely off.
>
> Ooops. :) Are they backed by some memory though, be it system or VRAM?

GDS is an internal 4 or 64KiB memory block which is only valid while 
shaders are running. It is used to communicate stuff between different 
shader stages and not even CPU accessible.

GWS and OA are not even memory, those are just HW blocks which implement 
a fixed function.

IIRC most HW generation have 16 of each and when setting up the 
application virtual address space you can specify how many will be used 
by the application.

Regards,
Christian.

>
> Regards,
>
> Tvrtko


  reply	other threads:[~2024-10-23 12:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 13:33 [PATCH v5 0/4] rework bo mem stats tracking Yunxiang Li
2024-10-18 13:33 ` [PATCH v5 1/4] drm/amdgpu: remove unused function parameter Yunxiang Li
2024-10-22  6:58   ` Christian König
2024-10-18 13:33 ` [PATCH v5 2/4] drm/amdgpu: make drm-memory-* report resident memory Yunxiang Li
2024-10-18 15:39   ` Tvrtko Ursulin
2024-10-22  7:00   ` Christian König
2024-10-18 13:33 ` [PATCH v5 3/4] drm/amdgpu: stop tracking visible memory stats Yunxiang Li
2024-10-22  7:22   ` Christian König
2024-10-18 13:33 ` [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime Yunxiang Li
2024-10-22  7:43   ` Christian König
2024-10-22 15:17     ` Li, Yunxiang (Teddy)
2024-10-22 16:24       ` Christian König
2024-10-22 16:46         ` Li, Yunxiang (Teddy)
2024-10-22 17:06           ` Christian König
2024-10-22 17:09             ` Li, Yunxiang (Teddy)
2024-10-23  6:34               ` Christian König
2024-10-23  7:33             ` Tvrtko Ursulin
2024-10-23  7:38         ` Tvrtko Ursulin
2024-10-23  9:14           ` Christian König
2024-10-23 11:37             ` Tvrtko Ursulin
2024-10-23 12:12               ` Christian König
2024-10-23 12:24                 ` Tvrtko Ursulin
2024-10-23 12:56                   ` Christian König [this message]
2024-10-24  8:29                     ` Tvrtko Ursulin
2024-10-23 13:31                   ` Li, Yunxiang (Teddy)
2024-10-23 13:40                     ` Li, Yunxiang (Teddy)
2024-10-23 14:27                     ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c80eb8ff-3965-4036-b763-20c4c2550e04@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Yunxiang.Li@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox