From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43C5DCCA472 for ; Wed, 8 Oct 2025 14:56:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F34410E842; Wed, 8 Oct 2025 14:56:02 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 0376110E83E; Wed, 8 Oct 2025 14:56:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E24B2444; Wed, 8 Oct 2025 07:55:52 -0700 (PDT) Received: from [10.1.28.50] (e122027.cambridge.arm.com [10.1.28.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 69D2C3F66E; Wed, 8 Oct 2025 07:55:59 -0700 (PDT) Message-ID: Date: Wed, 8 Oct 2025 15:55:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24/28] drm/panthor: Remove drm_sched_init_args->num_rqs usage To: Tvrtko Ursulin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-dev@igalia.com, Boris Brezillon , Liviu Dudau References: <20251008085359.52404-1-tvrtko.ursulin@igalia.com> <20251008085359.52404-25-tvrtko.ursulin@igalia.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251008085359.52404-25-tvrtko.ursulin@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 08/10/2025 09:53, Tvrtko Ursulin wrote: > Remove member no longer used by the scheduler core. > > Signed-off-by: Tvrtko Ursulin > Cc: Boris Brezillon > Cc: Steven Price > Cc: Liviu Dudau > Cc: dri-devel@lists.freedesktop.org Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_mmu.c | 1 - > drivers/gpu/drm/panthor/panthor_sched.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c > index 6dec4354e378..048a61d9fad6 100644 > --- a/drivers/gpu/drm/panthor/panthor_mmu.c > +++ b/drivers/gpu/drm/panthor/panthor_mmu.c > @@ -2327,7 +2327,6 @@ panthor_vm_create(struct panthor_device *ptdev, bool for_mcu, > const struct drm_sched_init_args sched_args = { > .ops = &panthor_vm_bind_ops, > .submit_wq = ptdev->mmu->vm.wq, > - .num_rqs = 1, > .credit_limit = 1, > /* Bind operations are synchronous for now, no timeout needed. */ > .timeout = MAX_SCHEDULE_TIMEOUT, > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index f5e01cb16cfc..5b95868169ac 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -3318,7 +3318,6 @@ group_create_queue(struct panthor_group *group, > struct drm_sched_init_args sched_args = { > .ops = &panthor_queue_sched_ops, > .submit_wq = group->ptdev->scheduler->wq, > - .num_rqs = 1, > /* > * The credit limit argument tells us the total number of > * instructions across all CS slots in the ringbuffer, with