From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunming Zhou Subject: Re: [PATCH 1/7] drm/amdgpu: fix VM PD addr shift Date: Tue, 28 Nov 2017 10:42:49 +0800 Message-ID: References: <20171127160217.4010-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171127160217.4010-1-christian.koenig-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAyMDE35bm0MTHmnIgyOOaXpSAwMDowMiwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBU aGUgYmxvY2sgc2l6ZSBvbmx5IGFmZmVjdHMgdGhlIGxlYXZlIG5vZGVzLCBldmVyeXRoaW5nIGVs c2UgaXMgZml4ZWQuClRoaXMgaXMgbm90IHRydWUsIGJsb2NrIHNpemUgYWZmZWN0cyBldmVyeSBs ZXZlbCBlbnRyaWVzLCBzZWUgdGhlIApyZWdpc3RlciBleHBsYWlucyBmb3IgVk1fQ09OVEVYVHhf Q05UTC5QQUdFX1RBQkxFX0JMT0NLX1NJWkU6CiJMT0cyKG51bWJlciBvZiAyTUIgbG9naWNhbCBh ZGRyZXNzIHJhbmdlcykgcG9pbnRlZCB0byBieSBhIFBERTAgcGFnZSAKdGV4dCBkaXJlY3Rvcnkg ZW50cnkuIFRoZSBuYXRpdmUgcGFnZSBzaXplIGZvciB0aGUgY29tcG9uZW50IHB0ZXMgY29tZXMg CmZyb20gdGhlIFBERTAuYmxvY2tfZnJhZ21lbnRfc2l6ZSBmaWVsZCBvciBCQVNFX0FERFIuYmxv Y2tfZnJhZ21lbnRfc2l6ZSAKZmllbGQgKGZvciBhIGZsYXQgcGFnZSB0YWJsZSkuIFRoZSBQQUdF X1RBQkxFX0JMT0NLX1NJWkUgZmllbGQgb25seSBoYXMgCmFuIGVmZmVjdCBvbiBhZGRyZXNzIGNh bGN1bGF0aW9ucyBmb3IgPj0gMiBsZXZlbCBwYWdlIHRhYmxlcyBob3dldmVyLiBBIApmbGF0IHBh Z2UgdGFibGUgd2lsbCB1dGlsaXplIGFzIG1hbnkgcHRlcyBhcyBhcmUgcmVxdWlyZWQgdG8gcmVw cmVzZW50IAp0aGUgbG9naWNhbCBhZGRyZXNzIGJldHdlZW4gU1RBUlRfQUREUiBhbmQgRU5EX0FE RFIsIG5vdCBsaW1pdGVkIGJ5IApQQUdFX1RBQkxFX0JMT0NLX1NJWkUuIgoKUmVnYXJkcywKRGF2 aWQgWmhvdQo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtv ZW5pZ0BhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3ZtLmMgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4gICAxIGZpbGUgY2hhbmdl ZCwgMjMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV92bS5jCj4gaW5kZXggMTIyMzc5ZGZjN2Q4Li5mMWU1NDFlOWI1MTQgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+IEBAIC0xMzksNiArMTM5 LDI0IEBAIHN0cnVjdCBhbWRncHVfcHJ0X2NiIHsKPiAgIH07Cj4gICAKPiAgIC8qKgo+ICsgKiBh bWRncHVfdm1fbGV2ZWxfc2hpZnQgLSByZXR1cm4gdGhlIGFkZHIgc2hpZnQgZm9yIGVhY2ggbGV2 ZWwKPiArICoKPiArICogQGFkZXY6IGFtZGdwdV9kZXZpY2UgcG9pbnRlcgo+ICsgKgo+ICsgKiBS ZXR1cm5zIHRoZSBudW1iZXIgb2YgYml0cyB0aGUgcGZuIG5lZWRzIHRvIGJlIHJpZ2h0IHNoaWZ0 ZWQgZm9yIGEgbGV2ZWwuCj4gKyAqLwo+ICtzdGF0aWMgdW5zaWduZWQgYW1kZ3B1X3ZtX2xldmVs X3NoaWZ0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICsJCQkJICAgICAgdW5zaWduZWQg bGV2ZWwpCj4gK3sKPiArCWlmIChsZXZlbCAhPSBhZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZlbCkK PiArCQlyZXR1cm4gOSAqIChhZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZlbCAtIGxldmVsIC0gMSkg Kwo+ICsJCQlhZGV2LT52bV9tYW5hZ2VyLmJsb2NrX3NpemU7Cj4gKwllbHNlCj4gKwkJLyogRm9y IHRoZSBwYWdlIHRhYmxlcyBvbiB0aGUgbGVhdmVzICovCj4gKwkJcmV0dXJuIDA7Cj4gK30KPiAr Cj4gKy8qKgo+ICAgICogYW1kZ3B1X3ZtX251bV9lbnRyaWVzIC0gcmV0dXJuIHRoZSBudW1iZXIg b2YgZW50cmllcyBpbiBhIFBEL1BUCj4gICAgKgo+ICAgICogQGFkZXY6IGFtZGdwdV9kZXZpY2Ug cG9pbnRlcgo+IEBAIC0yODgsOCArMzA2LDcgQEAgc3RhdGljIGludCBhbWRncHVfdm1fYWxsb2Nf bGV2ZWxzKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAgCQkJCSAgdWludDY0X3Qgc2Fk ZHIsIHVpbnQ2NF90IGVhZGRyLAo+ICAgCQkJCSAgdW5zaWduZWQgbGV2ZWwpCj4gICB7Cj4gLQl1 bnNpZ25lZCBzaGlmdCA9IChhZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZlbCAtIGxldmVsKSAqCj4g LQkJYWRldi0+dm1fbWFuYWdlci5ibG9ja19zaXplOwo+ICsJdW5zaWduZWQgc2hpZnQgPSBhbWRn cHVfdm1fbGV2ZWxfc2hpZnQoYWRldiwgbGV2ZWwpOwo+ICAgCXVuc2lnbmVkIHB0X2lkeCwgZnJv bSwgdG87Cj4gICAJaW50IHI7Cj4gICAJdTY0IGZsYWdzOwo+IEBAIC0xMzAyLDE4ICsxMzE5LDE5 IEBAIHZvaWQgYW1kZ3B1X3ZtX2dldF9lbnRyeShzdHJ1Y3QgYW1kZ3B1X3B0ZV91cGRhdGVfcGFy YW1zICpwLCB1aW50NjRfdCBhZGRyLAo+ICAgCQkJIHN0cnVjdCBhbWRncHVfdm1fcHQgKiplbnRy eSwKPiAgIAkJCSBzdHJ1Y3QgYW1kZ3B1X3ZtX3B0ICoqcGFyZW50KQo+ICAgewo+IC0JdW5zaWdu ZWQgaWR4LCBsZXZlbCA9IHAtPmFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsOwo+ICsJdW5zaWdu ZWQgbGV2ZWwgPSAwOwo+ICAgCj4gICAJKnBhcmVudCA9IE5VTEw7Cj4gICAJKmVudHJ5ID0gJnAt PnZtLT5yb290Owo+ICAgCXdoaWxlICgoKmVudHJ5KS0+ZW50cmllcykgewo+IC0JCWlkeCA9IGFk ZHIgPj4gKHAtPmFkZXYtPnZtX21hbmFnZXIuYmxvY2tfc2l6ZSAqIGxldmVsLS0pOwo+ICsJCXVu c2lnbmVkIGlkeCA9IGFkZHIgPj4gYW1kZ3B1X3ZtX2xldmVsX3NoaWZ0KHAtPmFkZXYsIGxldmVs KyspOwo+ICsKPiAgIAkJaWR4ICU9IGFtZGdwdV9ib19zaXplKCgqZW50cnkpLT5iYXNlLmJvKSAv IDg7Cj4gICAJCSpwYXJlbnQgPSAqZW50cnk7Cj4gICAJCSplbnRyeSA9ICYoKmVudHJ5KS0+ZW50 cmllc1tpZHhdOwo+ICAgCX0KPiAgIAo+IC0JaWYgKGxldmVsKQo+ICsJaWYgKGxldmVsICE9IHAt PmFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsKQo+ICAgCQkqZW50cnkgPSBOVUxMOwo+ICAgfQo+ ICAgCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQt Z2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK