amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Sunil Khatri <sunil.khatri@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu: Fix the comment to avoid warning
Date: Thu, 3 Apr 2025 11:03:00 +0200	[thread overview]
Message-ID: <cc217826-180b-491d-aa49-0dff073b8f99@amd.com> (raw)
In-Reply-To: <20250403072910.555319-1-sunil.khatri@amd.com>

Am 03.04.25 um 09:29 schrieb Sunil Khatri:
> Fix the below comment warning
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:541:
> warning: Function parameter or struct member 'adev'
> not described in 'amdgpu_sdma_register_on_reset_callbacks'
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> index 0a9893fee828..c3c6f03190c8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> @@ -531,6 +531,7 @@ bool amdgpu_sdma_is_shared_inv_eng(struct amdgpu_device *adev, struct amdgpu_rin
>  
>  /**
>   * amdgpu_sdma_register_on_reset_callbacks - Register SDMA reset callbacks
> + * @adev: Pointer to the AMDGPU device
>   * @funcs: Pointer to the callback structure containing pre_reset and post_reset functions
>   *
>   * This function allows KFD and AMDGPU to register their own callbacks for handling


  reply	other threads:[~2025-04-03  9:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  7:29 [PATCH] drm/amdgpu: Fix the comment to avoid warning Sunil Khatri
2025-04-03  9:03 ` Christian König [this message]
2025-04-08  7:22   ` SHANMUGAM, SRINIVASAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc217826-180b-491d-aa49-0dff073b8f99@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=sunil.khatri@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).