From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/4] drm/amd/display: Prevent vblank irq disable while VRR
 is active. (v2)
Date: Wed, 20 Mar 2019 13:11:53 +0000
Message-ID: <ccc07c0b-d35c-4125-d604-098c8fcd4bd2@amd.com>
References: <20190320081208.16672-1-mario.kleiner.de@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20190320081208.16672-1-mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Content-Language: en-US
Content-ID: <45BFFA5C8EBF9D4680F48D540675949A-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org>
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Mario Kleiner <mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>

T24gMy8yMC8xOSA0OjEyIEFNLCBNYXJpbyBLbGVpbmVyIHdyb3RlOg0KPiBEdXJpbmcgVlJSIG1v
ZGUgd2UgY2FuIG5vdCBhbGxvdyB2YmxhbmsgaXJxIGRpcy0vZW5hYmxlDQo+IHRyYW5zaXRpb25z
LCBhcyBhbiBlbmFibGUgYWZ0ZXIgYSBkaXNhYmxlIGNhbiBoYXBwZW4gYXQNCj4gYW4gYXJiaXRy
YXJ5IHRpbWUgZHVyaW5nIHRoZSB2aWRlbyByZWZyZXNoIGN5Y2xlLCBlLmcuLA0KPiB3aXRoIGEg
aGlnaCBsaWtlbHlob29kIGluc2lkZSB2YmxhbmsgZnJvbnQtcG9yY2guIEFuDQo+IGVuYWJsZSBk
dXJpbmcgZnJvbnQtcG9yY2ggd291bGQgY2F1c2UgdmJsYW5rIHRpbWVzdGFtcA0KPiB1cGRhdGVz
L2NhbGN1bGF0aW9ucyB3aGljaCBhcmUgY29tcGxldGVseSBib2d1cywgZ2l2ZW4NCj4gdGhlIGNv
ZGUgY2FuJ3Qga25vdyB3aGVuIHRoZSB2Ymxhbmsgd2lsbCBlbmQgYXMgbG9uZw0KPiBhcyB3ZSBh
cmUgaW4gZnJvbnQtcG9yY2ggd2l0aCBubyBwYWdlIGZsaXAgY29tcGxldGVkLg0KPiANCj4gSG9s
ZCBhIHBlcm1hbmVudCB2YmxhbmsgcmVmZXJlbmNlIG9uIHRoZSBjcnRjIHdoaWxlDQo+IGluIGFj
dGl2ZSBWUlIgbW9kZSB0byBwcmV2ZW50IGEgdmJsYW5rIGRpc2FibGUsIGFuZA0KPiBkcm9wIHRo
ZSByZWZlcmVuY2UgYWdhaW4gd2hlbiBzd2l0Y2hpbmcgYmFjayB0byBmaXhlZA0KPiByZWZyZXNo
IHJhdGUgbm9uLVZSUiBtb2RlLg0KPiANCj4gdjI6IE1ha2Ugc3VyZSB0cmFuc2l0aW9uIGlzIGFs
c28gaGFuZGxlZCBpZiB2cnIgaXMNCj4gICAgICBkaXNhYmxlZCBhbmQgc3RyZWFtIGdldHMgZGlz
YWJsZWQgaW4gdGhlIHNhbWUNCj4gICAgICBhdG9taWMgY29tbWl0LiBTdWdnZXN0ZWQgYnkgTmlj
aG9sYXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBNYXJpbyBLbGVpbmVyIDxtYXJpby5rbGVpbmVy
LmRlQGdtYWlsLmNvbT4NCj4gLS0tDQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2Ft
ZGdwdV9kbS9hbWRncHVfZG0uYyB8IDM2ICsrKysrKysrKysrKysrKysrKysrKysrDQo+ICAgMSBm
aWxlIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jIGIvZHJpdmVycy9ncHUv
ZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYw0KPiBpbmRleCBhNzE4YWMyLi4x
YzgzZTgwIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1
X2RtL2FtZGdwdV9kbS5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRn
cHVfZG0vYW1kZ3B1X2RtLmMNCj4gQEAgLTI1MSw2ICsyNTEsMTIgQEAgZ2V0X2NydGNfYnlfb3Rn
X2luc3Qoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsDQo+ICAgCXJldHVybiBOVUxMOw0KPiAg
IH0NCj4gICANCj4gK3N0YXRpYyBpbmxpbmUgYm9vbCBhbWRncHVfZG1fdnJyX2FjdGl2ZShzdHJ1
Y3QgZG1fY3J0Y19zdGF0ZSAqZG1fc3RhdGUpDQo+ICt7DQo+ICsJcmV0dXJuIGRtX3N0YXRlLT5m
cmVlc3luY19jb25maWcuc3RhdGUgPT0gVlJSX1NUQVRFX0FDVElWRV9WQVJJQUJMRSB8fA0KPiAr
CSAgICAgICBkbV9zdGF0ZS0+ZnJlZXN5bmNfY29uZmlnLnN0YXRlID09IFZSUl9TVEFURV9BQ1RJ
VkVfRklYRUQ7DQo+ICt9DQo+ICsNCj4gICBzdGF0aWMgdm9pZCBkbV9wZmxpcF9oaWdoX2lycSh2
b2lkICppbnRlcnJ1cHRfcGFyYW1zKQ0KPiAgIHsNCj4gICAJc3RydWN0IGFtZGdwdV9jcnRjICph
bWRncHVfY3J0YzsNCj4gQEAgLTQ3MTYsNiArNDcyMiwzMSBAQCBzdGF0aWMgdm9pZCB1cGRhdGVf
ZnJlZXN5bmNfc3RhdGVfb25fc3RyZWFtKA0KPiAgIAkJCSAgICAgIChpbnQpdnJyX3BhcmFtcy5z
dGF0ZSk7DQo+ICAgfQ0KPiAgIA0KPiArc3RhdGljIHZvaWQgYW1kZ3B1X2RtX2hhbmRsZV92cnJf
dHJhbnNpdGlvbihzdHJ1Y3QgZG1fY3J0Y19zdGF0ZSAqb2xkX3N0YXRlLA0KPiArCQkJCQkgICAg
c3RydWN0IGRtX2NydGNfc3RhdGUgKm5ld19zdGF0ZSkNCj4gK3sNCj4gKwlib29sIG9sZF92cnJf
YWN0aXZlID0gYW1kZ3B1X2RtX3Zycl9hY3RpdmUob2xkX3N0YXRlKTsNCj4gKwlib29sIG5ld192
cnJfYWN0aXZlID0gYW1kZ3B1X2RtX3Zycl9hY3RpdmUobmV3X3N0YXRlKTsNCj4gKw0KPiArCWlm
ICghb2xkX3Zycl9hY3RpdmUgJiYgbmV3X3Zycl9hY3RpdmUpIHsNCj4gKwkJLyogVHJhbnNpdGlv
biBWUlIgaW5hY3RpdmUgLT4gYWN0aXZlOg0KPiArCQkgKiBXaGlsZSBWUlIgaXMgYWN0aXZlLCB3
ZSBtdXN0IG5vdCBkaXNhYmxlIHZibGFuayBpcnEsIGFzIGENCj4gKwkJICogcmVlbmFibGUgYWZ0
ZXIgZGlzYWJsZSB3b3VsZCBjb21wdXRlIGJvZ3VzIHZibGFuay9wZmxpcA0KPiArCQkgKiB0aW1l
c3RhbXBzIGlmIGl0IGxpa2VseSBoYXBwZW5lZCBpbnNpZGUgZGlzcGxheSBmcm9udC1wb3JjaC4N
Cj4gKwkJICovDQo+ICsJCWRybV9jcnRjX3ZibGFua19nZXQobmV3X3N0YXRlLT5iYXNlLmNydGMp
Ow0KPiArCQlEUk1fREVCVUdfRFJJVkVSKCIlczogY3J0Yz0ldSBWUlIgb2ZmLT5vbjogR2V0IHZi
bGFuayByZWZcbiIsDQo+ICsJCQkJIF9fZnVuY19fLCBuZXdfc3RhdGUtPmJhc2UuY3J0Yy0+YmFz
ZS5pZCk7DQo+ICsJfSBlbHNlIGlmIChvbGRfdnJyX2FjdGl2ZSAmJiAhbmV3X3Zycl9hY3RpdmUp
IHsNCj4gKwkJLyogVHJhbnNpdGlvbiBWUlIgYWN0aXZlIC0+IGluYWN0aXZlOg0KPiArCQkgKiBB
bGxvdyB2YmxhbmsgaXJxIGRpc2FibGUgYWdhaW4gZm9yIGZpeGVkIHJlZnJlc2ggcmF0ZS4NCj4g
KwkJICovDQo+ICsJCWRybV9jcnRjX3ZibGFua19wdXQobmV3X3N0YXRlLT5iYXNlLmNydGMpOw0K
PiArCQlEUk1fREVCVUdfRFJJVkVSKCIlczogY3J0Yz0ldSBWUlIgb24tPm9mZjogRHJvcCB2Ymxh
bmsgcmVmXG4iLA0KPiArCQkJCSBfX2Z1bmNfXywgbmV3X3N0YXRlLT5iYXNlLmNydGMtPmJhc2Uu
aWQpOw0KPiArCX0NCj4gK30NCj4gKw0KPiAgIHN0YXRpYyB2b2lkIGFtZGdwdV9kbV9jb21taXRf
cGxhbmVzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwNCj4gICAJCQkJICAgIHN0cnVj
dCBkY19zdGF0ZSAqZGNfc3RhdGUsDQo+ICAgCQkJCSAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2
LA0KPiBAQCAtNTI1MCw2ICs1MjgxLDExIEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9kbV9hdG9taWNf
Y29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQ0KPiAgIA0KPiAgIAkJ
ZG1fbmV3X2NydGNfc3RhdGUgPSB0b19kbV9jcnRjX3N0YXRlKG5ld19jcnRjX3N0YXRlKTsNCj4g
ICAJCWRtX29sZF9jcnRjX3N0YXRlID0gdG9fZG1fY3J0Y19zdGF0ZShvbGRfY3J0Y19zdGF0ZSk7
DQo+ICsNCj4gKwkJLyogSGFuZGxlIHZyciBvbi0+b2ZmIC8gb2ZmLT5vbiB0cmFuc2l0aW9ucyAq
Lw0KPiArCQlhbWRncHVfZG1faGFuZGxlX3Zycl90cmFuc2l0aW9uKGRtX29sZF9jcnRjX3N0YXRl
LA0KPiArCQkJCQkJZG1fbmV3X2NydGNfc3RhdGUpOw0KPiArDQoNCkkgZ3Vlc3MgdGhlcmUncyBh
Y3R1YWxseSBhbm90aGVyIHByb2JsZW0gd2l0aCB0aGlzIGhlcmUgLSB3ZSB3b24ndCBoYXZlIA0K
dGhlIGFjdHVhbCBkbV9zdGF0ZS0+ZnJlZXN5bmNfY29uZmlnLnN0YXRlIHVudGlsIHRoZSBjb21t
aXQgZm9sbG93aW5nIA0KdGhpcyBvbmUgc2luY2UgaXQgZ2V0cyBjYWxjdWxhdGVkIGJlbG93IHRo
aXMgdHJhbnNpdGlvbiBoYW5kbGVyLg0KDQpXZSBuZWVkIHRoaXMgaGFuZGxlciB0byB0cmlnZ2Vy
IGJlZm9yZSB0aGUgbmV3IGZyYW1lYnVmZmVyIGFkZHJlc3MgaXMgDQp3cml0dGVuIGJ1dCBhZnRl
ciB0aGVzZSBwYXJhbWV0ZXJzIGFyZSBjYWxjdWxhdGVkLg0KDQpTbyB0aGlzIG5lZWRzIGEgdjMg
b3IgYW5vdGhlciBwYXRjaCBpbiB0aGUgc2VyaWVzIHRoYXQgc2hpZnRzIHRoZSANCmNhbGN1bGF0
aW9uIG9mIGNvbmZpZy5zdGF0ZSBiZWZvcmUgdGhpcy4NCg0KV2hpbGUgaXQncyBwcm9iYWJseSBz
dWZmaWNpZW50IHRvIGp1c3QgcmV1c2UgdGhlIGJsb2NrOg0KDQoJaWYgKG5ld19jcnRjX3N0YXRl
LT52cnJfc3VwcG9ydGVkICYmDQoJICAgIGNvbmZpZy5taW5fcmVmcmVzaF9pbl91aHogJiYNCgkg
ICAgY29uZmlnLm1heF9yZWZyZXNoX2luX3Voeikgew0KCQljb25maWcuc3RhdGUgPSBuZXdfY3J0
Y19zdGF0ZS0+YmFzZS52cnJfZW5hYmxlZCA/DQoJCQlWUlJfU1RBVEVfQUNUSVZFX1ZBUklBQkxF
IDoNCgkJCVZSUl9TVEFURV9JTkFDVElWRTsNCgl9IGVsc2Ugew0KCQljb25maWcuc3RhdGUgPSBW
UlJfU1RBVEVfVU5TVVBQT1JURUQ7DQoJfQ0KDQp0aGUgcHJvYmxlbSBpcyBjb25maWcuc3RhdGUg
Y291bGQgc3RpbGwgdGVjaG5pY2FsbHkgYmUgbW9kaWZpZWQgd2l0aGluIA0KbW9kX2ZyZWVzeW5j
X2J1aWxkX3Zycl9wYXJhbXMgSSB0aGluay4NCg0KU28gaXQncyBwcm9iYWJseSBiZXN0IHRvIHNo
aWZ0IGV2ZXJ5dGhpbmcgdXAgdG8gYW5kIGluY2x1ZGluZyANCm1vZF9mcmVlc3luY19idWlsZF92
cnJfcGFyYW1zKC4uLikgZnJvbSB3aXRoaW4gDQp1cGRhdGVfZnJlZXN5bmNfc3RhdGVfb25fc3Ry
ZWFtKC4uLikgZWFybGllciwgZWl0aGVyIGluIGF0b21pYyBjaGVjayBvciANCmluIGNvbW1pdCB0
YWlsIGluIGFub3RoZXIgbG9vcC4NCg0KV2hpbGUgSSBwcmVmZXIgdGhlIGZpcnN0IGFwcHJvYWNo
LCBpdCdzIGEgbGl0dGxlIGJpdCBjb21wbGljYXRlZC4gVGhlIA0KZ2V0X2ZyZWVzeW5jX2NvbmZp
Z19mb3JfY3J0YyBsb29rcyBsaWtlIHRoZSByaWdodCBwbGFjZSB0byBwdXQgdGhpcywgYnV0IA0K
dGhhdCBmdW5jdGlvbiB3b3VsZCBoYXZlIHRvIGJlIG1vdmVkLiBUaGUgcHJvYmxlbSBpcyB0aGF0
DQoNCmlmICghKGVuYWJsZSAmJiBhY29ubmVjdG9yICYmIG5ld19jcnRjX3N0YXRlLT5lbmFibGUg
JiYNCgkgICAgICBuZXdfY3J0Y19zdGF0ZS0+YWN0aXZlKSkNCg0KV29uJ3QgYmUgdHJ1ZSBpZiB3
ZSdyZSBkaXNhYmxpbmcgYSBDUlRDIGF0IHRoZSBzYW1lIHRpbWUgd2UncmUgZGlzYWJsaW5nIA0K
VlJSLiBUaGUgcmVzZXRfZnJlZXN5bmNfY29uZmlnX2Zvcl9jcnRjIGZ1bmN0aW9uIHdvdWxkIGNv
dmVyIHRoaXMgYnV0IGl0IA0KZG9lc24ndCBhY3R1YWxseSB0b3VjaCB0aGUgZnJlZXN5bmNfY29u
ZmlnIC0gYnV0IEkgdGhpbmsgaXQncyBzYWZlIHRvIGRvIA0Kc28sIHNpbmNlIHRoZSBjaGVjayBh
Ym92ZSB3aWxsIGJlIHRydWUgaWYgdGhlIHN0cmVhbSBzdGlsbCBleGlzdHMuDQoNCk5pY2hvbGFz
IEthemxhdXNrYXMNCg0KPiAgIAkJbW9kZXNldF9uZWVkZWQgPSBtb2Rlc2V0X3JlcXVpcmVkKA0K
PiAgIAkJCQluZXdfY3J0Y19zdGF0ZSwNCj4gICAJCQkJZG1fbmV3X2NydGNfc3RhdGUtPnN0cmVh
bSwNCj4gDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==