* [PATCH] drm/amdgpu: add to custom amdgpu_drm_release drm_dev_enter/exit
@ 2025-08-07 22:01 vitaly.prosyak
0 siblings, 0 replies; 3+ messages in thread
From: vitaly.prosyak @ 2025-08-07 22:01 UTC (permalink / raw)
To: amd-gfx; +Cc: Vitaly Prosyak
From: Vitaly Prosyak <vitaly.prosyak@amd.com>
User queues are disabled before GEM objects are released
(protecting against user app crashes).
No races with PCI hot-unplug (because drm_dev_enter prevents cleanup
if device is being removed).
Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 4ff3a2eaaf55..32caaef522a1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -2920,11 +2920,14 @@ static int amdgpu_drm_release(struct inode *inode, struct file *filp)
{
struct drm_file *file_priv = filp->private_data;
struct amdgpu_fpriv *fpriv = file_priv->driver_priv;
+ struct drm_device *dev = file_priv->minor->dev;
+ int idx;
- if (fpriv) {
+ if (fpriv && drm_dev_enter(dev, &idx)) {
fpriv->evf_mgr.fd_closing = true;
amdgpu_eviction_fence_destroy(&fpriv->evf_mgr);
amdgpu_userq_mgr_fini(&fpriv->userq_mgr);
+ drm_dev_exit(idx);
}
return drm_release(inode, filp);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] drm/amdgpu: add to custom amdgpu_drm_release drm_dev_enter/exit
@ 2025-08-07 22:04 vitaly.prosyak
2025-08-08 9:19 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: vitaly.prosyak @ 2025-08-07 22:04 UTC (permalink / raw)
To: amd-gfx; +Cc: Vitaly Prosyak, Christian König, Alex Deucher
From: Vitaly Prosyak <vitaly.prosyak@amd.com>
User queues are disabled before GEM objects are released
(protecting against user app crashes).
No races with PCI hot-unplug (because drm_dev_enter prevents cleanup
if device is being removed).
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 4ff3a2eaaf55..32caaef522a1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -2920,11 +2920,14 @@ static int amdgpu_drm_release(struct inode *inode, struct file *filp)
{
struct drm_file *file_priv = filp->private_data;
struct amdgpu_fpriv *fpriv = file_priv->driver_priv;
+ struct drm_device *dev = file_priv->minor->dev;
+ int idx;
- if (fpriv) {
+ if (fpriv && drm_dev_enter(dev, &idx)) {
fpriv->evf_mgr.fd_closing = true;
amdgpu_eviction_fence_destroy(&fpriv->evf_mgr);
amdgpu_userq_mgr_fini(&fpriv->userq_mgr);
+ drm_dev_exit(idx);
}
return drm_release(inode, filp);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: add to custom amdgpu_drm_release drm_dev_enter/exit
2025-08-07 22:04 [PATCH] drm/amdgpu: add to custom amdgpu_drm_release drm_dev_enter/exit vitaly.prosyak
@ 2025-08-08 9:19 ` Christian König
0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2025-08-08 9:19 UTC (permalink / raw)
To: vitaly.prosyak, amd-gfx; +Cc: Alex Deucher
On 08.08.25 00:04, vitaly.prosyak@amd.com wrote:
> From: Vitaly Prosyak <vitaly.prosyak@amd.com>
>
> User queues are disabled before GEM objects are released
> (protecting against user app crashes).
> No races with PCI hot-unplug (because drm_dev_enter prevents cleanup
> if device is being removed).
>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 4ff3a2eaaf55..32caaef522a1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -2920,11 +2920,14 @@ static int amdgpu_drm_release(struct inode *inode, struct file *filp)
> {
> struct drm_file *file_priv = filp->private_data;
> struct amdgpu_fpriv *fpriv = file_priv->driver_priv;
> + struct drm_device *dev = file_priv->minor->dev;
> + int idx;
>
> - if (fpriv) {
> + if (fpriv && drm_dev_enter(dev, &idx)) {
> fpriv->evf_mgr.fd_closing = true;
> amdgpu_eviction_fence_destroy(&fpriv->evf_mgr);
> amdgpu_userq_mgr_fini(&fpriv->userq_mgr);
> + drm_dev_exit(idx);
> }
>
> return drm_release(inode, filp);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-08 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-07 22:04 [PATCH] drm/amdgpu: add to custom amdgpu_drm_release drm_dev_enter/exit vitaly.prosyak
2025-08-08 9:19 ` Christian König
-- strict thread matches above, loose matches on Subject: below --
2025-08-07 22:01 vitaly.prosyak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).