AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@amd.com>
To: amd-gfx@lists.freedesktop.org
Cc: philip.yang@amd.com, felix.kuehling@amd.com, lijo.lazar@amd.com,
	christian.koenig@amd.com
Subject: Re: [PATCH 2/3] drm/amdgpu: Initialize acpi mem ranges after TTM
Date: Mon, 2 Oct 2023 11:44:59 -0400	[thread overview]
Message-ID: <ce2d3e80-dcc5-2e27-2489-3fa7dc720e82@amd.com> (raw)
In-Reply-To: <20230929181856.2311515-2-rajneesh.bhardwaj@amd.com>

I found an issue with this patch, that leads to performance drop. This 
leads to incorrectly initialize numa pools on a multi node system. I am 
working on the fix and will send another change set.

On 9/29/2023 2:18 PM, Rajneesh Bhardwaj wrote:
> Move ttm init before acpi mem range init so we can use ttm_pages_limit
> to override vram size for GFXIP 9.4.3. The vram size override change
> will be introduced in a future commit.
>
> Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 268ee533e7c1..005ea719d2fd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -2190,17 +2190,17 @@ static int gmc_v9_0_sw_init(void *handle)
>   
>   	amdgpu_gmc_get_vbios_allocations(adev);
>   
> +	/* Memory manager */
> +	r = amdgpu_bo_init(adev);
> +	if (r)
> +		return r;
> +
>   	if (amdgpu_ip_version(adev, GC_HWIP, 0) == IP_VERSION(9, 4, 3)) {
>   		r = gmc_v9_0_init_mem_ranges(adev);
>   		if (r)
>   			return r;
>   	}
>   
> -	/* Memory manager */
> -	r = amdgpu_bo_init(adev);
> -	if (r)
> -		return r;
> -
>   	r = gmc_v9_0_gart_init(adev);
>   	if (r)
>   		return r;

  reply	other threads:[~2023-10-02 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 18:18 [PATCH 1/3] drm/amdgpu: Rework KFD memory max limits Rajneesh Bhardwaj
2023-09-29 18:18 ` [PATCH 2/3] drm/amdgpu: Initialize acpi mem ranges after TTM Rajneesh Bhardwaj
2023-10-02 15:44   ` Bhardwaj, Rajneesh [this message]
2023-09-29 18:18 ` [PATCH 3/3] drm/amdgpu: Use ttm_pages_limit to override vram reporting Rajneesh Bhardwaj
2023-09-29 20:54 ` [PATCH 1/3] drm/amdgpu: Rework KFD memory max limits Felix Kuehling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce2d3e80-dcc5-2e27-2489-3fa7dc720e82@amd.com \
    --to=rajneesh.bhardwaj@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=felix.kuehling@amd.com \
    --cc=lijo.lazar@amd.com \
    --cc=philip.yang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox