Re: [PATCH 2/5] drm/amdgpu: always enable shadow BOs

["Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Am 11.09.2018 um 14:29 schrieb Michel Dänzer:
> On 2018-09-11 11:55 a.m., Christian König wrote:
>> Even when GPU recovery is disabled we could run into a manually
>> triggered recovery.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 27 +--------------------------
>>   1 file changed, 1 insertion(+), 26 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index a7e39c9dd14b..7db0040ca145 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -38,31 +38,6 @@
>>   #include "amdgpu_trace.h"
>>   #include "amdgpu_amdkfd.h"
>>   
>> -/**
>> - * DOC: amdgpu_object
>> - *
>> - * This defines the interfaces to operate on an &amdgpu_bo buffer object which
>> - * represents memory used by driver (VRAM, system memory, etc.). The driver
>> - * provides DRM/GEM APIs to userspace. DRM/GEM APIs then use these interfaces
>> - * to create/destroy/set buffer object which are then managed by the kernel TTM
>> - * memory manager.
>> - * The interfaces are also used internally by kernel clients, including gfx,
>> - * uvd, etc. for kernel managed allocations used by the GPU.
>> - *
>> - */
> This comment shouldn't be removed, should it? Otherwise the commit log
> needs to explain this, and the reference in Documentation/gpu/amdgpu.rst
> needs to be removed as well.

Oh, that was indeed an accident. Going to fix that.

Thanks,
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx