From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Roger He <Hongbo.He@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero
Date: Wed, 22 Nov 2017 12:54:44 +0100 [thread overview]
Message-ID: <d0c8f831-eafe-4cb8-feae-4fb063bf429d@gmail.com> (raw)
In-Reply-To: <151135142294.5636.17032818438593706175@mail.alporthouse.com>
Am 22.11.2017 um 12:50 schrieb Chris Wilson:
> Quoting Roger He (2017-11-22 11:44:27)
>> Change-Id: Idf5ccb579d264b343199d8b8344bddeec2c0019f
>> Signed-off-by: Roger He <Hongbo.He@amd.com>
>> ---
>> drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c
>> index a8b2bfa..cdbb731 100644
>> --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
>> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
>> @@ -223,6 +223,17 @@ static struct kobj_type ttm_pool_kobj_type = {
>> static struct ttm_pool_manager *_manager;
>>
>> #ifndef CONFIG_X86
>> +static int set_pages_wb(struct page *page, int numpages)
>> +{
>> +#if IS_ENABLED(CONFIG_AGP)
>> + int i;
>> +
>> + for (i = 0; i < numpages; i++)
>> + unmap_page_from_agp(page++);
>> +#endif
>> + return 0;
>> +}
>> +
>> static int set_pages_array_wb(struct page **pages, int addrinarray)
> Both of these are shadowing exports from arch/x86, probably not the
> wisest choice of names.
That is intended, please note the "#ifndef CONFIG_X86".
Basically TTM provides the same function for other architectures that we
have for X86.
Christian.
> -Chris
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-22 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 11:44 [PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero Roger He
[not found] ` <1511351069-4757-1-git-send-email-Hongbo.He-5C7GfCeVMHo@public.gmane.org>
2017-11-22 11:44 ` [PATCH 2/3] drm/ttm: add page order support in ttm_pages_put Roger He
2017-11-22 11:50 ` [PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero Chris Wilson
2017-11-22 11:54 ` Christian König [this message]
2017-11-22 11:44 ` [PATCH 3/3] drm/ttm: roundup the shrink request to prevent skip huge pool Roger He
2017-11-22 11:52 ` Chris Wilson
2017-11-22 11:53 ` [PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0c8f831-eafe-4cb8-feae-4fb063bf429d@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Hongbo.He@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox