From: Mario Limonciello <mario.limonciello@amd.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Sunil Khatri <sunil.khatri@amd.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Xinhui Pan" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Lijo Lazar" <lijo.lazar@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Ma Jun" <Jun.Ma2@amd.com>,
"Victor Lu" <victorchengchi.lu@amd.com>,
"Yunxiang Li" <Yunxiang.Li@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] drm/amdgpu: Fix amdgpu_ip_block_hw_fini()
Date: Thu, 24 Oct 2024 10:00:26 -0500 [thread overview]
Message-ID: <d99db508-3f45-4a9e-b28e-58248b5fc4df@amd.com> (raw)
In-Reply-To: <f4fc849e-4e76-4448-8657-caa4c69910b0@stanley.mountain>
On 10/24/2024 03:17, Dan Carpenter wrote:
> This NULL check is reversed so the function doesn't work.
>
> Fixes: dad01f93f432 ("drm/amdgpu: validate hw_fini before function call")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks!
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Also applied to amd-staging-drm-next.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 91c1f2188498..f12fab13386a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3309,7 +3309,7 @@ static void amdgpu_ip_block_hw_fini(struct amdgpu_ip_block *ip_block)
> {
> int r;
>
> - if (ip_block->version->funcs->hw_fini) {
> + if (!ip_block->version->funcs->hw_fini) {
> DRM_ERROR("hw_fini of IP block <%s> not defined\n",
> ip_block->version->funcs->name);
> } else {
prev parent reply other threads:[~2024-10-24 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 8:17 [PATCH next] drm/amdgpu: Fix amdgpu_ip_block_hw_fini() Dan Carpenter
2024-10-24 15:00 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d99db508-3f45-4a9e-b28e-58248b5fc4df@amd.com \
--to=mario.limonciello@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jun.Ma2@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=Yunxiang.Li@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=sunil.khatri@amd.com \
--cc=victorchengchi.lu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox