AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: Pekka Paalanen <pekka.paalanen@collabora.com>
Cc: "Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Daniel Stone" <daniels@collabora.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, kernel@collabora.com,
	"Derek Foreman" <derek.foreman@collabora.com>,
	"Marius Vlad" <marius.vlad@collabora.com>
Subject: Re: [PATCH v5 0/3] Add "link bpc" DRM property
Date: Tue, 31 Mar 2026 14:56:22 +0200	[thread overview]
Message-ID: <d9abba15-382d-4bc1-a58a-71bb8413eeac@mailbox.org> (raw)
In-Reply-To: <20260331153805.376486e2@fluorite>

On 3/31/26 14:38, Pekka Paalanen wrote:
> On Tue, 31 Mar 2026 10:01:59 +0200
> Michel Dänzer <michel.daenzer@mailbox.org> wrote:
>> On 3/26/26 14:53, Pekka Paalanen wrote:
>>> On Tue, 24 Mar 2026 17:44:21 +0100
>>> Michel Dänzer <michel.daenzer@mailbox.org> wrote:
>>>   
>>>> * There's no clear use case.
>>>>
>>>> This is generally a requirement for new KMS UAPI.
>>>>
>>>> The practical usefulness of the corresponding weston MR is dubious
>>>> per the concern above.  
>>>
>>> I think the example of RGB 10 bpc to be degraded to YCbCr 10 bpc
>>> rather than RGB 8 bpc is an excellent use case.  
>>
>> This series and the corresponding Weston MR aren't enough to address
>> that use case though, are they? All they achieve is logging a
>> potentially misleading warning.
>>
>> It might make sense to combine this series and the Weston MR with
>> whatever else is needed for that use case.
> 
> What do you believe is missing?

For the stated use case, e.g. a mechanism to control RGB vs YCbCr?


> Informing the user that the display quality may not be as expected is
> the point.

The warning implies that the "link bpc" value is expected to match the "max bpc" value, which generally isn't the case.


>>> I had another use case in
>>> https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1850#note_3115686  
>>
>> That would need to take dithering into account as well?
> 
> Yes, dithering could be an adverse effect or not sufficient. Hence the
> 'link bpc' property should not consider any kind of dithering, to be on
> the safe side. I fully expect dithering to become explicitly
> controllable, as policy belongs in userspace.

I agree that would be ideal, alas it's not current reality.


-- 
Earthling Michel Dänzer       \        GNOME / Xwayland / Mesa developer
https://redhat.com             \               Libre software enthusiast

  reply	other threads:[~2026-03-31 12:56 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 12:28 [PATCH v5 0/3] Add "link bpc" DRM property Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 1/3] drm/connector: Add a 'link bpc' property Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 2/3] drm/connector: hdmi: Add support for " Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 3/3] drm/amd/display: " Nicolas Frattaroli
2026-03-20 14:32 ` [PATCH v5 0/3] Add "link bpc" DRM property Michel Dänzer
2026-03-20 18:02   ` Nicolas Frattaroli
2026-03-21  2:33     ` Mario Kleiner
2026-03-23 11:44       ` Michel Dänzer
2026-03-23 10:55     ` Michel Dänzer
2026-03-23 12:05       ` Nicolas Frattaroli
2026-03-23 14:38         ` Michel Dänzer
2026-03-23 16:55           ` Nicolas Frattaroli
2026-03-23 17:27             ` Michel Dänzer
2026-03-24 15:25               ` Nicolas Frattaroli
2026-03-24 16:44                 ` Michel Dänzer
2026-03-26 12:17                   ` Nicolas Frattaroli
2026-03-30 16:57                     ` Michel Dänzer
2026-03-30 18:52                       ` Harry Wentland
2026-03-31 12:50                         ` Pekka Paalanen
2026-03-31 17:47                           ` Harry Wentland
2026-04-01  8:40                             ` Daniel Stone
2026-04-01 11:10                               ` Ville Syrjälä
2026-04-01 11:43                                 ` Daniel Stone
2026-04-01 12:46                               ` Nicolas Frattaroli
2026-04-02 17:06                                 ` Harry Wentland
2026-04-01 13:57                               ` Ville Syrjälä
2026-04-01 14:17                                 ` Daniel Stone
2026-04-02  2:55                                   ` Mario Kleiner
2026-04-02 17:01                               ` Harry Wentland
2026-03-26 13:53                   ` Pekka Paalanen
2026-03-30 19:01                     ` Harry Wentland
2026-03-31 10:28                       ` Pekka Paalanen
2026-03-31 17:37                         ` Harry Wentland
2026-04-09 15:05                       ` Nicolas Dufresne
2026-03-31  8:01                     ` Michel Dänzer
2026-03-31 12:38                       ` Pekka Paalanen
2026-03-31 12:56                         ` Michel Dänzer [this message]
2026-03-31 14:21                           ` Pekka Paalanen
2026-04-01  7:46                             ` Michel Dänzer
2026-04-09 22:20     ` Dmitry Baryshkov
2026-04-01 11:57 ` Xaver Hugl
2026-04-01 12:11   ` Ville Syrjälä
2026-04-01 12:25     ` Daniel Stone
2026-04-01 12:56       ` Ville Syrjälä
2026-04-01 12:14   ` Nicolas Frattaroli
2026-04-03 10:23     ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9abba15-382d-4bc1-a58a-71bb8413eeac@mailbox.org \
    --to=michel.daenzer@mailbox.org \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniels@collabora.com \
    --cc=derek.foreman@collabora.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marius.vlad@collabora.com \
    --cc=mripard@kernel.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=pekka.paalanen@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox