From: Lancelot SIX <Lancelot.Six@amd.com>
To: Jay Cornwall <jay.cornwall@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/amdkfd: Fix instruction hazard in gfx12 trap handler
Date: Tue, 11 Mar 2025 21:56:20 +0000 [thread overview]
Message-ID: <d9e926ca-bdda-4237-b954-8b3a2e41eeab@amd.com> (raw)
In-Reply-To: <20250207233837.2738432-1-jay.cornwall@amd.com>
On 07/02/2025 23:38, Jay Cornwall wrote:
> VALU instructions with SGPR source need wait states to avoid hazard
> with SALU using different SGPR.
>
> v2: Eliminate some hazards to reduce code explosion
>
> Signed-off-by: Jay Cornwall <jay.cornwall@amd.com>
> Cc: Lancelot Six <lancelot.six@amd.com>
Hi,
That looks good to me, thanks. Sorry for the long delay to review.
Reviewed-by: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
> ---
> .../gpu/drm/amd/amdkfd/cwsr_trap_handler.h | 677 ++++++++++--------
> .../amd/amdkfd/cwsr_trap_handler_gfx12.asm | 82 ++-
> 2 files changed, 404 insertions(+), 355 deletions(-
prev parent reply other threads:[~2025-03-11 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 23:38 [PATCH v2] drm/amdkfd: Fix instruction hazard in gfx12 trap handler Jay Cornwall
2025-02-27 16:50 ` Jay Cornwall
2025-02-27 16:53 ` Alex Deucher
2025-03-11 21:56 ` Lancelot SIX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e926ca-bdda-4237-b954-8b3a2e41eeab@amd.com \
--to=lancelot.six@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=jay.cornwall@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox