AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Philip Yang <Philip.Yang@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Felix.Kuehling@amd.com
Subject: Re: [PATCH] drm/amdgpu: amdgpu_ttm_gart_bind set gtt bound flag
Date: Tue, 12 Mar 2024 07:34:44 +0100	[thread overview]
Message-ID: <dc026133-0071-4e3d-8b91-1b02f0fc178f@amd.com> (raw)
In-Reply-To: <20240311222119.29917-1-Philip.Yang@amd.com>

Am 11.03.24 um 23:21 schrieb Philip Yang:
> Otherwise amdgpu_ttm_backend_unbind will not clear the gart page table
> and leave valid mapping entry to the stale system page.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>

Good catch, that bug is probably in there for quite a while.

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 75c9fd2c6c2a..b0ed10f4de60 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -869,6 +869,7 @@ static void amdgpu_ttm_gart_bind(struct amdgpu_device *adev,
>   		amdgpu_gart_bind(adev, gtt->offset, ttm->num_pages,
>   				 gtt->ttm.dma_address, flags);
>   	}
> +	gtt->bound = true;
>   }
>   
>   /*


      reply	other threads:[~2024-03-12  6:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 22:21 [PATCH] drm/amdgpu: amdgpu_ttm_gart_bind set gtt bound flag Philip Yang
2024-03-12  6:34 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc026133-0071-4e3d-8b91-1b02f0fc178f@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Philip.Yang@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox