From mboxrd@z Thu Jan  1 00:00:00 1970
From: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 04/12] drm/amdgpu: move IV prescreening into the GMC code
Date: Tue, 9 Oct 2018 19:46:49 -0400
Message-ID: <dcf7fd50-e453-8a9d-cdaa-c452d4716e9a@amd.com>
References: <20180926135330.2218-1-christian.koenig@amd.com>
 <20180926135330.2218-4-christian.koenig@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20180926135330.2218-4-christian.koenig-5C7GfCeVMHo@public.gmane.org>
Content-Language: en-CA
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

SSByZWFsaXplZCB0aGF0IG1vc3Qgb2YgdGhlIGNvZGUgaW4gZ21jX3Y5XzBfcHNlc2NyZWVuX2l2
IGlzIG5vdAphY3R1YWxseSBoYXJkd2FyZS1zcGVjaWZpYy4gSWYgaXQgd2FzIG5vdCBwcmVzY3Jl
ZW5pbmcsIGJ1dCB1c2luZyBhbgphbWRncHVfaXZfZW50cnkgdGhhdCB3YXMgYWxyZWFkeSBwYXJz
ZWQsIEkgdGhpbmsgaXQgY291bGQganVzdCBiZSBhCmdlbmVyaWMgZnVuY3Rpb24gZm9yIHByb2Nl
c3NpbmcgcmV0cnkgZmF1bHRzOgoKICAqIGxvb2tpbmcgdXAgdGhlIFZNIG9mIGEgZmF1bHQKICAq
IHN0b3JpbmcgcmV0cnkgZmF1bHRzIGluIGEgcGVyLVZNIGZpZm8KICAqIGRyb3BwaW5nIGZhdWx0
cyB0aGF0IGhhdmUgYWxyZWFkeSBiZWVuIHNlZW4KCkluIG90aGVyIHdvcmRzLCBpdCdzIGp1c3Qg
YSBnZW5lcmljIHRvcCBoYWxmIGludGVycnVwdCBoYW5kbGVyIGZvciByZXRyeQpmYXVsdHMgd2hp
bGUgdGhlIGJvdHRvbSBoYWxmICh3b3JrZXIgdGhyZWFkKSB3b3VsZCB1c2UgdGhlIHBlci1WTSBG
SUZPcwp0byBoYW5kbGUgdGhvc2UgcGVuZGluZyByZXRyeSBmYXVsdHMuCgpSZWdhcmRzLArCoCBG
ZWxpeAoKCk9uIDIwMTgtMDktMjYgMDk6NTMgQU0sIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4g
VGhlIEdNQy9WTSBzdWJzeXN0ZW0gaXMgY2F1c2luZyB0aGUgZmF1bHRzLCBzbyBtb3ZlIHRoZSBo
YW5kbGluZyBoZXJlIGFzCj4gd2VsbC4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7Zu
aWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2Ft
ZC9hbWRncHUvZ21jX3Y5XzAuYyAgfCA1OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+
ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS92ZWdhMTBfaWguYyB8IDY5IC0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA1OSBpbnNlcnRpb25z
KCspLCA2OSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k
L2FtZGdwdS9nbWNfdjlfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAu
Ywo+IGluZGV4IDcyOWEyYzIzMGY5MS4uZjhkNjlhYjg1ZmMzIDEwMDY0NAo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192OV8wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v
YW1kL2FtZGdwdS9nbWNfdjlfMC5jCj4gQEAgLTI0NCw2ICsyNDQsNjIgQEAgc3RhdGljIGludCBn
bWNfdjlfMF92bV9mYXVsdF9pbnRlcnJ1cHRfc3RhdGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk
ZXYsCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiArLyoqCj4gKyAqIHZlZ2ExMF9paF9wcmVzY3Jl
ZW5faXYgLSBwcmVzY3JlZW4gYW4gaW50ZXJydXB0IHZlY3Rvcgo+ICsgKgo+ICsgKiBAYWRldjog
YW1kZ3B1X2RldmljZSBwb2ludGVyCj4gKyAqCj4gKyAqIFJldHVybnMgdHJ1ZSBpZiB0aGUgaW50
ZXJydXB0IHZlY3RvciBzaG91bGQgYmUgZnVydGhlciBwcm9jZXNzZWQuCj4gKyAqLwo+ICtzdGF0
aWMgYm9vbCBnbWNfdjlfMF9wcmVzY3JlZW5faXYoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYs
Cj4gKwkJCQkgIHN0cnVjdCBhbWRncHVfaXZfZW50cnkgKmVudHJ5LAo+ICsJCQkJICB1aW50NjRf
dCBhZGRyKQo+ICt7Cj4gKwlzdHJ1Y3QgYW1kZ3B1X3ZtICp2bTsKPiArCXU2NCBrZXk7Cj4gKwlp
bnQgcjsKPiArCj4gKwkvKiBObyBQQVNJRCwgY2FuJ3QgaWRlbnRpZnkgZmF1bHRpbmcgcHJvY2Vz
cyAqLwo+ICsJaWYgKCFlbnRyeS0+cGFzaWQpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICsJLyog
Tm90IGEgcmV0cnkgZmF1bHQgKi8KPiArCWlmICghKGVudHJ5LT5zcmNfZGF0YVsxXSAmIDB4ODAp
KQo+ICsJCXJldHVybiB0cnVlOwo+ICsKPiArCS8qIFRyYWNrIHJldHJ5IGZhdWx0cyBpbiBwZXIt
Vk0gZmF1bHQgRklGTy4gKi8KPiArCXNwaW5fbG9jaygmYWRldi0+dm1fbWFuYWdlci5wYXNpZF9s
b2NrKTsKPiArCXZtID0gaWRyX2ZpbmQoJmFkZXYtPnZtX21hbmFnZXIucGFzaWRfaWRyLCBlbnRy
eS0+cGFzaWQpOwo+ICsJaWYgKCF2bSkgewo+ICsJCS8qIFZNIG5vdCBmb3VuZCwgcHJvY2VzcyBp
dCBub3JtYWxseSAqLwo+ICsJCXNwaW5fdW5sb2NrKCZhZGV2LT52bV9tYW5hZ2VyLnBhc2lkX2xv
Y2spOwo+ICsJCXJldHVybiB0cnVlOwo+ICsJfQo+ICsKPiArCWtleSA9IEFNREdQVV9WTV9GQVVM
VChlbnRyeS0+cGFzaWQsIGFkZHIpOwo+ICsJciA9IGFtZGdwdV92bV9hZGRfZmF1bHQodm0tPmZh
dWx0X2hhc2gsIGtleSk7Cj4gKwo+ICsJLyogSGFzaCB0YWJsZSBpcyBmdWxsIG9yIHRoZSBmYXVs
dCBpcyBhbHJlYWR5IGJlaW5nIHByb2Nlc3NlZCwKPiArCSAqIGlnbm9yZSBmdXJ0aGVyIHBhZ2Ug
ZmF1bHRzCj4gKwkgKi8KPiArCWlmIChyICE9IDApIHsKPiArCQlzcGluX3VubG9jaygmYWRldi0+
dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gKwkvKiBO
byBsb2NraW5nIHJlcXVpcmVkIHdpdGggc2luZ2xlIHdyaXRlciBhbmQgc2luZ2xlIHJlYWRlciAq
Lwo+ICsJciA9IGtmaWZvX3B1dCgmdm0tPmZhdWx0cywga2V5KTsKPiArCWlmICghcikgewo+ICsJ
CS8qIEZJRk8gaXMgZnVsbC4gSWdub3JlIGl0IHVudGlsIHRoZXJlIGlzIHNwYWNlICovCj4gKwkJ
YW1kZ3B1X3ZtX2NsZWFyX2ZhdWx0KHZtLT5mYXVsdF9oYXNoLCBrZXkpOwo+ICsJCXNwaW5fdW5s
b2NrKCZhZGV2LT52bV9tYW5hZ2VyLnBhc2lkX2xvY2spOwo+ICsJCXJldHVybiBmYWxzZTsKPiAr
CX0KPiArCj4gKwlzcGluX3VubG9jaygmYWRldi0+dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPiAr
CS8qIEl0J3MgdGhlIGZpcnN0IGZhdWx0IGZvciB0aGlzIGFkZHJlc3MsIHByb2Nlc3MgaXQgbm9y
bWFsbHkgKi8KPiArCXJldHVybiB0cnVlOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGdtY192OV8w
X3Byb2Nlc3NfaW50ZXJydXB0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAJCQkJc3Ry
dWN0IGFtZGdwdV9pcnFfc3JjICpzb3VyY2UsCj4gIAkJCQlzdHJ1Y3QgYW1kZ3B1X2l2X2VudHJ5
ICplbnRyeSkKPiBAQCAtMjU1LDYgKzMxMSw5IEBAIHN0YXRpYyBpbnQgZ21jX3Y5XzBfcHJvY2Vz
c19pbnRlcnJ1cHQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAlhZGRyID0gKHU2NCll
bnRyeS0+c3JjX2RhdGFbMF0gPDwgMTI7Cj4gIAlhZGRyIHw9ICgodTY0KWVudHJ5LT5zcmNfZGF0
YVsxXSAmIDB4ZikgPDwgNDQ7Cj4gIAo+ICsJaWYgKCFnbWNfdjlfMF9wcmVzY3JlZW5faXYoYWRl
diwgZW50cnksIGFkZHIpKQo+ICsJCXJldHVybiAxOwo+ICsKPiAgCWlmICghYW1kZ3B1X3NyaW92
X3ZmKGFkZXYpKSB7Cj4gIAkJc3RhdHVzID0gUlJFRzMyKGh1Yi0+dm1fbDJfcHJvX2ZhdWx0X3N0
YXR1cyk7Cj4gIAkJV1JFRzMyX1AoaHViLT52bV9sMl9wcm9fZmF1bHRfY250bCwgMSwgfjEpOwo+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS92ZWdhMTBfaWguYyBiL2Ry
aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3ZlZ2ExMF9paC5jCj4gaW5kZXggMGY1MGJlZjg3MTYz
Li4wZjY4YTBjZDFmYmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv
dmVnYTEwX2loLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS92ZWdhMTBfaWgu
Ywo+IEBAIC0yMjgsNzYgKzIyOCw3IEBAIHN0YXRpYyB1MzIgdmVnYTEwX2loX2dldF93cHRyKHN0
cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgKi8KPiAgc3RhdGljIGJvb2wgdmVnYTEwX2lo
X3ByZXNjcmVlbl9pdihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgewo+IC0JdTMyIHJp
bmdfaW5kZXggPSBhZGV2LT5pcnEuaWgucnB0ciA+PiAyOwo+IC0JdTMyIGR3MCwgZHczLCBkdzQs
IGR3NTsKPiAtCXUxNiBwYXNpZDsKPiAtCXU2NCBhZGRyLCBrZXk7Cj4gLQlzdHJ1Y3QgYW1kZ3B1
X3ZtICp2bTsKPiAtCWludCByOwo+IC0KPiAtCWR3MCA9IGxlMzJfdG9fY3B1KGFkZXYtPmlycS5p
aC5yaW5nW3JpbmdfaW5kZXggKyAwXSk7Cj4gLQlkdzMgPSBsZTMyX3RvX2NwdShhZGV2LT5pcnEu
aWgucmluZ1tyaW5nX2luZGV4ICsgM10pOwo+IC0JZHc0ID0gbGUzMl90b19jcHUoYWRldi0+aXJx
LmloLnJpbmdbcmluZ19pbmRleCArIDRdKTsKPiAtCWR3NSA9IGxlMzJfdG9fY3B1KGFkZXYtPmly
cS5paC5yaW5nW3JpbmdfaW5kZXggKyA1XSk7Cj4gLQo+IC0JLyogRmlsdGVyIHJldHJ5IHBhZ2Ug
ZmF1bHRzLCBsZXQgb25seSB0aGUgZmlyc3Qgb25lIHBhc3MuIElmCj4gLQkgKiB0aGVyZSBhcmUg
dG9vIG1hbnkgb3V0c3RhbmRpbmcgZmF1bHRzLCBpZ25vcmUgdGhlbSB1bnRpbAo+IC0JICogc29t
ZSBmYXVsdHMgZ2V0IGNsZWFyZWQuCj4gLQkgKi8KPiAtCXN3aXRjaCAoZHcwICYgMHhmZikgewo+
IC0JY2FzZSBTT0MxNV9JSF9DTElFTlRJRF9WTUM6Cj4gLQljYXNlIFNPQzE1X0lIX0NMSUVOVElE
X1VUQ0wyOgo+IC0JCWJyZWFrOwo+IC0JZGVmYXVsdDoKPiAtCQkvKiBOb3QgYSBWTSBmYXVsdCAq
Lwo+IC0JCXJldHVybiB0cnVlOwo+IC0JfQo+IC0KPiAtCXBhc2lkID0gZHczICYgMHhmZmZmOwo+
IC0JLyogTm8gUEFTSUQsIGNhbid0IGlkZW50aWZ5IGZhdWx0aW5nIHByb2Nlc3MgKi8KPiAtCWlm
ICghcGFzaWQpCj4gLQkJcmV0dXJuIHRydWU7Cj4gLQo+IC0JLyogTm90IGEgcmV0cnkgZmF1bHQg
Ki8KPiAtCWlmICghKGR3NSAmIDB4ODApKQo+IC0JCXJldHVybiB0cnVlOwo+IC0KPiAtCS8qIFRy
YWNrIHJldHJ5IGZhdWx0cyBpbiBwZXItVk0gZmF1bHQgRklGTy4gKi8KPiAtCXNwaW5fbG9jaygm
YWRldi0+dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPiAtCXZtID0gaWRyX2ZpbmQoJmFkZXYtPnZt
X21hbmFnZXIucGFzaWRfaWRyLCBwYXNpZCk7Cj4gLQlhZGRyID0gKCh1NjQpKGR3NSAmIDB4Zikg
PDwgNDQpIHwgKCh1NjQpZHc0IDw8IDEyKTsKPiAtCWtleSA9IEFNREdQVV9WTV9GQVVMVChwYXNp
ZCwgYWRkcik7Cj4gLQlpZiAoIXZtKSB7Cj4gLQkJLyogVk0gbm90IGZvdW5kLCBwcm9jZXNzIGl0
IG5vcm1hbGx5ICovCj4gLQkJc3Bpbl91bmxvY2soJmFkZXYtPnZtX21hbmFnZXIucGFzaWRfbG9j
ayk7Cj4gLQkJcmV0dXJuIHRydWU7Cj4gLQl9IGVsc2Ugewo+IC0JCXIgPSBhbWRncHVfdm1fYWRk
X2ZhdWx0KHZtLT5mYXVsdF9oYXNoLCBrZXkpOwo+IC0KPiAtCQkvKiBIYXNoIHRhYmxlIGlzIGZ1
bGwgb3IgdGhlIGZhdWx0IGlzIGFscmVhZHkgYmVpbmcgcHJvY2Vzc2VkLAo+IC0JCSAqIGlnbm9y
ZSBmdXJ0aGVyIHBhZ2UgZmF1bHRzCj4gLQkJICovCj4gLQkJaWYgKHIgIT0gMCkgewo+IC0JCQlz
cGluX3VubG9jaygmYWRldi0+dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPiAtCQkJZ290byBpZ25v
cmVfaXY7Cj4gLQkJfQo+IC0JfQo+IC0JLyogTm8gbG9ja2luZyByZXF1aXJlZCB3aXRoIHNpbmds
ZSB3cml0ZXIgYW5kIHNpbmdsZSByZWFkZXIgKi8KPiAtCXIgPSBrZmlmb19wdXQoJnZtLT5mYXVs
dHMsIGtleSk7Cj4gLQlpZiAoIXIpIHsKPiAtCQkvKiBGSUZPIGlzIGZ1bGwuIElnbm9yZSBpdCB1
bnRpbCB0aGVyZSBpcyBzcGFjZSAqLwo+IC0JCWFtZGdwdV92bV9jbGVhcl9mYXVsdCh2bS0+ZmF1
bHRfaGFzaCwga2V5KTsKPiAtCQlzcGluX3VubG9jaygmYWRldi0+dm1fbWFuYWdlci5wYXNpZF9s
b2NrKTsKPiAtCQlnb3RvIGlnbm9yZV9pdjsKPiAtCX0KPiAtCj4gLQlzcGluX3VubG9jaygmYWRl
di0+dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPiAtCS8qIEl0J3MgdGhlIGZpcnN0IGZhdWx0IGZv
ciB0aGlzIGFkZHJlc3MsIHByb2Nlc3MgaXQgbm9ybWFsbHkgKi8KPiAgCXJldHVybiB0cnVlOwo+
IC0KPiAtaWdub3JlX2l2Ogo+IC0JYWRldi0+aXJxLmloLnJwdHIgKz0gMzI7Cj4gLQlyZXR1cm4g
ZmFsc2U7Cj4gIH0KPiAgCj4gIC8qKgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVz
a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9h
bWQtZ2Z4Cg==