From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: clean up memory/GDS/GWS/OA alignment code
Date: Mon, 28 Jan 2019 20:07:17 +0100
Message-ID: <de4a6cdc-bb4d-52d4-8c94-370642c1d5fe@gmail.com>
References: <20190122214532.1822-1-maraeo@gmail.com>
Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20190122214532.1822-1-maraeo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Content-Language: en-US
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= <maraeo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

QW0gMjIuMDEuMTkgdW0gMjI6NDUgc2NocmllYiBNYXJlayBPbMWhw6FrOgo+IEZyb206IE1hcmVr
IE9sxaHDoWsgPG1hcmVrLm9sc2FrQGFtZC5jb20+Cj4KPiAtIG1vdmUgYWxsIGFkanVzdG1lbnRz
IGludG8gb25lIHBsYWNlCj4gLSBzcGVjaWZ5IEdEUy9HV1MvT0EgYWxpZ25tZW50IGluIGJhc2lj
IHVuaXRzIG9mIHRoZSBoZWFwcwo+IC0gaXQgbG9va3MgbGlrZSBHRFMgYWxpZ25tZW50IHdhcyAx
IGluc3RlYWQgb2YgNAo+Cj4gU2lnbmVkLW9mZi1ieTogTWFyZWsgT2zFocOhayA8bWFyZWsub2xz
YWtAYW1kLmNvbT4KClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29l
bmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1
X2dlbS5jICAgIHwgIDcgLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k
Z3B1X29iamVjdC5jIHwgMTYgKysrKysrKysrKysrLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2Ft
ZC9hbWRncHUvYW1kZ3B1X3R0bS5jICAgIHwgIDYgKysrLS0tCj4gICAzIGZpbGVzIGNoYW5nZWQs
IDE1IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv
YW1kZ3B1L2FtZGdwdV9nZW0uYwo+IGluZGV4IGY0ZjAwMjE3NTQ2ZS4uZDIxZGQyZjM2OWRhIDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nZW0uYwo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nZW0uYwo+IEBAIC00NywyNCAr
NDcsMjAgQEAgaW50IGFtZGdwdV9nZW1fb2JqZWN0X2NyZWF0ZShzdHJ1Y3QgYW1kZ3B1X2Rldmlj
ZSAqYWRldiwgdW5zaWduZWQgbG9uZyBzaXplLAo+ICAgCQkJICAgICB1NjQgZmxhZ3MsIGVudW0g
dHRtX2JvX3R5cGUgdHlwZSwKPiAgIAkJCSAgICAgc3RydWN0IHJlc2VydmF0aW9uX29iamVjdCAq
cmVzdiwKPiAgIAkJCSAgICAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICoqb2JqKQo+ICAgewo+ICAg
CXN0cnVjdCBhbWRncHVfYm8gKmJvOwo+ICAgCXN0cnVjdCBhbWRncHVfYm9fcGFyYW0gYnA7Cj4g
ICAJaW50IHI7Cj4gICAKPiAgIAltZW1zZXQoJmJwLCAwLCBzaXplb2YoYnApKTsKPiAgIAkqb2Jq
ID0gTlVMTDsKPiAtCS8qIEF0IGxlYXN0IGFsaWduIG9uIHBhZ2Ugc2l6ZSAqLwo+IC0JaWYgKGFs
aWdubWVudCA8IFBBR0VfU0laRSkgewo+IC0JCWFsaWdubWVudCA9IFBBR0VfU0laRTsKPiAtCX0K
PiAgIAo+ICAgCWJwLnNpemUgPSBzaXplOwo+ICAgCWJwLmJ5dGVfYWxpZ24gPSBhbGlnbm1lbnQ7
Cj4gICAJYnAudHlwZSA9IHR5cGU7Cj4gICAJYnAucmVzdiA9IHJlc3Y7Cj4gICAJYnAucHJlZmVy
cmVkX2RvbWFpbiA9IGluaXRpYWxfZG9tYWluOwo+ICAgcmV0cnk6Cj4gICAJYnAuZmxhZ3MgPSBm
bGFnczsKPiAgIAlicC5kb21haW4gPSBpbml0aWFsX2RvbWFpbjsKPiAgIAlyID0gYW1kZ3B1X2Jv
X2NyZWF0ZShhZGV2LCAmYnAsICZibyk7Cj4gQEAgLTIzNywyMyArMjMzLDIwIEBAIGludCBhbWRn
cHVfZ2VtX2NyZWF0ZV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+
ICAgCWlmIChhcmdzLT5pbi5kb21haW5zICYgKEFNREdQVV9HRU1fRE9NQUlOX0dEUyB8Cj4gICAJ
ICAgIEFNREdQVV9HRU1fRE9NQUlOX0dXUyB8IEFNREdQVV9HRU1fRE9NQUlOX09BKSkgewo+ICAg
CQlpZiAoZmxhZ3MgJiBBTURHUFVfR0VNX0NSRUFURV9WTV9BTFdBWVNfVkFMSUQpIHsKPiAgIAkJ
CS8qIGlmIGdkcyBibyBpcyBjcmVhdGVkIGZyb20gdXNlciBzcGFjZSwgaXQgbXVzdCBiZQo+ICAg
CQkJICogcGFzc2VkIHRvIGJvIGxpc3QKPiAgIAkJCSAqLwo+ICAgCQkJRFJNX0VSUk9SKCJHRFMg
Ym8gY2Fubm90IGJlIHBlci12bS1ib1xuIik7Cj4gICAJCQlyZXR1cm4gLUVJTlZBTDsKPiAgIAkJ
fQo+ICAgCQlmbGFncyB8PSBBTURHUFVfR0VNX0NSRUFURV9OT19DUFVfQUNDRVNTOwo+IC0JCS8q
IEdEUyBhbGxvY2F0aW9ucyBtdXN0IGJlIERXIGFsaWduZWQgKi8KPiAtCQlpZiAoYXJncy0+aW4u
ZG9tYWlucyAmIEFNREdQVV9HRU1fRE9NQUlOX0dEUykKPiAtCQkJc2l6ZSA9IEFMSUdOKHNpemUs
IDQpOwo+ICAgCX0KPiAgIAo+ICAgCWlmIChmbGFncyAmIEFNREdQVV9HRU1fQ1JFQVRFX1ZNX0FM
V0FZU19WQUxJRCkgewo+ICAgCQlyID0gYW1kZ3B1X2JvX3Jlc2VydmUodm0tPnJvb3QuYmFzZS5i
bywgZmFsc2UpOwo+ICAgCQlpZiAocikKPiAgIAkJCXJldHVybiByOwo+ICAgCj4gICAJCXJlc3Yg
PSB2bS0+cm9vdC5iYXNlLmJvLT50Ym8ucmVzdjsKPiAgIAl9Cj4gICAKPiBkaWZmIC0tZ2l0IGEv
ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jIGIvZHJpdmVycy9ncHUv
ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jCj4gaW5kZXggNzI4ZTE1ZTVkNjhhLi5mZDlj
NGJlZWFhYTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1
X29iamVjdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVj
dC5jCj4gQEAgLTQxOSwyNiArNDE5LDM0IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2JvX2RvX2NyZWF0
ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgIAkJLmludGVycnVwdGlibGUgPSAoYnAt
PnR5cGUgIT0gdHRtX2JvX3R5cGVfa2VybmVsKSwKPiAgIAkJLm5vX3dhaXRfZ3B1ID0gZmFsc2Us
Cj4gICAJCS5yZXN2ID0gYnAtPnJlc3YsCj4gICAJCS5mbGFncyA9IFRUTV9PUFRfRkxBR19BTExP
V19SRVNfRVZJQ1QKPiAgIAl9Owo+ICAgCXN0cnVjdCBhbWRncHVfYm8gKmJvOwo+ICAgCXVuc2ln
bmVkIGxvbmcgcGFnZV9hbGlnbiwgc2l6ZSA9IGJwLT5zaXplOwo+ICAgCXNpemVfdCBhY2Nfc2l6
ZTsKPiAgIAlpbnQgcjsKPiAgIAo+IC0JcGFnZV9hbGlnbiA9IHJvdW5kdXAoYnAtPmJ5dGVfYWxp
Z24sIFBBR0VfU0laRSkgPj4gUEFHRV9TSElGVDsKPiAtCWlmIChicC0+ZG9tYWluICYgKEFNREdQ
VV9HRU1fRE9NQUlOX0dEUyB8IEFNREdQVV9HRU1fRE9NQUlOX0dXUyB8Cj4gLQkJCSAgQU1ER1BV
X0dFTV9ET01BSU5fT0EpKQo+ICsJLyogTm90ZSB0aGF0IEdEUy9HV1MvT0EgYWxsb2NhdGVzIDEg
cGFnZSBwZXIgYnl0ZS9yZXNvdXJjZS4gKi8KPiArCWlmIChicC0+ZG9tYWluICYgKEFNREdQVV9H
RU1fRE9NQUlOX0dXUyB8IEFNREdQVV9HRU1fRE9NQUlOX09BKSkgewo+ICsJCS8qIEdXUyBhbmQg
T0EgZG9uJ3QgbmVlZCBhbnkgYWxpZ25tZW50LiAqLwo+ICsJCXBhZ2VfYWxpZ24gPSBicC0+Ynl0
ZV9hbGlnbjsKPiAgIAkJc2l6ZSA8PD0gUEFHRV9TSElGVDsKPiAtCWVsc2UKPiArCX0gZWxzZSBp
ZiAoYnAtPmRvbWFpbiAmIEFNREdQVV9HRU1fRE9NQUlOX0dEUykgewo+ICsJCS8qIEJvdGggc2l6
ZSBhbmQgYWxpZ25tZW50IG11c3QgYmUgYSBtdWx0aXBsZSBvZiA0LiAqLwo+ICsJCXBhZ2VfYWxp
Z24gPSBBTElHTihicC0+Ynl0ZV9hbGlnbiwgNCk7Cj4gKwkJc2l6ZSA9IEFMSUdOKHNpemUsIDQp
IDw8IFBBR0VfU0hJRlQ7Cj4gKwl9IGVsc2Ugewo+ICsJCS8qIE1lbW9yeSBzaG91bGQgYmUgYWxp
Z25lZCBhdCBsZWFzdCB0byBhIHBhZ2Ugc2l6ZS4gKi8KPiArCQlwYWdlX2FsaWduID0gQUxJR04o
YnAtPmJ5dGVfYWxpZ24sIFBBR0VfU0laRSkgPj4gUEFHRV9TSElGVDsKPiAgIAkJc2l6ZSA9IEFM
SUdOKHNpemUsIFBBR0VfU0laRSk7Cj4gKwl9Cj4gICAKPiAgIAlpZiAoIWFtZGdwdV9ib192YWxp
ZGF0ZV9zaXplKGFkZXYsIHNpemUsIGJwLT5kb21haW4pKQo+ICAgCQlyZXR1cm4gLUVOT01FTTsK
PiAgIAo+ICAgCSpib19wdHIgPSBOVUxMOwo+ICAgCj4gICAJYWNjX3NpemUgPSB0dG1fYm9fZG1h
X2FjY19zaXplKCZhZGV2LT5tbWFuLmJkZXYsIHNpemUsCj4gICAJCQkJICAgICAgIHNpemVvZihz
dHJ1Y3QgYW1kZ3B1X2JvKSk7Cj4gICAKPiAgIAlibyA9IGt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBh
bWRncHVfYm8pLCBHRlBfS0VSTkVMKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ft
ZC9hbWRncHUvYW1kZ3B1X3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1
X3R0bS5jCj4gaW5kZXggYjg1MmFiYjlkYjBmLi43M2U3MWU2MWRjOTkgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4gQEAgLTE3NDksNDcgKzE3NDksNDcgQEAg
aW50IGFtZGdwdV90dG1faW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAo+ICAg
CS8qIEluaXRpYWxpemUgdmFyaW91cyBvbi1jaGlwIG1lbW9yeSBwb29scyAqLwo+ICAgCXIgPSB0
dG1fYm9faW5pdF9tbSgmYWRldi0+bW1hbi5iZGV2LCBBTURHUFVfUExfR0RTLAo+ICAgCQkJICAg
YWRldi0+Z2RzLm1lbS50b3RhbF9zaXplKTsKPiAgIAlpZiAocikgewo+ICAgCQlEUk1fRVJST1Io
IkZhaWxlZCBpbml0aWFsaXppbmcgR0RTIGhlYXAuXG4iKTsKPiAgIAkJcmV0dXJuIHI7Cj4gICAJ
fQo+ICAgCj4gICAJciA9IGFtZGdwdV9ib19jcmVhdGVfa2VybmVsKGFkZXYsIGFkZXYtPmdkcy5t
ZW0uZ2Z4X3BhcnRpdGlvbl9zaXplLAo+IC0JCQkJICAgIFBBR0VfU0laRSwgQU1ER1BVX0dFTV9E
T01BSU5fR0RTLAo+ICsJCQkJICAgIDQsIEFNREdQVV9HRU1fRE9NQUlOX0dEUywKPiAgIAkJCQkg
ICAgJmFkZXYtPmdkcy5nZHNfZ2Z4X2JvLCBOVUxMLCBOVUxMKTsKPiAgIAlpZiAocikKPiAgIAkJ
cmV0dXJuIHI7Cj4gICAKPiAgIAlyID0gdHRtX2JvX2luaXRfbW0oJmFkZXYtPm1tYW4uYmRldiwg
QU1ER1BVX1BMX0dXUywKPiAgIAkJCSAgIGFkZXYtPmdkcy5nd3MudG90YWxfc2l6ZSk7Cj4gICAJ
aWYgKHIpIHsKPiAgIAkJRFJNX0VSUk9SKCJGYWlsZWQgaW5pdGlhbGl6aW5nIGd3cyBoZWFwLlxu
Iik7Cj4gICAJCXJldHVybiByOwo+ICAgCX0KPiAgIAo+ICAgCXIgPSBhbWRncHVfYm9fY3JlYXRl
X2tlcm5lbChhZGV2LCBhZGV2LT5nZHMuZ3dzLmdmeF9wYXJ0aXRpb25fc2l6ZSwKPiAtCQkJCSAg
ICBQQUdFX1NJWkUsIEFNREdQVV9HRU1fRE9NQUlOX0dXUywKPiArCQkJCSAgICAxLCBBTURHUFVf
R0VNX0RPTUFJTl9HV1MsCj4gICAJCQkJICAgICZhZGV2LT5nZHMuZ3dzX2dmeF9ibywgTlVMTCwg
TlVMTCk7Cj4gICAJaWYgKHIpCj4gICAJCXJldHVybiByOwo+ICAgCj4gICAJciA9IHR0bV9ib19p
bml0X21tKCZhZGV2LT5tbWFuLmJkZXYsIEFNREdQVV9QTF9PQSwKPiAgIAkJCSAgIGFkZXYtPmdk
cy5vYS50b3RhbF9zaXplKTsKPiAgIAlpZiAocikgewo+ICAgCQlEUk1fRVJST1IoIkZhaWxlZCBp
bml0aWFsaXppbmcgb2EgaGVhcC5cbiIpOwo+ICAgCQlyZXR1cm4gcjsKPiAgIAl9Cj4gICAKPiAg
IAlyID0gYW1kZ3B1X2JvX2NyZWF0ZV9rZXJuZWwoYWRldiwgYWRldi0+Z2RzLm9hLmdmeF9wYXJ0
aXRpb25fc2l6ZSwKPiAtCQkJCSAgICBQQUdFX1NJWkUsIEFNREdQVV9HRU1fRE9NQUlOX09BLAo+
ICsJCQkJICAgIDEsIEFNREdQVV9HRU1fRE9NQUlOX09BLAo+ICAgCQkJCSAgICAmYWRldi0+Z2Rz
Lm9hX2dmeF9ibywgTlVMTCwgTlVMTCk7Cj4gICAJaWYgKHIpCj4gICAJCXJldHVybiByOwo+ICAg
Cj4gICAJLyogUmVnaXN0ZXIgZGVidWdmcyBlbnRyaWVzIGZvciBhbWRncHVfdHRtICovCj4gICAJ
ciA9IGFtZGdwdV90dG1fZGVidWdmc19pbml0KGFkZXYpOwo+ICAgCWlmIChyKSB7Cj4gICAJCURS
TV9FUlJPUigiRmFpbGVkIHRvIGluaXQgZGVidWdmc1xuIik7Cj4gICAJCXJldHVybiByOwo+ICAg
CX0KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1n
ZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=