From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Guchun Chen <guchun.chen@amd.com>,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
hawking.zhang@amd.com, le.ma@amd.com
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm/amdgpu: fix a build warning by a typo in amdgpu_gfx.c
Date: Wed, 26 Apr 2023 13:45:51 +0200 [thread overview]
Message-ID: <de89cc6f-5e95-59cd-df98-19fd000f2263@gmail.com> (raw)
In-Reply-To: <20230426031130.147291-1-guchun.chen@amd.com>
Am 26.04.23 um 05:11 schrieb Guchun Chen:
> This should be a typo when intruducing multi-xx support.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> Cc: Le Ma <le.ma@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 60bb4bba1994..2cf1f88fde48 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -470,8 +470,8 @@ void amdgpu_gfx_mqd_sw_fini(struct amdgpu_device *adev, int xcc_id)
>
> for (i = 0; i < adev->gfx.num_compute_rings; i++) {
> j = i + xcc_id * adev->gfx.num_compute_rings;
> - ring = &adev->gfx.compute_ring[i];
> - kfree(adev->gfx.mec.mqd_backup[i]);
> + ring = &adev->gfx.compute_ring[j];
> + kfree(adev->gfx.mec.mqd_backup[j]);
> amdgpu_bo_free_kernel(&ring->mqd_obj,
> &ring->mqd_gpu_addr,
> &ring->mqd_ptr);
prev parent reply other threads:[~2023-04-26 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 3:11 [PATCH] drm/amdgpu: fix a build warning by a typo in amdgpu_gfx.c Guchun Chen
2023-04-26 5:55 ` Ma, Le
2023-04-26 11:45 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de89cc6f-5e95-59cd-df98-19fd000f2263@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=guchun.chen@amd.com \
--cc=hawking.zhang@amd.com \
--cc=le.ma@amd.com \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox