AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Asad Kamal <asad.kamal@amd.com>, amd-gfx@lists.freedesktop.org
Cc: hawking.zhang@amd.com, le.ma@amd.com, shiwu.zhang@amd.com,
	alexander.deucher@amd.com, KevinYang.Wang@amd.com
Subject: Re: [PATCH v2 4/4] drm/amd/pm: Enable system power caps for smu_v13_0_12
Date: Thu, 13 Nov 2025 12:02:04 +0530	[thread overview]
Message-ID: <df2df2d8-908d-4f31-bbb7-d69b87ac1f97@amd.com> (raw)
In-Reply-To: <20251112152815.203110-4-asad.kamal@amd.com>



On 11/12/2025 8:58 PM, Asad Kamal wrote:
> Enable system power caps to fetch system power and threshold for
> smu_v13_0_12
> 
> Signed-off-by: Asad Kamal <asad.kamal@amd.com>

Please update the unit in documentation before submitting.

With that, series is -

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 2fefd258bc0e..a3ceecbe5d68 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -356,8 +356,11 @@ static void smu_v13_0_12_init_caps(struct smu_context *smu)
>   	if (fw_ver > 0x04560900)
>   		smu_v13_0_6_cap_set(smu, SMU_CAP(VCN_RESET));
>   
> -	if (fw_ver >= 0x04560D00)
> +	if (fw_ver >= 0x04560D00) {
>   		smu_v13_0_6_cap_set(smu, SMU_CAP(FAST_PPT));
> +		if (smu->adev->gmc.xgmi.physical_node_id == 0)
> +			smu_v13_0_6_cap_set(smu, SMU_CAP(SYSTEM_POWER_METRICS));
> +	}
>   
>   	if (fw_ver >= 0x04560700) {
>   		if (fw_ver >= 0x04560900) {


      reply	other threads:[~2025-11-13  6:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 15:28 [PATCH v2 1/4] drm/amd/pm: Update pmfw headers for smu_v13_0_12 Asad Kamal
2025-11-12 15:28 ` [PATCH v2 2/4] drm/amd/pm: Add sysfs node for ubb power Asad Kamal
2025-11-13  6:30   ` Lazar, Lijo
2025-11-12 15:28 ` [PATCH v2 3/4] drm/amd/pm: Fetch ubb power for smu_v13_0_12 Asad Kamal
2025-11-12 15:28 ` [PATCH v2 4/4] drm/amd/pm: Enable system power caps " Asad Kamal
2025-11-13  6:32   ` Lazar, Lijo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df2df2d8-908d-4f31-bbb7-d69b87ac1f97@amd.com \
    --to=lijo.lazar@amd.com \
    --cc=KevinYang.Wang@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=asad.kamal@amd.com \
    --cc=hawking.zhang@amd.com \
    --cc=le.ma@amd.com \
    --cc=shiwu.zhang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox