From: "Arnd Bergmann" <arnd@kernel.org>
To: "Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info
Date: Tue, 26 Sep 2023 19:48:52 +0200 [thread overview]
Message-ID: <df3b7de0-972d-4df4-a52e-828015f062f6@app.fastmail.com> (raw)
In-Reply-To: <20230926163938.1013775-2-alexander.deucher@amd.com>
On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote:
> I think this was an abstraction back from when
> kfd supported both radeon and amdgpu. Since we just
> support amdgpu now, there is no more need for this and
> we can use the amdgpu structures directly.
>
> This also avoids having the kfd_cu_info structures on
> the stack when inlining which can blow up the stack.
>
> Cc: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Nice cleanup!
Acked-by: Arnd Bergmann <arnd@arndb.de>
I guess you could fold patch 1/2 into this as it removes
all the added code from that anyway.
next prev parent reply other threads:[~2023-09-26 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 16:39 [PATCH 1/2] drm/amdkfd: reduce stack size in kfd_topology_add_device() Alex Deucher
2023-09-26 16:39 ` [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info Alex Deucher
2023-09-26 17:48 ` Arnd Bergmann [this message]
2023-09-26 18:47 ` Deucher, Alexander
2023-09-26 19:29 ` Arnd Bergmann
2023-09-27 16:39 ` Felix Kuehling
2023-09-27 16:49 ` Felix Kuehling
2023-09-26 17:38 ` [PATCH 1/2] drm/amdkfd: reduce stack size in kfd_topology_add_device() Arnd Bergmann
2023-09-27 5:31 ` Christian König
2023-09-27 16:40 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df3b7de0-972d-4df4-a52e-828015f062f6@app.fastmail.com \
--to=arnd@kernel.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox