From: Ao Zhong <hacc1225@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>,
"Arnd Bergmann" <arnd@arndb.de>, "Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
amd-gfx@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/1] drm/amd/display: add DCN support for ARM64
Date: Fri, 28 Oct 2022 17:28:03 +0200 [thread overview]
Message-ID: <dfc62a96-1953-27a3-3f8a-b7bab03f69aa@gmail.com> (raw)
In-Reply-To: <Y1vwk3J3HPGugBJO@dev-arch.thelio-3990X>
Am 28.10.22 um 17:09 schrieb Nathan Chancellor:
> Additionally, I see the following errors with GCC 12.2.1 from Fedora
> when building allmodconfig. Seems like some $(dml_rcflags) might be
> missing.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c: In function ‘dcn10_resource_construct_fp’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1313:52: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1313 | dcn_soc->dram_clock_change_latency = 23;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1317:45: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1317 | dc->dcn_soc->urgent_latency = 3;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1319:64: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1319 | dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 = 41.60f;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1329:64: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1329 | dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 = 19.2f;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1330:64: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1330 | dc->dcn_soc->fabric_and_dram_bandwidth_vnom0p8 = 17.066f;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1331:65: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1331 | dc->dcn_soc->fabric_and_dram_bandwidth_vmid0p72 = 14.933f;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1332:65: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1332 | dc->dcn_soc->fabric_and_dram_bandwidth_vmin0p65 = 12.8f;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1334:72: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1334 | dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 = 20.80f;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
> make[6]: *** [scripts/Makefile.build:250: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.o] Error 1
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c: In function ‘dcn32_populate_dml_pipes_from_context’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1921:70: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1921 | pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_luma = 0;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1922:72: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types
> 1922 | pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_chroma = 0;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> make[6]: *** [scripts/Makefile.build:250: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.o] Error 1
Hi Nathan,
it seems like you haven't merged my patch to isolate the remaining FPU code.
Links: https://patchwork.freedesktop.org/patch/508813/
Links: https://patchwork.freedesktop.org/patch/508816/
Rodrigo says both patches have been applied, but I haven't seen them in the amd-staging-drm-next branch.
This error occurs because the remaining FPU code in dcn10_resource.c has not been isolated.
Ao
next prev parent reply other threads:[~2022-10-31 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 19:52 [PATCH v3 0/1] drm/amd/display: add DCN support for ARM64 Ao Zhong
2022-10-27 19:52 ` [PATCH v3 1/1] " Ao Zhong
2022-10-27 20:46 ` Arnd Bergmann
2022-10-28 15:09 ` Nathan Chancellor
2022-10-28 15:26 ` Ao Zhong
2022-10-28 15:28 ` Ao Zhong [this message]
2022-10-28 15:35 ` Rodrigo Siqueira Jordao
2022-10-28 15:48 ` Nathan Chancellor
2022-10-31 18:47 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfc62a96-1953-27a3-3f8a-b7bab03f69aa@gmail.com \
--to=hacc1225@gmail.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=harry.wentland@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nathan@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox