From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C827CDE00C for ; Fri, 26 Jun 2026 11:41:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C6D5610F56B; Fri, 26 Jun 2026 11:41:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="EGH7Nym7"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="92EogYhD"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="EGH7Nym7"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="92EogYhD"; dkim-atps=neutral Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9215110F572 for ; Fri, 26 Jun 2026 11:41:38 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C8EB759F7; Fri, 26 Jun 2026 11:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782474097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/t1+bdLKNhcqmjr79k8QzZS+syMv9xthRahPAS5L7pw=; b=EGH7Nym7W2rYb+txOBUyeqkZKVnUzWn+i/CLCvo/Xtl03sXmzZ3Qxx4CPx/tdqjsenPXjZ cTetVvfgqOmjN2kgvMYtURkUjA0GZyAzO16bzFUUGOveFUQSmjtL2tuED9s0WtLzUn8d2a 9PHYak27GiAG0l2l1dhVp/ktwRT/sNI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782474097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/t1+bdLKNhcqmjr79k8QzZS+syMv9xthRahPAS5L7pw=; b=92EogYhDqdOWUnf1GEUiS2RqbHBfaacv6q6jgpF35C/+lC1CbFAv7D89iG6BpuDk4s1JTp yCZI2AzTKu4VmpDw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EGH7Nym7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=92EogYhD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782474097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/t1+bdLKNhcqmjr79k8QzZS+syMv9xthRahPAS5L7pw=; b=EGH7Nym7W2rYb+txOBUyeqkZKVnUzWn+i/CLCvo/Xtl03sXmzZ3Qxx4CPx/tdqjsenPXjZ cTetVvfgqOmjN2kgvMYtURkUjA0GZyAzO16bzFUUGOveFUQSmjtL2tuED9s0WtLzUn8d2a 9PHYak27GiAG0l2l1dhVp/ktwRT/sNI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782474097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/t1+bdLKNhcqmjr79k8QzZS+syMv9xthRahPAS5L7pw=; b=92EogYhDqdOWUnf1GEUiS2RqbHBfaacv6q6jgpF35C/+lC1CbFAv7D89iG6BpuDk4s1JTp yCZI2AzTKu4VmpDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BE565779A8; Fri, 26 Jun 2026 11:41:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iUpOLXBlPmr6QgAAD6G6ig (envelope-from ); Fri, 26 Jun 2026 11:41:36 +0000 Message-ID: Date: Fri, 26 Jun 2026 13:41:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 01/10] Revert "backlight: Remove notifier" To: Mario Limonciello , dri-devel@lists.freedesktop.org, harry.wentland@amd.com, Simona Vetter , Alex Deucher , Maarten Lankhorst , Maxime Ripard , David Airlie Cc: Xaver Hugl , amd-gfx@lists.freedesktop.org, "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS" , "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS" , "Mario Limonciello (AMD)" , Simon Ser References: <20260624165751.2014759-1-mario.limonciello@amd.com> <20260624165751.2014759-2-mario.limonciello@amd.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260624165751.2014759-2-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[amd.com,lists.freedesktop.org,ffwll.ch,linux.intel.com,kernel.org,gmail.com]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWELVE(0.00)[14]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[gmail.com,lists.freedesktop.org,kernel.org,emersion.fr]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:email, suse.de:dkim, suse.de:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 1C8EB759F7 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Am 24.06.26 um 18:57 schrieb Mario Limonciello: > From: "Mario Limonciello (AMD)" > > This reverts commit 5461f3fd74a89757f95f351eb0bc26aafc2a2e91. > The backlight notifier support is needed in order to add backlight > control support into DRM connectors. > > Signed-off-by: Mario Limonciello (AMD) > Tested-by: Simon Ser I don't like this, but I don't have a better idea for now. Therefore Reviewed-by: Thomas Zimmermann until a better idea shows up. > --- > drivers/video/backlight/backlight.c | 42 +++++++++++++++++++++++++++++ > include/linux/backlight.h | 20 ++++++++++++++ > 2 files changed, 62 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index a22d0bbb6e639..ff2c2084c73a4 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -65,6 +65,7 @@ > > static struct list_head backlight_dev_list; > static struct mutex backlight_dev_list_mutex; > +static struct blocking_notifier_head backlight_notifier; > > static const char *const backlight_types[] = { > [BACKLIGHT_RAW] = "raw", > @@ -415,6 +416,9 @@ struct backlight_device *backlight_device_register(const char *name, > list_add(&new_bd->entry, &backlight_dev_list); > mutex_unlock(&backlight_dev_list_mutex); > > + blocking_notifier_call_chain(&backlight_notifier, > + BACKLIGHT_REGISTERED, new_bd); > + > return new_bd; > } > EXPORT_SYMBOL(backlight_device_register); > @@ -484,6 +488,9 @@ void backlight_device_unregister(struct backlight_device *bd) > mutex_unlock(&pmac_backlight_mutex); > #endif > > + blocking_notifier_call_chain(&backlight_notifier, > + BACKLIGHT_UNREGISTERED, bd); > + > mutex_lock(&bd->ops_lock); > bd->ops = NULL; > mutex_unlock(&bd->ops_lock); > @@ -507,6 +514,40 @@ static int devm_backlight_device_match(struct device *dev, void *res, > return *r == data; > } > > +/** > + * backlight_register_notifier - get notified of backlight (un)registration > + * @nb: notifier block with the notifier to call on backlight (un)registration > + * > + * Register a notifier to get notified when backlight devices get registered > + * or unregistered. > + * > + * RETURNS: > + * > + * 0 on success, otherwise a negative error code > + */ > +int backlight_register_notifier(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_register(&backlight_notifier, nb); > +} > +EXPORT_SYMBOL(backlight_register_notifier); > + > +/** > + * backlight_unregister_notifier - unregister a backlight notifier > + * @nb: notifier block to unregister > + * > + * Register a notifier to get notified when backlight devices get registered > + * or unregistered. > + * > + * RETURNS: > + * > + * 0 on success, otherwise a negative error code > + */ > +int backlight_unregister_notifier(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_unregister(&backlight_notifier, nb); > +} > +EXPORT_SYMBOL(backlight_unregister_notifier); > + > /** > * devm_backlight_device_register - register a new backlight device > * @dev: the device to register > @@ -674,6 +715,7 @@ static int __init backlight_class_init(void) > > INIT_LIST_HEAD(&backlight_dev_list); > mutex_init(&backlight_dev_list_mutex); > + BLOCKING_INIT_NOTIFIER_HEAD(&backlight_notifier); > > return 0; > } > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index f29a9ef1052e7..d905173c7f73c 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -64,6 +64,24 @@ enum backlight_type { > BACKLIGHT_TYPE_MAX, > }; > > +/** > + * enum backlight_notification - the type of notification > + * > + * The notifications that is used for notification sent to the receiver > + * that registered notifications using backlight_register_notifier(). > + */ > +enum backlight_notification { > + /** > + * @BACKLIGHT_REGISTERED: The backlight device is registered. > + */ > + BACKLIGHT_REGISTERED, > + > + /** > + * @BACKLIGHT_UNREGISTERED: The backlight revice is unregistered. > + */ > + BACKLIGHT_UNREGISTERED, > +}; > + > /** enum backlight_scale - the type of scale used for brightness values > * > * The type of scale used for brightness values. > @@ -388,6 +406,8 @@ void devm_backlight_device_unregister(struct device *dev, > struct backlight_device *bd); > void backlight_force_update(struct backlight_device *bd, > enum backlight_update_reason reason); > +int backlight_register_notifier(struct notifier_block *nb); > +int backlight_unregister_notifier(struct notifier_block *nb); > struct backlight_device *backlight_device_get_by_name(const char *name); > struct backlight_device *backlight_device_get_by_type(enum backlight_type type); > int backlight_device_set_brightness(struct backlight_device *bd, -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)