From: James Zhu <jamesz@amd.com>
To: Leo Liu <leo.liu@amd.com>, amd-gfx@lists.freedesktop.org
Cc: James.Zhu@amd.com, richardqi.liang@amd.com
Subject: Re: [PATCH] drm/amdgpu: enable Vangogh VCN indirect sram mode
Date: Tue, 29 Nov 2022 19:07:36 -0500 [thread overview]
Message-ID: <e1c1341a-c655-b0ab-dc95-2a07f10e2ba3@amd.com> (raw)
In-Reply-To: <20221130000251.6824-1-leo.liu@amd.com>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
ThispatchisReviewed-by:JamesZhu<James.Zhu@amd.com>
On 2022-11-29 19:02, Leo Liu wrote:
> So that uses PSP to initialize HW.
>
> Fixes: 0c2c02b6 (drm/amdgpu/vcn: add firmware support for dimgrey_cavefish)
>
> Signed-off-by: Leo Liu<leo.liu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> index c448c1bdf84d..72fa14ff862f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> @@ -156,6 +156,9 @@ int amdgpu_vcn_sw_init(struct amdgpu_device *adev)
> break;
> case IP_VERSION(3, 0, 2):
> fw_name = FIRMWARE_VANGOGH;
> + if ((adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) &&
> + (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG))
> + adev->vcn.indirect_sram = true;
> break;
> case IP_VERSION(3, 0, 16):
> fw_name = FIRMWARE_DIMGREY_CAVEFISH;
[-- Attachment #2: Type: text/html, Size: 1845 bytes --]
prev parent reply other threads:[~2022-11-30 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 0:02 [PATCH] drm/amdgpu: enable Vangogh VCN indirect sram mode Leo Liu
2022-11-30 0:07 ` James Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c1341a-c655-b0ab-dc95-2a07f10e2ba3@amd.com \
--to=jamesz@amd.com \
--cc=James.Zhu@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=leo.liu@amd.com \
--cc=richardqi.liang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox