From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: band aid validating VM PTs
Date: Wed, 20 Jun 2018 16:45:44 +0200 [thread overview]
Message-ID: <e2bbcdbe-d35a-490f-2e15-1a9096add20d@gmail.com> (raw)
In-Reply-To: <20180620112459.GA7166@hr-amur2>
Am 20.06.2018 um 13:25 schrieb Huang Rui:
> On Tue, Jun 19, 2018 at 02:57:00PM +0200, Christian König wrote:
>> Always validating the VM PTs takes to much time. Only always validate
>> the per VM BOs for now.
> Christian, you delete PTE BO instead of moving them into idle list. The
> intention is to avoid them do evction back when do vm_validate_pt_bos,
> right?
No, the intention is to avoid the extra command submission overhead with
moving them on the LRU.
This messes the LRU for VMs up a bit, but that shouldn't matter much
because when we need to evict PTs the performance is not relevant
anymore anyway.
Christian.
>
> But in that function, I just see that it will walk over the idle list and
> move the bo into lru list, and didn't find the evction behaviour called
> explicitly. So why will it save the performance cost?
>
> Thanks,
> Ray
>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index 819949418495..7c30451ba897 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -1082,7 +1082,7 @@ int amdgpu_vm_update_directories(struct amdgpu_device *adev,
>> struct amdgpu_vm_bo_base,
>> vm_status);
>> bo_base->moved = false;
>> - list_move(&bo_base->vm_status, &vm->idle);
>> + list_del_init(&bo_base->vm_status);
>>
>> bo = bo_base->bo->parent;
>> if (!bo)
>> --
>> 2.14.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-06-20 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 12:57 [PATCH] drm/amdgpu: band aid validating VM PTs Christian König
[not found] ` <20180619125700.55218-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-06-20 11:25 ` Huang Rui
2018-06-20 14:45 ` Christian König [this message]
[not found] ` <e2bbcdbe-d35a-490f-2e15-1a9096add20d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-06-21 13:15 ` Huang Rui
2018-06-21 14:57 ` Christian König
2018-06-22 0:52 ` Zhang, Jerry (Junwei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2bbcdbe-d35a-490f-2e15-1a9096add20d@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=ray.huang-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox