Re: [PATCH] drm/amdkfd: Remove unused variable

[Felix Kuehling <felix.kuehling@amd.com>]

On 2022-10-27 04:14, Ma Jun wrote:
> The kfd_topology_device->cache_count is not used by
> other fucntions, so remove it.
>
> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_crat.c     | 1 -
>   drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 8b7e34b45740..72fbbd342c10 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1029,7 +1029,6 @@ static int kfd_parse_subtype_cache(struct crat_subtype_cache *cache,
>   			if (cache->flags & CRAT_CACHE_FLAGS_SIMD_CACHE)
>   				props->cache_type |= HSA_CACHE_TYPE_HSACU;
>   
> -			dev->cache_count++;
>   			dev->node_props.caches_count++;
>   			list_add_tail(&props->list, &dev->cache_props);
>   
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> index 3e8ac87f0ac9..912a5e6a24ad 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> @@ -140,7 +140,6 @@ struct kfd_topology_device {
>   	uint32_t			proximity_domain;
>   	struct kfd_node_properties	node_props;
>   	struct list_head		mem_props;
> -	uint32_t			cache_count;
>   	struct list_head		cache_props;
>   	struct list_head		io_link_props;
>   	struct list_head		p2p_link_props;