AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Liu <leo.liu@amd.com>
To: Monk Liu <Monk.Liu@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [enable VCN2.0 for NV12 SRIOV 4/6] drm/amdgpu: cleanup ring/ib test for SRIOV vcn2.0
Date: Thu, 5 Mar 2020 11:10:34 -0500	[thread overview]
Message-ID: <e42ebba7-b830-4b07-32f9-32b8180b484e@amd.com> (raw)
In-Reply-To: <1583415187-16594-4-git-send-email-Monk.Liu@amd.com>

This patch is:

Reviewed-by: Leo Liu <leo.liu@amd.com>

On 2020-03-05 8:33 a.m., Monk Liu wrote:
> support IB test on dec/enc ring
> disable ring test on dec/enc ring (MMSCH limitation)
>
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 11 +++--------
>   drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c   |  3 +++
>   2 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> index f96464e..ae9754f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> @@ -497,10 +497,6 @@ int amdgpu_vcn_dec_ring_test_ib(struct amdgpu_ring *ring, long timeout)
>   	struct dma_fence *fence;
>   	long r;
>   
> -	/* temporarily disable ib test for sriov */
> -	if (amdgpu_sriov_vf(adev))
> -		return 0;
> -
>   	r = amdgpu_vcn_dec_get_create_msg(ring, 1, NULL);
>   	if (r)
>   		goto error;
> @@ -527,6 +523,9 @@ int amdgpu_vcn_enc_ring_test_ring(struct amdgpu_ring *ring)
>   	unsigned i;
>   	int r;
>   
> +	if (amdgpu_sriov_vf(adev))
> +		return 0;
> +
>   	r = amdgpu_ring_alloc(ring, 16);
>   	if (r)
>   		return r;
> @@ -661,10 +660,6 @@ int amdgpu_vcn_enc_ring_test_ib(struct amdgpu_ring *ring, long timeout)
>   	struct amdgpu_bo *bo = NULL;
>   	long r;
>   
> -	/* temporarily disable ib test for sriov */
> -	if (amdgpu_sriov_vf(adev))
> -		return 0;
> -
>   	r = amdgpu_bo_create_reserved(ring->adev, 128 * 1024, PAGE_SIZE,
>   				      AMDGPU_GEM_DOMAIN_VRAM,
>   				      &bo, NULL, NULL);
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
> index 421e5bf..dd500d1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
> @@ -1647,6 +1647,9 @@ int vcn_v2_0_dec_ring_test_ring(struct amdgpu_ring *ring)
>   	unsigned i;
>   	int r;
>   
> +	if (amdgpu_sriov_vf(adev))
> +		return 0;
> +
>   	WREG32(adev->vcn.inst[ring->me].external.scratch9, 0xCAFEDEAD);
>   	r = amdgpu_ring_alloc(ring, 4);
>   	if (r)
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-03-05 16:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 13:33 [enable VCN2.0 for NV12 SRIOV 1/6] drm/amdgpu: introduce mmsch v2.0 header Monk Liu
2020-03-05 13:33 ` [enable VCN2.0 for NV12 SRIOV 2/6] drm/amdgpu: disable jpeg block for SRIOV Monk Liu
2020-03-05 13:37   ` Christian König
2020-03-05 13:39     ` Liu, Monk
2020-03-05 16:01       ` Leo Liu
2020-03-05 13:33 ` [enable VCN2.0 for NV12 SRIOV 3/6] drm/amdgpu: implement initialization part on VCN2.0 " Monk Liu
2020-03-05 16:07   ` Leo Liu
2020-03-06  2:43     ` Liu, Monk
2020-03-05 13:33 ` [enable VCN2.0 for NV12 SRIOV 4/6] drm/amdgpu: cleanup ring/ib test for SRIOV vcn2.0 Monk Liu
2020-03-05 16:10   ` Leo Liu [this message]
2020-03-05 13:33 ` [enable VCN2.0 for NV12 SRIOV 5/6] drm/amdgpu: disable clock/power gating for SRIOV Monk Liu
2020-03-05 16:11   ` Leo Liu
2020-03-05 13:33 ` [enable VCN2.0 for NV12 SRIOV 6/6] drm/amdgpu: clear warning on unused var Monk Liu
2020-03-05 13:37   ` Christian König
2020-03-06  3:31     ` Deng, Emily
2020-03-05 16:16   ` Leo Liu
2020-03-06  2:43     ` Liu, Monk
2020-03-05 15:59 ` [enable VCN2.0 for NV12 SRIOV 1/6] drm/amdgpu: introduce mmsch v2.0 header Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e42ebba7-b830-4b07-32f9-32b8180b484e@amd.com \
    --to=leo.liu@amd.com \
    --cc=Monk.Liu@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox