From: "Tuikov, Luben" <Luben.Tuikov-5C7GfCeVMHo@public.gmane.org>
To: "Yin, Tianci (Rico)" <Tianci.Yin-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Deucher,
Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
"Koenig,
Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision
Date: Tue, 15 Oct 2019 18:01:15 +0000 [thread overview]
Message-ID: <e4b046e5-b91a-997c-e47c-dae0360d3a27@amd.com> (raw)
In-Reply-To: <20191014032118.14020-1-tianci.yin-5C7GfCeVMHo@public.gmane.org>
Patches 1-7: Looks good.
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
Patch 8: NAK! for the same exact reason as the previous review. No changes to NAK reasoning from previous review.
Regards,
Luben
On 2019-10-13 11:21 p.m., Tianci Yin wrote:
> From: "Tianci.Yin" <tianci.yin@amd.com>
>
> update amdgpu_discovery to get IP revision.
>
> Change-Id: If8152103d03b58e1dc0f32db63625e290f5f08a0
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++-
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 71198c5318e1..ddd8364102a2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -333,7 +333,7 @@ int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev)
> }
>
> int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id,
> - int *major, int *minor)
> + int *major, int *minor, int *revision)
> {
> struct binary_header *bhdr;
> struct ip_discovery_header *ihdr;
> @@ -369,6 +369,8 @@ int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id,
> *major = ip->major;
> if (minor)
> *minor = ip->minor;
> + if (revision)
> + *revision = ip->revision;
> return 0;
> }
> ip_offset += sizeof(*ip) + 4 * (ip->num_base_address - 1);
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h
> index 5a6693d7d269..ba78e15d9b05 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h
> @@ -30,7 +30,7 @@ int amdgpu_discovery_init(struct amdgpu_device *adev);
> void amdgpu_discovery_fini(struct amdgpu_device *adev);
> int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev);
> int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id,
> - int *major, int *minor);
> + int *major, int *minor, int *revision);
> int amdgpu_discovery_get_gfx_info(struct amdgpu_device *adev);
>
> #endif /* __AMDGPU_DISCOVERY__ */
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-10-15 18:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 3:21 [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision Tianci Yin
[not found] ` <20191014032118.14020-1-tianci.yin-5C7GfCeVMHo@public.gmane.org>
2019-10-14 3:21 ` [PATCH 2/8] drm/amdgpu: add a generic fb accessing helper function(v3) Tianci Yin
2019-10-14 3:21 ` [PATCH 3/8] drm/amdgpu: introduce psp_v11_0_is_sos_alive interface(v2) Tianci Yin
2019-10-14 3:21 ` [PATCH 4/8] drm/amdgpu: update atomfirmware header with memory training related members(v3) Tianci Yin
2019-10-14 3:21 ` [PATCH 5/8] drm/amdgpu/atomfirmware: add memory training related helper functions(v3) Tianci Yin
2019-10-14 3:21 ` [PATCH 6/8] drm/amdgpu: add psp memory training callbacks and macro Tianci Yin
2019-10-14 3:21 ` [PATCH 7/8] drm/amdgpu: reserve vram for memory training(v3) Tianci Yin
2019-10-14 3:21 ` [PATCH 8/8] drm/amdgpu/psp: add psp memory training implementation Tianci Yin
[not found] ` <20191014032118.14020-8-tianci.yin-5C7GfCeVMHo@public.gmane.org>
2019-10-15 17:59 ` Tuikov, Luben
[not found] ` <ee92928c-0484-b6d0-2230-1587dc4166af-5C7GfCeVMHo@public.gmane.org>
2019-10-16 2:19 ` Yin, Tianci (Rico)
2019-10-15 18:01 ` Tuikov, Luben [this message]
[not found] ` <e4b046e5-b91a-997c-e47c-dae0360d3a27-5C7GfCeVMHo@public.gmane.org>
2019-10-16 2:24 ` [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision Yin, Tianci (Rico)
-- strict thread matches above, loose matches on Subject: below --
2019-10-11 3:50 Tianci Yin
2019-10-08 19:29 [PATCH 0/8] low latency memory training for navi Alex Deucher
[not found] ` <20191008192934.5481-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-10-08 19:29 ` [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b046e5-b91a-997c-e47c-dae0360d3a27@amd.com \
--to=luben.tuikov-5c7gfcevmho@public.gmane.org \
--cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
--cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
--cc=Tianci.Yin-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox