Re: [PATCH v2] drm/amd/display: Add missing do_mccs parameter description

[Alex Hung <alex.hung@amd.com>]

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 4/8/26 19:41, Srinivasan Shanmugam wrote:
> Add missing description for do_mccs parameter in
> amdgpu_dm_update_freesync_caps.
> 
> Fixes the below with gcc W=1:
> ../display/amdgpu_dm/amdgpu_dm.c:13269 function parameter 'do_mccs' not described in 'amdgpu_dm_update_freesync_caps'
> 
> Fixes: 980a8981351a ("drm/amd/display: Avoid to do MCCS transaction if unnecessary")
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Wayne Lin <Wayne.Lin@amd.com>
> Cc: Roman Li <roman.li@amd.com>
> Cc: Alex Hung <alex.hung@amd.com>
> Cc: Tom Chung <chiahsuan.chung@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index bac02ea15b8a..77ef24ca8b26 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -13259,6 +13259,10 @@ static int parse_hdmi_amd_vsdb(struct amdgpu_dm_connector *aconnector,
>    *
>    * @connector: Connector to query.
>    * @drm_edid: DRM EDID from monitor
> + * @do_mccs: Controls whether MCCS (Monitor Control Command Set) over
> + *	      DDC (Display Data Channel) transactions are performed. When true,
> + *	      the driver queries the monitor to get or update additional FreeSync
> + *	      capability information. When false, these transactions are skipped.
>    *
>    * Amdgpu supports Freesync in DP and HDMI displays, and it is required to keep
>    * track of some of the display information in the internal data struct used by