From: "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Kuehling, Felix" <Felix.Kuehling@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [Patch v1 1/5] drm/amdgpu: always enable runtime power management
Date: Thu, 30 Jan 2020 14:06:12 -0500 [thread overview]
Message-ID: <e8717038-7452-1ef1-5eb5-394533c7ef37@amd.com> (raw)
In-Reply-To: <CADnq5_N6vKSpLGBj2TkiCOaOskrT2T4EQ3NmNp0hOLumCLithw@mail.gmail.com>
On 1/28/2020 3:14 PM, Alex Deucher wrote:
> [CAUTION: External Email]
>
> On Mon, Jan 27, 2020 at 8:30 PM Rajneesh Bhardwaj
> <rajneesh.bhardwaj@amd.com> wrote:
>> This allows runtime power management to kick in on amdgpu driver when
>> the underlying hardware supports either BOCO or BACO. This can still be
>> avoided if boot arg amdgpu.runpm = 0 is supplied.
>>
>> BOCO: Bus Off, Chip Off
>> BACO: Bus Alive, Chip Off
>>
>> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
> This patch should be the last one in the series, otherwise we'll
> enable runpm on BACO capable devices before the KFD code is in place.
> Also, it's only supported on VI and newer asics, so we should use this
> patch instead:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F335402%2F&data=02%7C01%7Crajneesh.bhardwaj%40amd.com%7C01f67fc720d3423ee6b908d7a42eb68d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637158392852429503&sdata=aU07GE56Vfb0JTSDsVDdyCdhxUkjHEVMAHiBaBC4V7g%3D&reserved=0
>
> Alex
Thanks, Will fix in v2.
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 9 ++++-----
>> 1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
>> index 3a0ea9096498..7958d508486e 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
>> @@ -169,11 +169,10 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
>> goto out;
>> }
>>
>> - if (amdgpu_device_supports_boco(dev) &&
>> - (amdgpu_runtime_pm != 0)) /* enable runpm by default */
>> - adev->runpm = true;
>> - else if (amdgpu_device_supports_baco(dev) &&
>> - (amdgpu_runtime_pm > 0)) /* enable runpm if runpm=1 */
>> + /* always enable runtime power management except when amdgpu.runpm=0 */
>> + if ((amdgpu_device_supports_boco(dev) ||
>> + amdgpu_device_supports_baco(dev))
>> + && (amdgpu_runtime_pm != 0))
>> adev->runpm = true;
>>
>> /* Call ACPI methods: require modeset init
>> --
>> 2.17.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Crajneesh.bhardwaj%40amd.com%7C01f67fc720d3423ee6b908d7a42eb68d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637158392852429503&sdata=%2BXwHkoDeyA9Q%2FwnSyaND6QOc1SxpGuAHkZ4JdaTM3wU%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-30 19:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 1:29 [Patch v1 0/5] Enable BACO with KFD Rajneesh Bhardwaj
2020-01-28 1:29 ` [Patch v1 1/5] drm/amdgpu: always enable runtime power management Rajneesh Bhardwaj
2020-01-28 20:14 ` Alex Deucher
2020-01-30 19:06 ` Bhardwaj, Rajneesh [this message]
2020-01-28 1:29 ` [Patch v1 2/5] drm/amdgpu: Fix missing error check in suspend Rajneesh Bhardwaj
2020-01-28 20:15 ` Alex Deucher
2020-01-28 1:29 ` [Patch v1 3/5] drm/amdkfd: Introduce debugfs option to disable baco Rajneesh Bhardwaj
2020-01-28 20:22 ` Alex Deucher
2020-01-30 19:05 ` Bhardwaj, Rajneesh
2020-01-28 1:29 ` [Patch v1 4/5] drm/amdkfd: show warning when kfd is locked Rajneesh Bhardwaj
2020-01-28 22:42 ` Felix Kuehling
2020-01-30 19:02 ` Bhardwaj, Rajneesh
2020-01-28 1:29 ` [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco Rajneesh Bhardwaj
2020-01-28 20:09 ` Zeng, Oak
2020-01-30 19:08 ` Bhardwaj, Rajneesh
2020-01-29 22:52 ` Felix Kuehling
2020-01-30 19:01 ` Bhardwaj, Rajneesh
2020-01-30 21:55 ` Felix Kuehling
2020-01-30 22:11 ` Alex Deucher
2020-01-30 23:24 ` Felix Kuehling
2020-01-31 0:53 ` Zeng, Oak
2020-01-28 17:39 ` [Patch v1 0/5] Enable BACO with KFD Mike Lothian
2020-01-28 20:11 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8717038-7452-1ef1-5eb5-394533c7ef37@amd.com \
--to=rajneesh.bhardwaj@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox