From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30899EB64D9 for ; Thu, 6 Jul 2023 14:06:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A663010E0A2; Thu, 6 Jul 2023 14:06:35 +0000 (UTC) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id F0C8210E405 for ; Thu, 6 Jul 2023 14:03:55 +0000 (UTC) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-656bc570a05so152185b3a.0 for ; Thu, 06 Jul 2023 07:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1688652235; x=1691244235; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WhSDI9mp0MYKeqY0tJX7SergTVTmGv0F/ckbyNmGNLQ=; b=FMqh2CmzOm6XDjJjezWBlN875lQ5T+a7DnklQNymtU9D+p4Vamdg/lVJcXx5LK9wQB KMF3m7xyChwczs3gSrW0hfYLg6AHUOPg2tw1QHIcglCDiKzSYTOIQrtnMYep6XtsjIep DxJJ6tEz23KWKTCsBzXv4e2DMZK0tudoGmt64Vn23mE4w14gdIX8FajdCS/c+EBdj4BM OLhNcMy3ZYtdTw3gnyRZjxn7tMXpguxXzPohD9RzlAV02/2dZlziCIX9IP1zVTQgKS/1 HI6e6TX7bpBdHRlpwO53EfTwR3UPufykmkpeAJRybBh5mzEiKnBBl2q/GqPD8Ytlw/Gs lsQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688652235; x=1691244235; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WhSDI9mp0MYKeqY0tJX7SergTVTmGv0F/ckbyNmGNLQ=; b=dKJaTAmBeXFQOp3lQn8shqG+KzIyBoLe7bTixrHkgn3irTPorfagb9V45MyhpDK1He OYrDAyZrm9BmVNZxUXLk8zhedejvSGzO6CMtbiKarmcMKplHYecVypUb1yDDkOdUP4z9 7n6D1x4lh1x0sutuWb/T2QThBvK6+ITHG32T7McFiG4GSKEySJquLwiGhQ/60xiLjf5+ JKtxUG7LVFOoW/OamzbftIFKi9OtzquVfpgfUCmvS1ZAwS9TA17Z1eA61RMjMB/y/dPe rm1Mm6pvsGL/pzPsEpOCL4VnlJKg4kclkkJ/rFE/BOQWxHdwiKz4Kbo0v+f+CvH4WeFe jWWg== X-Gm-Message-State: ABy/qLaVh79u+ZsUw5ON1CV4ZfHAHA/9ovxJa89kxieHtK5E951qPk8Q /F2Gh8yBTNFmO+VJWd3O5d1qzw== X-Google-Smtp-Source: APBJJlHWx70FxXddJLp/svv44qJ/lHFgMni3NpkbFoqzcjvrqGi64yR8YRM3ydyDuI4xKaOrlEAb7Q== X-Received: by 2002:a05:6a20:7495:b0:12d:2abe:549a with SMTP id p21-20020a056a20749500b0012d2abe549amr2182854pzd.6.1688652234613; Thu, 06 Jul 2023 07:03:54 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id z21-20020aa791d5000000b0063b898b3502sm1322987pfa.153.2023.07.06.07.03.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 07:03:53 -0700 (PDT) Message-ID: Date: Thu, 6 Jul 2023 08:03:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring Content-Language: en-US To: Alex Deucher , Yang Rong References: <20230706021102.2066-1-yangrong@vivo.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 06 Jul 2023 14:06:34 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Tseng , "Michael S. Tsirkin" , Jason Wang , "open list:DRM DRIVERS" , "open list:VIRTIO CORE AND NET DRIVERS" , Eric Dumazet , Jun Lei , Josip Pavic , Xuan Zhuo , David Airlie , Rodrigo Siqueira , "open list:AMD DISPLAY CORE" , "open list:IO_URING" , Alvin Lee , Jakub Kicinski , Paolo Abeni , Harry Wentland , opensource.kernel@vivo.com, Leo Li , Cruise Hung , "open list:NETWORKING DRIVERS" , Qingqing Zhuo , "Pan, Xinhui" , open list , luhongfei@vivo.com, "David S. Miller" , Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Pavel Begunkov Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 7/6/23 7:58?AM, Alex Deucher wrote: > On Thu, Jul 6, 2023 at 3:37?AM Yang Rong wrote: >> >> The files drivers/net/virtio_net.c, drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were modified to fix warnings. >> Specifically, the opportunities for max() and min() were utilized to address the warnings. > > Please split this into 3 patches, one for each component. Don't bother with the io_uring one, code is far more readable as-is. -- Jens Axboe