From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kuehling, Felix" Subject: Re: [PATCH 07/13] mm: remove the page_shift member from struct hmm_range Date: Wed, 31 Jul 2019 13:38:57 +0000 Message-ID: References: <20190730055203.28467-1-hch@lst.de> <20190730055203.28467-8-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190730055203.28467-8-hch@lst.de> Content-Language: en-US Content-ID: <3444F4D31C9224418100B98160B88C5A@namprd12.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig , =?utf-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Ben Skeggs Cc: Ralph Campbell , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" List-Id: amd-gfx.lists.freedesktop.org T24gMjAxOS0wNy0zMCAxOjUxIGEubS4sIENocmlzdG9waCBIZWxsd2lnIHdyb3RlOg0KPiBBbGwg dXNlcnMgcGFzcyBQQUdFX1NJWkUgaGVyZSwgYW5kIGlmIHdlIHdhbnRlZCB0byBzdXBwb3J0IHNp bmdsZQ0KPiBlbnRyaWVzIGZvciBodWdlIHBhZ2VzIHdlIHNob3VsZCByZWFsbHkganVzdCBhZGQg YSBITU1fRkFVTFRfSFVHRVBBR0UNCj4gZmxhZyBpbnN0ZWFkIHRoYXQgdXNlcyB0aGUgaHVnZSBw YWdlIHNpemUgaW5zdGVhZCBvZiBoYXZpbmcgdGhlDQo+IGNhbGxlciBjYWxjdWxhdGUgdGhhdCBz aXplIG9uY2UsIGp1c3QgZm9yIHRoZSBobW0gY29kZSB0byB2ZXJpZnkgaXQuDQoNCk1heWJlIHRo aXMgd2FzIG1lYW50IHRvIHN1cHBvcnQgZGV2aWNlIHBhZ2Ugc2l6ZSAhPSBuYXRpdmUgcGFnZSBz aXplPyANCkFueXdheSwgbG9va3MgbGlrZSB3ZSBkaWRuJ3QgdXNlIGl0IHRoYXQgd2F5Lg0KDQpB Y2tlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5jb20+DQoNCg0KPg0K PiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4NCj4gLS0tDQo+ ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jIHwgIDEgLQ0KPiAgIGRy aXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfc3ZtLmMgICB8ICAxIC0NCj4gICBpbmNsdWRl L2xpbnV4L2htbS5oICAgICAgICAgICAgICAgICAgICAgfCAyMiAtLS0tLS0tLS0tLS0tDQo+ICAg bW0vaG1tLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgNDIgKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLQ0KPiAgIDQgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA1NyBk ZWxldGlvbnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV90dG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYw0K PiBpbmRleCA3MWQ2ZTcwODdiMGIuLjhiZjc5Mjg4YzRlMiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYw0KPiBAQCAtODE4LDcgKzgxOCw2IEBAIGludCBhbWRn cHVfdHRtX3R0X2dldF91c2VyX3BhZ2VzKHN0cnVjdCBhbWRncHVfYm8gKmJvLCBzdHJ1Y3QgcGFn ZSAqKnBhZ2VzKQ0KPiAgIAkJCQkwIDogcmFuZ2UtPmZsYWdzW0hNTV9QRk5fV1JJVEVdOw0KPiAg IAlyYW5nZS0+cGZuX2ZsYWdzX21hc2sgPSAwOw0KPiAgIAlyYW5nZS0+cGZucyA9IHBmbnM7DQo+ IC0JcmFuZ2UtPnBhZ2Vfc2hpZnQgPSBQQUdFX1NISUZUOw0KPiAgIAlyYW5nZS0+c3RhcnQgPSBz dGFydDsNCj4gICAJcmFuZ2UtPmVuZCA9IHN0YXJ0ICsgdHRtLT5udW1fcGFnZXMgKiBQQUdFX1NJ WkU7DQo+ICAgDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1 X3N2bS5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9zdm0uYw0KPiBpbmRleCA0 MGU3MDYyMzQ1NTQuLmU3MDY4Y2U0Njk0OSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L25vdXZlYXUvbm91dmVhdV9zdm0uYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9u b3V2ZWF1X3N2bS5jDQo+IEBAIC02ODAsNyArNjgwLDYgQEAgbm91dmVhdV9zdm1fZmF1bHQoc3Ry dWN0IG52aWZfbm90aWZ5ICpub3RpZnkpDQo+ICAgCQkJIGFyZ3MuaS5wLmFkZHIgKyBhcmdzLmku cC5zaXplLCBmbiAtIGZpKTsNCj4gICANCj4gICAJCS8qIEhhdmUgSE1NIGZhdWx0IHBhZ2VzIHdp dGhpbiB0aGUgZmF1bHQgd2luZG93IHRvIHRoZSBHUFUuICovDQo+IC0JCXJhbmdlLnBhZ2Vfc2hp ZnQgPSBQQUdFX1NISUZUOw0KPiAgIAkJcmFuZ2Uuc3RhcnQgPSBhcmdzLmkucC5hZGRyOw0KPiAg IAkJcmFuZ2UuZW5kID0gYXJncy5pLnAuYWRkciArIGFyZ3MuaS5wLnNpemU7DQo+ICAgCQlyYW5n ZS5wZm5zID0gYXJncy5waHlzOw0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9obW0uaCBi L2luY2x1ZGUvbGludXgvaG1tLmgNCj4gaW5kZXggYzViNTEzNzZiNDUzLi41MWUxOGZiYjg5NTMg MTAwNjQ0DQo+IC0tLSBhL2luY2x1ZGUvbGludXgvaG1tLmgNCj4gKysrIGIvaW5jbHVkZS9saW51 eC9obW0uaA0KPiBAQCAtMTU4LDcgKzE1OCw2IEBAIGVudW0gaG1tX3Bmbl92YWx1ZV9lIHsNCj4g ICAgKiBAdmFsdWVzOiBwZm4gdmFsdWUgZm9yIHNvbWUgc3BlY2lhbCBjYXNlIChub25lLCBzcGVj aWFsLCBlcnJvciwgLi4uKQ0KPiAgICAqIEBkZWZhdWx0X2ZsYWdzOiBkZWZhdWx0IGZsYWdzIGZv ciB0aGUgcmFuZ2UgKHdyaXRlLCByZWFkLCAuLi4gc2VlIGhtbSBkb2MpDQo+ICAgICogQHBmbl9m bGFnc19tYXNrOiBhbGxvd3MgdG8gbWFzayBwZm4gZmxhZ3Mgc28gdGhhdCBvbmx5IGRlZmF1bHRf ZmxhZ3MgbWF0dGVyDQo+IC0gKiBAcGFnZV9zaGlmdDogZGV2aWNlIHZpcnR1YWwgYWRkcmVzcyBz aGlmdCB2YWx1ZSAoc2hvdWxkIGJlID49IFBBR0VfU0hJRlQpDQo+ICAgICogQHBmbl9zaGlmdHM6 IHBmbiBzaGlmdCB2YWx1ZSAoc2hvdWxkIGJlIDw9IFBBR0VfU0hJRlQpDQo+ICAgICogQHZhbGlk OiBwZm5zIGFycmF5IGRpZCBub3QgY2hhbmdlIHNpbmNlIGl0IGhhcyBiZWVuIGZpbGwgYnkgYW4g SE1NIGZ1bmN0aW9uDQo+ICAgICovDQo+IEBAIC0xNzIsMzEgKzE3MSwxMCBAQCBzdHJ1Y3QgaG1t X3JhbmdlIHsNCj4gICAJY29uc3QgdWludDY0X3QJCSp2YWx1ZXM7DQo+ICAgCXVpbnQ2NF90CQlk ZWZhdWx0X2ZsYWdzOw0KPiAgIAl1aW50NjRfdAkJcGZuX2ZsYWdzX21hc2s7DQo+IC0JdWludDhf dAkJCXBhZ2Vfc2hpZnQ7DQo+ICAgCXVpbnQ4X3QJCQlwZm5fc2hpZnQ7DQo+ICAgCWJvb2wJCQl2 YWxpZDsNCj4gICB9Ow0KPiAgIA0KPiAtLyoNCj4gLSAqIGhtbV9yYW5nZV9wYWdlX3NoaWZ0KCkg LSByZXR1cm4gdGhlIHBhZ2Ugc2hpZnQgZm9yIHRoZSByYW5nZQ0KPiAtICogQHJhbmdlOiByYW5n ZSBiZWluZyBxdWVyaWVkDQo+IC0gKiBSZXR1cm46IHBhZ2Ugc2hpZnQgKHBhZ2Ugc2l6ZSA9IDEg PDwgcGFnZSBzaGlmdCkgZm9yIHRoZSByYW5nZQ0KPiAtICovDQo+IC1zdGF0aWMgaW5saW5lIHVu c2lnbmVkIGhtbV9yYW5nZV9wYWdlX3NoaWZ0KGNvbnN0IHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdl KQ0KPiAtew0KPiAtCXJldHVybiByYW5nZS0+cGFnZV9zaGlmdDsNCj4gLX0NCj4gLQ0KPiAtLyoN Cj4gLSAqIGhtbV9yYW5nZV9wYWdlX3NpemUoKSAtIHJldHVybiB0aGUgcGFnZSBzaXplIGZvciB0 aGUgcmFuZ2UNCj4gLSAqIEByYW5nZTogcmFuZ2UgYmVpbmcgcXVlcmllZA0KPiAtICogUmV0dXJu OiBwYWdlIHNpemUgZm9yIHRoZSByYW5nZSBpbiBieXRlcw0KPiAtICovDQo+IC1zdGF0aWMgaW5s aW5lIHVuc2lnbmVkIGxvbmcgaG1tX3JhbmdlX3BhZ2Vfc2l6ZShjb25zdCBzdHJ1Y3QgaG1tX3Jh bmdlICpyYW5nZSkNCj4gLXsNCj4gLQlyZXR1cm4gMVVMIDw8IGhtbV9yYW5nZV9wYWdlX3NoaWZ0 KHJhbmdlKTsNCj4gLX0NCj4gLQ0KPiAgIC8qDQo+ICAgICogaG1tX3JhbmdlX3dhaXRfdW50aWxf dmFsaWQoKSAtIHdhaXQgZm9yIHJhbmdlIHRvIGJlIHZhbGlkDQo+ICAgICogQHJhbmdlOiByYW5n ZSBhZmZlY3RlZCBieSBpbnZhbGlkYXRpb24gdG8gd2FpdCBvbg0KPiBkaWZmIC0tZ2l0IGEvbW0v aG1tLmMgYi9tbS9obW0uYw0KPiBpbmRleCA5MjY3MzVhM2FlZjkuLmYyNmQ2YWJjNGVkMiAxMDA2 NDQNCj4gLS0tIGEvbW0vaG1tLmMNCj4gKysrIGIvbW0vaG1tLmMNCj4gQEAgLTM0NCwxMyArMzQ0 LDEyIEBAIHN0YXRpYyBpbnQgaG1tX3ZtYV93YWxrX2hvbGVfKHVuc2lnbmVkIGxvbmcgYWRkciwg dW5zaWduZWQgbG9uZyBlbmQsDQo+ICAgCXN0cnVjdCBobW1fdm1hX3dhbGsgKmhtbV92bWFfd2Fs ayA9IHdhbGstPnByaXZhdGU7DQo+ICAgCXN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlID0gaG1tX3Zt YV93YWxrLT5yYW5nZTsNCj4gICAJdWludDY0X3QgKnBmbnMgPSByYW5nZS0+cGZuczsNCj4gLQl1 bnNpZ25lZCBsb25nIGksIHBhZ2Vfc2l6ZTsNCj4gKwl1bnNpZ25lZCBsb25nIGk7DQo+ICAgDQo+ ICAgCWhtbV92bWFfd2Fsay0+bGFzdCA9IGFkZHI7DQo+IC0JcGFnZV9zaXplID0gaG1tX3Jhbmdl X3BhZ2Vfc2l6ZShyYW5nZSk7DQo+IC0JaSA9IChhZGRyIC0gcmFuZ2UtPnN0YXJ0KSA+PiByYW5n ZS0+cGFnZV9zaGlmdDsNCj4gKwlpID0gKGFkZHIgLSByYW5nZS0+c3RhcnQpID4+IFBBR0VfU0hJ RlQ7DQo+ICAgDQo+IC0JZm9yICg7IGFkZHIgPCBlbmQ7IGFkZHIgKz0gcGFnZV9zaXplLCBpKysp IHsNCj4gKwlmb3IgKDsgYWRkciA8IGVuZDsgYWRkciArPSBQQUdFX1NJWkUsIGkrKykgew0KPiAg IAkJcGZuc1tpXSA9IHJhbmdlLT52YWx1ZXNbSE1NX1BGTl9OT05FXTsNCj4gICAJCWlmIChmYXVs dCB8fCB3cml0ZV9mYXVsdCkgew0KPiAgIAkJCWludCByZXQ7DQo+IEBAIC03NzIsNyArNzcxLDcg QEAgc3RhdGljIGludCBobW1fdm1hX3dhbGtfaHVnZXRsYl9lbnRyeShwdGVfdCAqcHRlLCB1bnNp Z25lZCBsb25nIGhtYXNrLA0KPiAgIAkJCQkgICAgICBzdHJ1Y3QgbW1fd2FsayAqd2FsaykNCj4g ICB7DQo+ICAgI2lmZGVmIENPTkZJR19IVUdFVExCX1BBR0UNCj4gLQl1bnNpZ25lZCBsb25nIGFk ZHIgPSBzdGFydCwgaSwgcGZuLCBtYXNrLCBzaXplLCBwZm5faW5jOw0KPiArCXVuc2lnbmVkIGxv bmcgYWRkciA9IHN0YXJ0LCBpLCBwZm4sIG1hc2s7DQo+ICAgCXN0cnVjdCBobW1fdm1hX3dhbGsg KmhtbV92bWFfd2FsayA9IHdhbGstPnByaXZhdGU7DQo+ICAgCXN0cnVjdCBobW1fcmFuZ2UgKnJh bmdlID0gaG1tX3ZtYV93YWxrLT5yYW5nZTsNCj4gICAJc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2 bWEgPSB3YWxrLT52bWE7DQo+IEBAIC03ODMsMjQgKzc4MiwxMiBAQCBzdGF0aWMgaW50IGhtbV92 bWFfd2Fsa19odWdldGxiX2VudHJ5KHB0ZV90ICpwdGUsIHVuc2lnbmVkIGxvbmcgaG1hc2ssDQo+ ICAgCXB0ZV90IGVudHJ5Ow0KPiAgIAlpbnQgcmV0ID0gMDsNCj4gICANCj4gLQlzaXplID0gaHVn ZV9wYWdlX3NpemUoaCk7DQo+IC0JbWFzayA9IHNpemUgLSAxOw0KPiAtCWlmIChyYW5nZS0+cGFn ZV9zaGlmdCAhPSBQQUdFX1NISUZUKSB7DQo+IC0JCS8qIE1ha2Ugc3VyZSB3ZSBhcmUgbG9va2lu ZyBhdCBhIGZ1bGwgcGFnZS4gKi8NCj4gLQkJaWYgKHN0YXJ0ICYgbWFzaykNCj4gLQkJCXJldHVy biAtRUlOVkFMOw0KPiAtCQlpZiAoZW5kIDwgKHN0YXJ0ICsgc2l6ZSkpDQo+IC0JCQlyZXR1cm4g LUVJTlZBTDsNCj4gLQkJcGZuX2luYyA9IHNpemUgPj4gUEFHRV9TSElGVDsNCj4gLQl9IGVsc2Ug ew0KPiAtCQlwZm5faW5jID0gMTsNCj4gLQkJc2l6ZSA9IFBBR0VfU0laRTsNCj4gLQl9DQo+ICsJ bWFzayA9IGh1Z2VfcGFnZV9zaXplKGgpIC0gMTsNCj4gICANCj4gICAJcHRsID0gaHVnZV9wdGVf bG9jayhoc3RhdGVfdm1hKHZtYSksIHdhbGstPm1tLCBwdGUpOw0KPiAgIAllbnRyeSA9IGh1Z2Vf cHRlcF9nZXQocHRlKTsNCj4gICANCj4gLQlpID0gKHN0YXJ0IC0gcmFuZ2UtPnN0YXJ0KSA+PiBy YW5nZS0+cGFnZV9zaGlmdDsNCj4gKwlpID0gKHN0YXJ0IC0gcmFuZ2UtPnN0YXJ0KSA+PiBQQUdF X1NISUZUOw0KPiAgIAlvcmlnX3BmbiA9IHJhbmdlLT5wZm5zW2ldOw0KPiAgIAlyYW5nZS0+cGZu c1tpXSA9IHJhbmdlLT52YWx1ZXNbSE1NX1BGTl9OT05FXTsNCj4gICAJY3B1X2ZsYWdzID0gcHRl X3RvX2htbV9wZm5fZmxhZ3MocmFuZ2UsIGVudHJ5KTsNCj4gQEAgLTgxMiw4ICs3OTksOCBAQCBz dGF0aWMgaW50IGhtbV92bWFfd2Fsa19odWdldGxiX2VudHJ5KHB0ZV90ICpwdGUsIHVuc2lnbmVk IGxvbmcgaG1hc2ssDQo+ICAgCQlnb3RvIHVubG9jazsNCj4gICAJfQ0KPiAgIA0KPiAtCXBmbiA9 IHB0ZV9wZm4oZW50cnkpICsgKChzdGFydCAmIG1hc2spID4+IHJhbmdlLT5wYWdlX3NoaWZ0KTsN Cj4gLQlmb3IgKDsgYWRkciA8IGVuZDsgYWRkciArPSBzaXplLCBpKyssIHBmbiArPSBwZm5faW5j KQ0KPiArCXBmbiA9IHB0ZV9wZm4oZW50cnkpICsgKChzdGFydCAmIG1hc2spID4+IFBBR0VfU0hJ RlQpOw0KPiArCWZvciAoOyBhZGRyIDwgZW5kOyBhZGRyICs9IFBBR0VfU0laRSwgaSsrLCBwZm4r KykNCj4gICAJCXJhbmdlLT5wZm5zW2ldID0gaG1tX2RldmljZV9lbnRyeV9mcm9tX3BmbihyYW5n ZSwgcGZuKSB8DQo+ICAgCQkJCSBjcHVfZmxhZ3M7DQo+ICAgCWhtbV92bWFfd2Fsay0+bGFzdCA9 IGVuZDsNCj4gQEAgLTg1MCwxNCArODM3LDEzIEBAIHN0YXRpYyB2b2lkIGhtbV9wZm5zX2NsZWFy KHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlLA0KPiAgICAqLw0KPiAgIGludCBobW1fcmFuZ2VfcmVn aXN0ZXIoc3RydWN0IGhtbV9yYW5nZSAqcmFuZ2UsIHN0cnVjdCBobW1fbWlycm9yICptaXJyb3Ip DQo+ICAgew0KPiAtCXVuc2lnbmVkIGxvbmcgbWFzayA9ICgoMVVMIDw8IHJhbmdlLT5wYWdlX3No aWZ0KSAtIDFVTCk7DQo+ICAgCXN0cnVjdCBobW0gKmhtbSA9IG1pcnJvci0+aG1tOw0KPiAgIAl1 bnNpZ25lZCBsb25nIGZsYWdzOw0KPiAgIA0KPiAgIAlyYW5nZS0+dmFsaWQgPSBmYWxzZTsNCj4g ICAJcmFuZ2UtPmhtbSA9IE5VTEw7DQo+ICAgDQo+IC0JaWYgKChyYW5nZS0+c3RhcnQgJiBtYXNr KSB8fCAocmFuZ2UtPmVuZCAmIG1hc2spKQ0KPiArCWlmICgocmFuZ2UtPnN0YXJ0ICYgKFBBR0Vf U0laRSAtIDEpKSB8fCAocmFuZ2UtPmVuZCAmIChQQUdFX1NJWkUgLSAxKSkpDQo+ICAgCQlyZXR1 cm4gLUVJTlZBTDsNCj4gICAJaWYgKHJhbmdlLT5zdGFydCA+PSByYW5nZS0+ZW5kKQ0KPiAgIAkJ cmV0dXJuIC1FSU5WQUw7DQo+IEBAIC05NjQsMTYgKzk1MCw2IEBAIGxvbmcgaG1tX3JhbmdlX2Zh dWx0KHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlLCB1bnNpZ25lZCBpbnQgZmxhZ3MpDQo+ICAgCQlp ZiAodm1hID09IE5VTEwgfHwgKHZtYS0+dm1fZmxhZ3MgJiBkZXZpY2Vfdm1hKSkNCj4gICAJCQly ZXR1cm4gLUVGQVVMVDsNCj4gICANCj4gLQkJaWYgKGlzX3ZtX2h1Z2V0bGJfcGFnZSh2bWEpKSB7 DQo+IC0JCQlpZiAoaHVnZV9wYWdlX3NoaWZ0KGhzdGF0ZV92bWEodm1hKSkgIT0NCj4gLQkJCSAg ICByYW5nZS0+cGFnZV9zaGlmdCAmJg0KPiAtCQkJICAgIHJhbmdlLT5wYWdlX3NoaWZ0ICE9IFBB R0VfU0hJRlQpDQo+IC0JCQkJcmV0dXJuIC1FSU5WQUw7DQo+IC0JCX0gZWxzZSB7DQo+IC0JCQlp ZiAocmFuZ2UtPnBhZ2Vfc2hpZnQgIT0gUEFHRV9TSElGVCkNCj4gLQkJCQlyZXR1cm4gLUVJTlZB TDsNCj4gLQkJfQ0KPiAtDQo+ICAgCQlpZiAoISh2bWEtPnZtX2ZsYWdzICYgVk1fUkVBRCkpIHsN Cj4gICAJCQkvKg0KPiAgIAkJCSAqIElmIHZtYSBkbyBub3QgYWxsb3cgcmVhZCBhY2Nlc3MsIHRo ZW4gYXNzdW1lIHRoYXQgaXQNCg==