From: Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] winsys/radeon: Allow visible VRAM size > 256MB with kernel driver >= 2.49
Date: Tue, 31 Jan 2017 10:12:13 +0100 [thread overview]
Message-ID: <f4066b69-cf30-ff5b-9480-5579ecf6d8de@gmail.com> (raw)
In-Reply-To: <20170131065414.2434-2-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Thanks for fixing this Michel.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
On 01/31/2017 07:54 AM, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> The kernel driver reports correct values now.
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
> ---
> src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c b/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c
> index a8da62fd36..cacd683879 100644
> --- a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c
> +++ b/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c
> @@ -372,7 +372,12 @@ static bool do_winsys_init(struct radeon_drm_winsys *ws)
> }
> ws->info.gart_size = gem_info.gart_size;
> ws->info.vram_size = gem_info.vram_size;
> - ws->info.vram_vis_size = MIN2(gem_info.vram_visible, 256*1024*1024);
> + ws->info.vram_vis_size = gem_info.vram_visible;
> + /* Older versions of the kernel driver reported incorrect values, and
> + * didn't support more than 256MB of visible VRAM anyway
> + */
> + if (ws->info.drm_minor < 49)
> + ws->info.vram_vis_size = MIN2(ws->info.vram_vis_size, 256*1024*1024);
>
> /* Radeon allocates all buffers as contigous, which makes large allocations
> * unlikely to succeed. */
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-01-31 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 6:54 [PATCH] drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl Michel Dänzer
[not found] ` <20170131065414.2434-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-01-31 6:54 ` [PATCH] winsys/radeon: Allow visible VRAM size > 256MB with kernel driver >= 2.49 Michel Dänzer
[not found] ` <20170131065414.2434-2-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-01-31 9:12 ` Samuel Pitoiset [this message]
2017-01-31 11:44 ` Nicolai Hähnle
2017-01-31 15:30 ` Deucher, Alexander
2017-01-31 9:09 ` [PATCH] drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl Christian König
2017-01-31 15:30 ` Deucher, Alexander
2017-01-31 11:24 ` Dieter Nützel
[not found] ` <5abbe0dcb709f4624fa52f32d9e3e3d5-0hun7QTegEsDD4udEopG9Q@public.gmane.org>
2017-01-31 15:43 ` [Mesa-dev] " Deucher, Alexander
[not found] ` <BN6PR12MB16528D1DF5184C0A29572C04F74A0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-01-31 21:08 ` Dieter Nützel
2017-01-31 22:06 ` Emil Velikov
[not found] ` <CACvgo50tFrVg+vq=Lt+5p-GYb9v+M-jRVq66rLAENFn5yoPWDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-31 22:23 ` [Mesa-dev] " Alex Deucher
[not found] ` <CADnq5_MA5NNZ=9T_U7=GG-n-AHs+VxtwksSE6v=9DSAgyZk=Xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-01 19:43 ` Marek Olšák
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4066b69-cf30-ff5b-9480-5579ecf6d8de@gmail.com \
--to=samuel.pitoiset-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox