From: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
To: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/dc: Disentangle dc.h include from amdgpu.h
Date: Thu, 29 Mar 2018 11:09:56 -0400 [thread overview]
Message-ID: <f4604a26-4e9e-8e5e-7680-d99fc7cc4e0b@amd.com> (raw)
In-Reply-To: <1522309467-10887-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
On 2018-03-29 03:44 AM, Rex Zhu wrote:
> Use forward declaration in amdgpu_dm.h for struct dc instand
> of include dc.h to make header files more standalone
>
> Change-Id: I733a7e8499949aa9411e943230f9f50da6a8b8a2
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Please drop the Change-Id before merging this.
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> index c6d5785..b5cf468 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> @@ -28,7 +28,6 @@
>
> #include <drm/drmP.h>
> #include <drm/drm_atomic.h>
> -#include "dc.h"
>
> /*
> * This file contains the definition for amdgpu_display_manager
> @@ -53,6 +52,7 @@
> struct amdgpu_device;
> struct drm_device;
> struct amdgpu_dm_irq_handler_data;
> +struct dc;
>
> struct amdgpu_dm_prev_state {
> struct drm_framebuffer *fb;
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> index f6cb502..ef5fad8 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> @@ -25,6 +25,7 @@
>
> #include "amdgpu_mode.h"
> #include "amdgpu_dm.h"
> +#include "dc.h"
> #include "modules/color/color_gamma.h"
>
> #define MAX_DRM_LUT_VALUE 0xFFFF
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-03-29 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 7:44 [PATCH] drm/amd/dc: Disentangle dc.h include from amdgpu.h Rex Zhu
[not found] ` <1522309467-10887-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2018-03-29 15:09 ` Harry Wentland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4604a26-4e9e-8e5e-7680-d99fc7cc4e0b@amd.com \
--to=harry.wentland-5c7gfcevmho@public.gmane.org \
--cc=Rex.Zhu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox