Re: [PATCH 3/3] drm/amdgpu: Describe preemptible objects in debugfs

["Christian König" <ckoenig.leichtzumerken@gmail.com>]

Am 29.04.24 um 18:47 schrieb Tvrtko Ursulin:
> From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
>
> Instead of mixing them together with regular system memory objects mark
> them explicitly as 'PREEMPTIBLE'.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Felix Kuehling <felix.kuehling@amd.com>
> ---
> No idea on the name to use.. :)
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index eb5bd6962560..be6c2f5b9fcb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -1599,6 +1599,9 @@ u64 amdgpu_bo_print_info(int id, struct amdgpu_bo *bo, struct seq_file *m)
>   		case TTM_PL_TT:
>   			placement = "GTT";
>   			break;
> +		case AMDGPU_PL_PREEMPT:
> +			placement = "PREEMPTIBLE";
> +			break;

While at it please ass cases for OA, GWS and GDS as well.

With that done the patch is Reviewed-by: Christian König 
<christian.koenig@amd.com>

Thanks,
Christian.

>   		case TTM_PL_SYSTEM:
>   		default:
>   			placement = "CPU";