From: "Christian König" <christian.koenig@amd.com>
To: Sunil Khatri <sunil.khatri@amd.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4 00/15] validate/clean the functions of ip funcs
Date: Thu, 17 Oct 2024 14:23:00 +0200 [thread overview]
Message-ID: <f4aa8b1e-7ba9-4e10-bb71-71871c2cb920@amd.com> (raw)
In-Reply-To: <20241017100615.1492144-1-sunil.khatri@amd.com>
Patches #1-#4, #8-#10,#13 are Reviewed-by: Christian König
<christian.koenig@amd.com>
Since those patches should be independent maybe push them to
amd-staging-drm-next before continuing working on the set.
Regards,
Christian.
Am 17.10.24 um 12:06 schrieb Sunil Khatri:
> v4: hw_init/hw_fini functions are mandatory and raise error message if
> these functions are not defined.
>
> v3: Added 2 new patches to clean get_clocking_state and hw_init
> validation.
>
> Sunil Khatri (15):
> drm/amdgpu: validate sw_init before function call
> drm/amdgpu: clean the dummy sw_init functions
> drm/amdgpu: validate sw_fini before function call
> drm/amdgpu: clean the dummy sw_fini functions
> drm/amdgpu: validate hw_fini before function call
> drm/amdgpu: validate suspend before function call
> drm/amdgpu: validate resume before function call
> drm/amdgpu: validate wait_for_idle before function call
> drm/amdgpu: clean the dummy resume functions
> drm/amdgpu: clean the dummy suspend functions
> drm/amdgpu: clean the dummy hw_fini functions
> drm/amdgpu: clean the dummy wait_for_idle functions
> drm/amdgpu: clean the dummy soft_reset functions
> drm/amdgpu: clean unused functions of amd_ip_funcs
> drm/amdgpu: validate get_clockgating_state before use
>
> drivers/gpu/drm/amd/amdgpu/aldebaran.c | 38 ++-
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 16 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 138 +++++----
> drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 35 ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 12 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 2 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 25 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 2 -
> drivers/gpu/drm/amd/amdgpu/cik.c | 33 +-
> drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 -
> drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 3 -
> drivers/gpu/drm/amd/amdgpu/cz_ih.c | 3 -
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 9 -
> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 9 -
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 9 -
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 9 -
> drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 9 -
> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 -
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 -
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 6 -
> drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 6 -
> drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 6 -
> drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 2 -
> drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 -
> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 -
> drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 3 -
> drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 3 -
> drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 3 -
> drivers/gpu/drm/amd/amdgpu/ih_v7_0.c | 3 -
> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 7 -
> drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 14 -
> drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 7 -
> drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 7 -
> drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 7 -
> drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 7 -
> drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c | 7 -
> drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 -
> drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 11 +-
> drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 3 -
> drivers/gpu/drm/amd/amdgpu/nv.c | 29 +-
> drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 3 -
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 3 -
> drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 1 -
> drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 1 -
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 1 -
> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 1 -
> drivers/gpu/drm/amd/amdgpu/si.c | 40 ---
> drivers/gpu/drm/amd/amdgpu/si_dma.c | 3 -
> drivers/gpu/drm/amd/amdgpu/si_ih.c | 3 -
> drivers/gpu/drm/amd/amdgpu/sienna_cichlid.c | 43 +--
> drivers/gpu/drm/amd/amdgpu/smu_v13_0_10.c | 29 +-
> drivers/gpu/drm/amd/amdgpu/soc15.c | 14 -
> drivers/gpu/drm/amd/amdgpu/soc21.c | 26 +-
> drivers/gpu/drm/amd/amdgpu/soc24.c | 24 +-
> drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 -
> drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 3 -
> drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 3 -
> drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 3 -
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 3 -
> drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 284 ------------------
> drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 3 -
> drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 -
> drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 275 -----------------
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 -
> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 5 -
> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 10 -
> drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 5 -
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 5 -
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 5 -
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 5 -
> drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 5 -
> drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 1 -
> drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 1 -
> drivers/gpu/drm/amd/amdgpu/vi.c | 20 --
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -
> drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 15 -
> drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 8 -
> .../gpu/drm/amd/pm/powerplay/amd_powerplay.c | 14 -
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 4 -
> 80 files changed, 171 insertions(+), 1208 deletions(-)
>
next prev parent reply other threads:[~2024-10-17 12:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 10:06 [PATCH v4 00/15] validate/clean the functions of ip funcs Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 01/15] drm/amdgpu: validate sw_init before function call Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 02/15] drm/amdgpu: clean the dummy sw_init functions Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 03/15] drm/amdgpu: validate sw_fini before function call Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 04/15] drm/amdgpu: clean the dummy sw_fini functions Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 05/15] drm/amdgpu: validate hw_fini before function call Sunil Khatri
2024-10-17 11:52 ` Christian König
2024-10-17 12:44 ` Khatri, Sunil
2024-10-17 10:06 ` [PATCH v4 06/15] drm/amdgpu: validate suspend " Sunil Khatri
2024-10-17 11:54 ` Christian König
2024-10-17 12:45 ` Khatri, Sunil
2024-10-17 10:06 ` [PATCH v4 07/15] drm/amdgpu: validate resume " Sunil Khatri
2024-10-17 11:55 ` Christian König
2024-10-17 12:46 ` Khatri, Sunil
2024-10-17 10:06 ` [PATCH v4 08/15] drm/amdgpu: validate wait_for_idle " Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 09/15] drm/amdgpu: clean the dummy resume functions Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 10/15] drm/amdgpu: clean the dummy suspend functions Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 11/15] drm/amdgpu: clean the dummy hw_fini functions Sunil Khatri
2024-10-17 11:58 ` Christian König
2024-10-17 12:47 ` Khatri, Sunil
2024-10-17 10:06 ` [PATCH v4 12/15] drm/amdgpu: clean the dummy wait_for_idle functions Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 13/15] drm/amdgpu: clean the dummy soft_reset functions Sunil Khatri
2024-10-17 10:06 ` [PATCH v4 14/15] drm/amdgpu: clean unused functions of amd_ip_funcs Sunil Khatri
2024-10-17 12:18 ` Christian König
2024-10-17 12:49 ` Khatri, Sunil
2024-10-17 10:06 ` [PATCH v4 15/15] drm/amdgpu: validate get_clockgating_state before use Sunil Khatri
2024-10-17 12:20 ` Christian König
2024-10-17 12:55 ` Khatri, Sunil
2024-10-17 13:15 ` Christian König
2024-10-17 12:23 ` Christian König [this message]
2024-10-17 12:57 ` [PATCH v4 00/15] validate/clean the functions of ip funcs Khatri, Sunil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4aa8b1e-7ba9-4e10-bb71-71871c2cb920@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=sunil.khatri@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox