From: Leo Li <sunpeng.li@amd.com>
To: Melissa Wen <mwen@igalia.com>,
harry.wentland@amd.com, Rodrigo.Siqueira@amd.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-dev@igalia.com
Subject: Re: [PATCH] drm/amd/display: add missing tracepoint event in DM atomic_commit_tail
Date: Wed, 23 Oct 2024 11:42:31 -0400 [thread overview]
Message-ID: <f50b88a4-bfeb-493b-8de5-5102b2fd02de@amd.com> (raw)
In-Reply-To: <20241023135321.259494-1-mwen@igalia.com>
On 2024-10-23 09:53, Melissa Wen wrote:
> There are two events to trace the beginning and the end of
> amdgpu_dm_atomic_commit_tail, but only the one ate the beginning was
> placed. Place amdgpu_dm_atomic_commit_tail_finish tracepoint at the end
> than.
>
> Signed-off-by: Melissa Wen <mwen@igalia.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
Thanks!
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 98f0b142f497..bbfc47f6595f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -10088,6 +10088,8 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)
> for (i = 0; i < crtc_disable_count; i++)
> pm_runtime_put_autosuspend(dev->dev);
> pm_runtime_mark_last_busy(dev->dev);
> +
> + trace_amdgpu_dm_atomic_commit_tail_finish(state);
> }
>
> static int dm_force_atomic_commit(struct drm_connector *connector)
prev parent reply other threads:[~2024-10-23 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 13:53 [PATCH] drm/amd/display: add missing tracepoint event in DM atomic_commit_tail Melissa Wen
2024-10-23 15:42 ` Leo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f50b88a4-bfeb-493b-8de5-5102b2fd02de@amd.com \
--to=sunpeng.li@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=kernel-dev@igalia.com \
--cc=mwen@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox