From: Harry Wentland <harry.wentland@amd.com>
To: Shirish S <shirish.s@amd.com>, Leo Li <sunpeng.li@amd.com>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: fix crash/reboot while accessing sysfs files
Date: Fri, 18 Sep 2020 11:41:33 -0400 [thread overview]
Message-ID: <f8869c01-c073-ceec-cf0e-eea6eb7fd108@amd.com> (raw)
In-Reply-To: <20200917085418.64517-1-shirish.s@amd.com>
On 2020-09-17 4:54 a.m., Shirish S wrote:
> read/writes to aux_dpcd_* sysfs entries leads to system
> reboot or hang.
> Hence fix the handling of input data and reporting of errors
> appropriately to the user space.
>
> Signed-off-by: Shirish S <shirish.s@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 004cd8d38214..8cd646eef096 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -908,7 +908,7 @@ static ssize_t dp_dpcd_address_write(struct file *f, const char __user *buf,
> struct amdgpu_dm_connector *connector = file_inode(f)->i_private;
>
> if (size < sizeof(connector->debugfs_dpcd_address))
> - return 0;
> + return -EINVAL;
>
> r = copy_from_user(&connector->debugfs_dpcd_address,
> buf, sizeof(connector->debugfs_dpcd_address));
> @@ -923,7 +923,7 @@ static ssize_t dp_dpcd_size_write(struct file *f, const char __user *buf,
> struct amdgpu_dm_connector *connector = file_inode(f)->i_private;
>
> if (size < sizeof(connector->debugfs_dpcd_size))
> - return 0;
> + return -EINVAL;
>
> r = copy_from_user(&connector->debugfs_dpcd_size,
> buf, sizeof(connector->debugfs_dpcd_size));
> @@ -943,8 +943,8 @@ static ssize_t dp_dpcd_data_write(struct file *f, const char __user *buf,
> struct dc_link *link = connector->dc_link;
> uint32_t write_size = connector->debugfs_dpcd_size;
>
> - if (size < write_size)
> - return 0;
> + if (!write_size || size < write_size)
> + return -EINVAL;
>
> data = kzalloc(write_size, GFP_KERNEL);
> if (!data)
> @@ -967,7 +967,7 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,
> struct dc_link *link = connector->dc_link;
> uint32_t read_size = connector->debugfs_dpcd_size;
>
> - if (size < read_size)
> + if (!read_size || size < read_size)
> return 0;
>
> data = kzalloc(read_size, GFP_KERNEL);
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-09-18 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 8:54 [PATCH] drm/amd/display: fix crash/reboot while accessing sysfs files Shirish S
2020-09-18 15:41 ` Harry Wentland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8869c01-c073-ceec-cf0e-eea6eb7fd108@amd.com \
--to=harry.wentland@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=shirish.s@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox