From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salyzyn Subject: Re: [PATCH] Cleanup: replace prefered with preferred Date: Wed, 23 Oct 2019 08:40:59 -0700 Message-ID: References: <20191022214208.211448-1-salyzyn@android.com> <20191023115637.GA23733@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191023115637.GA23733@linux.intel.com> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, "David S. Miller" , Jonathan Corbet , Ard Biesheuvel , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , VMware Graphics , Thomas Hellstrom , Laurent Pinchart , Mauro Carvalho Chehab , Trond Myklebust , Anna Schumaker , Alexander List-Id: amd-gfx.lists.freedesktop.org On 10/23/19 4:56 AM, Jarkko Sakkinen wrote: > On Tue, Oct 22, 2019 at 02:41:45PM -0700, Mark Salyzyn wrote: >> Replace all occurrences of prefered with preferred to make future >> checkpatch.pl's happy. A few places the incorrect spelling is >> matched with the correct spelling to preserve existing user space API. >> >> Signed-off-by: Mark Salyzyn > I'd fix such things when the code is otherwise change and scope this > patch only to Documentation/. There is no pragmatic benefit of doing > this for the code. > > /Jarkko The pragmatic benefit comes with the use of an ABI/API checker (which is a 'distro' thing, not a top of tree kernel thing) produces its map which is typically required to be co-located in the same tree as the kernel repository. Quite a few ABI/API update checkins result in a checkpatch.pl complaint about the misspelled elements being (re-)recorded due to proximity. We have a separate task to improve how it is tracked in Android to reduce milepost marker changes that result in sweeping changes to the database which would reduce the occurrences. I will split this between pure and inert documentation/comments for now, with a followup later for the code portion which understandably is more controversial. Cleanup is the least appreciated part of kernel maintenance ;-}. Sincerely -- Mark Salyzyn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B5FCA9EAF for ; Thu, 24 Oct 2019 07:31:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B54520856 for ; Thu, 24 Oct 2019 07:31:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B54520856 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=android.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 489BD6E115; Thu, 24 Oct 2019 07:31:14 +0000 (UTC) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 382FB6EB1A for ; Wed, 23 Oct 2019 15:41:02 +0000 (UTC) Received: by mail-pg1-x541.google.com with SMTP id r1so12359190pgj.12 for ; Wed, 23 Oct 2019 08:41:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=TI9rW32nt+i6GyURUSN10bGjthP0EG+xScjnb+pkqac=; b=GaBQNR7dj8JujQ/DO+RuAaLyCtZ0CGzNtwWOTiiy+YMPiKO1Ish6HWQYBM+d1bv0Bc KogZENeoCz0J4Iinyas849cpRczgFpWwdRCOPFg72OiNbuSQGXheC8hHVbcKoLMI5hsf NNjL7C6QjMIFm7CfqaYaR1RZ8BhJ26FkV9o4zywD9qqGm2HYW0rAJFXJmC+UYbAgqoYt 73FenOjOS45sNjGVX+zGkM4NxwImTYx2338SN+CPCU1iCk40yP+bjblcl/VodaYuTbu5 4w91QSuhX42Hhl9YVCmuDta0jdnI3Emjj3Qi/FsMgLGYQsPcOk4Q4vyn5fL8hVP00iAj rz7A== X-Gm-Message-State: APjAAAX+Wn+jucFS2atbBg6PMCGWvo6XYgZBh6feHoy6rzGECzu6xceg oEQ5NMpLuz+HRuSWT2vuLMUVaw== X-Google-Smtp-Source: APXvYqxpUg0BJf6IgZEek+Avbtx6SaPZVRb4CoPCBRhASaoQxSh7v/tZYoAbFxDTBg5wYPAauGUeIw== X-Received: by 2002:a17:90a:e987:: with SMTP id v7mr765373pjy.86.1571845261541; Wed, 23 Oct 2019 08:41:01 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id r18sm28682272pfc.3.2019.10.23.08.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Oct 2019 08:41:01 -0700 (PDT) Subject: Re: [PATCH] Cleanup: replace prefered with preferred To: Jarkko Sakkinen References: <20191022214208.211448-1-salyzyn@android.com> <20191023115637.GA23733@linux.intel.com> From: Mark Salyzyn Message-ID: Date: Wed, 23 Oct 2019 08:40:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191023115637.GA23733@linux.intel.com> Content-Language: en-GB X-Mailman-Approved-At: Thu, 24 Oct 2019 07:31:04 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=TI9rW32nt+i6GyURUSN10bGjthP0EG+xScjnb+pkqac=; b=KBoKx5yOJdWGZz7I1M810keaJ1ZlEuvnt+HTZJAS0UmK0LTUpPmdFTkklfgcGdi73r feMTzV569J5UceysOEInvWeJdRd/ZzonW6Aa3VYlqczCqXy+PY9ipoJvzLD+NWbnZ5rP mW2vwJLR0Vq7sY9XP/QBVZSb/GxJx9fS5CE5Yo07sdXhMNQdYvScXxROVKhe4Esy5Cvd e50H85g6521yumbQVB+PGX8SW/L7QzMUvgyanXK1Toe52me2wt2CIUN9qyd4f938PFQ7 rthEsivMBKI4ftQ33yVLiM1NHSBLjKlHtZVEVP38OG7iyjy4z/skVUexYga7/45kjz+T 6+ug== X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Aring , linux-efi@vger.kernel.org, =?UTF-8?Q?Linus_L=c3=bcssing?= , Greg Kroah-Hartman , David Airlie , Feng Tang , dri-devel@lists.freedesktop.org, Roman Li , "David S. Miller" , Laurent Pinchart , netdev@vger.kernel.org, Ingo Molnar , Rafael Aquini , "David \(ChunMing\) Zhou" , Thomas Hellstrom , Jonathan Corbet , Francesco Ruggeri , Matthew Garrett , amd-gfx@lists.freedesktop.org, VMware Graphics , Alexey Kuznetsov , kernel-team@android.com, linux-media@vger.kernel.org, Leo Li , "Steven Rostedt \(VMware\)" , Hans de Goede , hersen wu , Mauro Carvalho Chehab , Trond Myklebust , linux-nfs@vger.kernel.org, Andrew Morton , Ard Biesheuvel , Hideaki YOSHIFUJI , Harry Wentland , Maxim Martynov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Anna Schumaker , linux-bluetooth@vger.kernel.org, Daniel Vetter , David Ahern , Alex Deucher , Jukka Rissanen , linux-wpan@vger.kernel.org, =?UTF-8?Q?Christian_K=c3=b6nig?= Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191023154059.ukba-vZZ_cidG0WwP7nTEk4xAFvI9wvK3MTitnU-6KQ@z> T24gMTAvMjMvMTkgNDo1NiBBTSwgSmFya2tvIFNha2tpbmVuIHdyb3RlOgo+IE9uIFR1ZSwgT2N0 IDIyLCAyMDE5IGF0IDAyOjQxOjQ1UE0gLTA3MDAsIE1hcmsgU2FseXp5biB3cm90ZToKPj4gUmVw bGFjZSBhbGwgb2NjdXJyZW5jZXMgb2YgcHJlZmVyZWQgd2l0aCBwcmVmZXJyZWQgdG8gbWFrZSBm dXR1cmUKPj4gY2hlY2twYXRjaC5wbCdzIGhhcHB5LiAgQSBmZXcgcGxhY2VzIHRoZSBpbmNvcnJl Y3Qgc3BlbGxpbmcgaXMKPj4gbWF0Y2hlZCB3aXRoIHRoZSBjb3JyZWN0IHNwZWxsaW5nIHRvIHBy ZXNlcnZlIGV4aXN0aW5nIHVzZXIgc3BhY2UgQVBJLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYXJr IFNhbHl6eW4gPHNhbHl6eW5AYW5kcm9pZC5jb20+Cj4gSSdkIGZpeCBzdWNoIHRoaW5ncyB3aGVu IHRoZSBjb2RlIGlzIG90aGVyd2lzZSBjaGFuZ2UgYW5kIHNjb3BlIHRoaXMKPiBwYXRjaCBvbmx5 IHRvIERvY3VtZW50YXRpb24vLiBUaGVyZSBpcyBubyBwcmFnbWF0aWMgYmVuZWZpdCBvZiBkb2lu Zwo+IHRoaXMgZm9yIHRoZSBjb2RlLgo+Cj4gL0phcmtrbwoKVGhlIHByYWdtYXRpYyBiZW5lZml0 IGNvbWVzIHdpdGggdGhlIHVzZSBvZiBhbiBBQkkvQVBJIGNoZWNrZXIgKHdoaWNoIGlzIAphICdk aXN0cm8nIHRoaW5nLCBub3QgYSB0b3Agb2YgdHJlZSBrZXJuZWwgdGhpbmcpIHByb2R1Y2VzIGl0 cyBtYXAgd2hpY2ggCmlzIHR5cGljYWxseSByZXF1aXJlZCB0byBiZSBjby1sb2NhdGVkIGluIHRo ZSBzYW1lIHRyZWUgYXMgdGhlIGtlcm5lbCAKcmVwb3NpdG9yeS4gUXVpdGUgYSBmZXcgQUJJL0FQ SSB1cGRhdGUgY2hlY2tpbnMgcmVzdWx0IGluIGEgCmNoZWNrcGF0Y2gucGwgY29tcGxhaW50IGFi b3V0IHRoZSBtaXNzcGVsbGVkIGVsZW1lbnRzIGJlaW5nIAoocmUtKXJlY29yZGVkIGR1ZSB0byBw cm94aW1pdHkuIFdlIGhhdmUgYSBzZXBhcmF0ZSB0YXNrIHRvIGltcHJvdmUgaG93IAppdCBpcyB0 cmFja2VkIGluIEFuZHJvaWQgdG8gcmVkdWNlIG1pbGVwb3N0IG1hcmtlciBjaGFuZ2VzIHRoYXQg cmVzdWx0IAppbiBzd2VlcGluZyBjaGFuZ2VzIHRvIHRoZSBkYXRhYmFzZSB3aGljaCB3b3VsZCBy ZWR1Y2UgdGhlIG9jY3VycmVuY2VzLgoKSSB3aWxsIHNwbGl0IHRoaXMgYmV0d2VlbiBwdXJlIGFu ZCBpbmVydCBkb2N1bWVudGF0aW9uL2NvbW1lbnRzIGZvciBub3csIAp3aXRoIGEgZm9sbG93dXAg bGF0ZXIgZm9yIHRoZSBjb2RlIHBvcnRpb24gd2hpY2ggdW5kZXJzdGFuZGFibHkgaXMgbW9yZSAK Y29udHJvdmVyc2lhbC4KCkNsZWFudXAgaXMgdGhlIGxlYXN0IGFwcHJlY2lhdGVkIHBhcnQgb2Yg a2VybmVsIG1haW50ZW5hbmNlIDstfS4KClNpbmNlcmVseSAtLSBNYXJrIFNhbHl6eW4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==