AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: ruanjinjie <ruanjinjie@huawei.com>,
	sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
	jiapeng.chong@linux.alibaba.com, aurabindo.pillai@amd.com,
	isabbasso@riseup.net, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static
Date: Wed, 19 Oct 2022 09:27:18 -0400	[thread overview]
Message-ID: <faaae681-65b7-0cc5-d413-b8995978d2c5@amd.com> (raw)
In-Reply-To: <20221019063115.3757510-1-ruanjinjie@huawei.com>



On 2022-10-19 02:31, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28:
> warning: symbol 'dcn32_mmhubbub_funcs' was
> not declared. Should it be static?
> 
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> index 41b0baf8e183..c3b089ba511a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb,
>  	REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE,  params->arbitration_slice);
>  }
>  
> -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
>  	.warmup_mcif		= mmhubbub32_warmup_mcif,
>  	.enable_mcif		= mmhubbub2_enable_mcif,
>  	.disable_mcif		= mmhubbub2_disable_mcif,


  reply	other threads:[~2022-10-19 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19  6:31 [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static ruanjinjie
2022-10-19 13:27 ` Harry Wentland [this message]
2022-10-20 13:11   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=faaae681-65b7-0cc5-d413-b8995978d2c5@amd.com \
    --to=harry.wentland@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=isabbasso@riseup.net \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox