From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/7] drm/amdgpu: fix VM PD addr shift Date: Mon, 27 Nov 2017 18:12:01 +0100 Message-ID: References: <20171127160217.4010-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, "Deucher, Alexander" QW0gMjcuMTEuMjAxNyB1bSAxNzo0MCBzY2hyaWViIEZlbGl4IEt1ZWhsaW5nOgo+IE9uIDIwMTct MTEtMjcgMTE6MDIgQU0sIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4+IFRoZSBibG9jayBzaXpl IG9ubHkgYWZmZWN0cyB0aGUgbGVhdmUgbm9kZXMsIGV2ZXJ5dGhpbmcgZWxzZSBpcyBmaXhlZC4K Pj4KPj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0Bh bWQuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0u YyB8IDI4ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwg MjMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3ZtLmMKPj4gaW5kZXggMTIyMzc5ZGZjN2Q4Li5mMWU1NDFlOWI1MTQgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4+IEBAIC0xMzksNiAr MTM5LDI0IEBAIHN0cnVjdCBhbWRncHVfcHJ0X2NiIHsKPj4gICB9Owo+PiAgIAo+PiAgIC8qKgo+ PiArICogYW1kZ3B1X3ZtX2xldmVsX3NoaWZ0IC0gcmV0dXJuIHRoZSBhZGRyIHNoaWZ0IGZvciBl YWNoIGxldmVsCj4+ICsgKgo+PiArICogQGFkZXY6IGFtZGdwdV9kZXZpY2UgcG9pbnRlcgo+PiAr ICoKPj4gKyAqIFJldHVybnMgdGhlIG51bWJlciBvZiBiaXRzIHRoZSBwZm4gbmVlZHMgdG8gYmUg cmlnaHQgc2hpZnRlZCBmb3IgYSBsZXZlbC4KPj4gKyAqLwo+PiArc3RhdGljIHVuc2lnbmVkIGFt ZGdwdV92bV9sZXZlbF9zaGlmdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPj4gKwkJCQkg ICAgICB1bnNpZ25lZCBsZXZlbCkKPj4gK3sKPj4gKwlpZiAobGV2ZWwgIT0gYWRldi0+dm1fbWFu YWdlci5udW1fbGV2ZWwpCj4+ICsJCXJldHVybiA5ICogKGFkZXYtPnZtX21hbmFnZXIubnVtX2xl dmVsIC0gbGV2ZWwgLSAxKSArCj4+ICsJCQlhZGV2LT52bV9tYW5hZ2VyLmJsb2NrX3NpemU7Cj4+ ICsJZWxzZQo+PiArCQkvKiBGb3IgdGhlIHBhZ2UgdGFibGVzIG9uIHRoZSBsZWF2ZXMgKi8KPj4g KwkJcmV0dXJuIDA7Cj4+ICt9Cj4+ICsKPj4gKy8qKgo+PiAgICAqIGFtZGdwdV92bV9udW1fZW50 cmllcyAtIHJldHVybiB0aGUgbnVtYmVyIG9mIGVudHJpZXMgaW4gYSBQRC9QVAo+PiAgICAqCj4+ ICAgICogQGFkZXY6IGFtZGdwdV9kZXZpY2UgcG9pbnRlcgo+PiBAQCAtMjg4LDggKzMwNiw3IEBA IHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq YWRldiwKPj4gICAJCQkJICB1aW50NjRfdCBzYWRkciwgdWludDY0X3QgZWFkZHIsCj4+ICAgCQkJ CSAgdW5zaWduZWQgbGV2ZWwpCj4+ICAgewo+PiAtCXVuc2lnbmVkIHNoaWZ0ID0gKGFkZXYtPnZt X21hbmFnZXIubnVtX2xldmVsIC0gbGV2ZWwpICoKPj4gLQkJYWRldi0+dm1fbWFuYWdlci5ibG9j a19zaXplOwo+PiArCXVuc2lnbmVkIHNoaWZ0ID0gYW1kZ3B1X3ZtX2xldmVsX3NoaWZ0KGFkZXYs IGxldmVsKTsKPj4gICAJdW5zaWduZWQgcHRfaWR4LCBmcm9tLCB0bzsKPj4gICAJaW50IHI7Cj4+ ICAgCXU2NCBmbGFnczsKPj4gQEAgLTEzMDIsMTggKzEzMTksMTkgQEAgdm9pZCBhbWRncHVfdm1f Z2V0X2VudHJ5KHN0cnVjdCBhbWRncHVfcHRlX3VwZGF0ZV9wYXJhbXMgKnAsIHVpbnQ2NF90IGFk ZHIsCj4+ICAgCQkJIHN0cnVjdCBhbWRncHVfdm1fcHQgKiplbnRyeSwKPj4gICAJCQkgc3RydWN0 IGFtZGdwdV92bV9wdCAqKnBhcmVudCkKPj4gICB7Cj4+IC0JdW5zaWduZWQgaWR4LCBsZXZlbCA9 IHAtPmFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsOwo+PiArCXVuc2lnbmVkIGxldmVsID0gMDsK PiBUaGlzIGdlbmVyYXRlcyBhIGNoZWNrcGF0Y2gucGwgd2FybmluZy4KPgo+IEdlbmVyYWwgcXVl c3Rpb246IERvIHlvdSBoYXZlIGEgcG9saWN5IGZvciBydW5uaW5nIHlvdXIgcGF0Y2hlcyB0aHJv dWdoCj4gY2hlY2twYXRjaC5wbCBiZWZvcmUvZHVyaW5nL2FmdGVyIGNvZGUgcmV2aWV3PwoKTm8s IEknbSB1c2luZyBlZGl0b3Igc2V0dGluZ3Mgd2hpY2ggZ2VuZXJhdGUgY29kaW5nIHN0eWxlIGNv bXBsaWFudCBjb2RlIAptb3N0IG9mIHRoZSB0aW1lIGFuZCBjb21wbGFpbnMvc2hvd3Mgd2hlbiBp dCBpc24ndCBjb21wbGlhbnQuCgo+IEkndmUgbm90aWNlZCBiZWZvcmUgdGhhdCBzb21lIG9mIHlv dXIgcGF0Y2hlcyBhcmVuJ3QgYWx3YXlzIDEwMCUgY29tcGxpYW50LgoKWWVhaCwgYW1kZ3B1IGlu aGVyaXRlZCBhIGxvdCBvZiBjb2RlIGFzIHdlbGwgYXMgY29kaW5nIHN0eWxlIGZyb20gcmFkZW9u IAp3aGljaCBpc24ndCBjb21wbGlhbnQuCgpGb3IgZXhhbXBsZSBpbiB0aGlzIGNhc2UgY2hlY2tw YXRjaC5wbCBtb3N0IGxpa2VseSBjb21wbGFpbnMgdGhhdCB3ZSAKc2hvdWxkIHVzZSAidW5zaWdu ZWQgaW50IiBpbnN0ZWFkIG9mIGp1c3QgInVuc2lnbmVkIi4KCkkndmUgdHJpZWQgdG8gY2xlYW4g dGhpcyB1cCBmb3IgeWVhcnMsIGJ1dCBzaW1wbHkgbm90IGVub3VnaCB0aW1lIHRvIApoYW5kbGUg ZXZlcnl0aGluZy4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiBSZWdhcmRzLAo+ICDCoCBGZWxp eAo+Cj4+ICAgCj4+ICAgCSpwYXJlbnQgPSBOVUxMOwo+PiAgIAkqZW50cnkgPSAmcC0+dm0tPnJv b3Q7Cj4+ICAgCXdoaWxlICgoKmVudHJ5KS0+ZW50cmllcykgewo+PiAtCQlpZHggPSBhZGRyID4+ IChwLT5hZGV2LT52bV9tYW5hZ2VyLmJsb2NrX3NpemUgKiBsZXZlbC0tKTsKPj4gKwkJdW5zaWdu ZWQgaWR4ID0gYWRkciA+PiBhbWRncHVfdm1fbGV2ZWxfc2hpZnQocC0+YWRldiwgbGV2ZWwrKyk7 Cj4+ICsKPj4gICAJCWlkeCAlPSBhbWRncHVfYm9fc2l6ZSgoKmVudHJ5KS0+YmFzZS5ibykgLyA4 Owo+PiAgIAkJKnBhcmVudCA9ICplbnRyeTsKPj4gICAJCSplbnRyeSA9ICYoKmVudHJ5KS0+ZW50 cmllc1tpZHhdOwo+PiAgIAl9Cj4+ICAgCj4+IC0JaWYgKGxldmVsKQo+PiArCWlmIChsZXZlbCAh PSBwLT5hZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZlbCkKPj4gICAJCSplbnRyeSA9IE5VTEw7Cj4+ ICAgfQo+PiAgIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==