Re: [PATCH 2/2] drm/amdgpu: Fix implicit assumtion in gfx11 debug flags

[Felix Kuehling <felix.kuehling@amd.com>]

On 2024-02-09 20:49, Rajneesh Bhardwaj wrote:
> Gfx11 debug flags mask is currently set with an implicit assumption that
> no other mqd update flags exist. This needs to be fixed with newly
> introduced flag UPDATE_FLAG_IS_GWS by the previous patch.
>
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>

Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c
> index d722cbd31783..826bc4f6c8a7 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c
> @@ -55,8 +55,8 @@ static void update_cu_mask(struct mqd_manager *mm, void *mqd,
>   	m = get_mqd(mqd);
>   
>   	if (has_wa_flag) {
> -		uint32_t wa_mask = minfo->update_flag == UPDATE_FLAG_DBG_WA_ENABLE ?
> -						0xffff : 0xffffffff;
> +		uint32_t wa_mask =
> +			(minfo->update_flag & UPDATE_FLAG_DBG_WA_ENABLE) ? 0xffff : 0xffffffff;
>   
>   		m->compute_static_thread_mgmt_se0 = wa_mask;
>   		m->compute_static_thread_mgmt_se1 = wa_mask;