From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang, JinHuiEric" Subject: Re: [PATCH] drm/amdkfd: fix a compiling error when CONFIG_HSA_AMD disalbed Date: Wed, 6 Mar 2019 16:41:23 +0000 Message-ID: References: <1551887958-3657-1-git-send-email-JinhuiEric.Huang@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1393888702==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" --===============1393888702== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_fd52cc698d17d4b407aae584485a6d7famdcom_" --_000_fd52cc698d17d4b407aae584485a6d7famdcom_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Oops. I submitted it moments ago. Thanks for your catch anyway. Eric On 2019-03-06 11:34 a.m., William Lewis wrote: Typo in patch description: s/disalbed/disabled/ On 3/6/19 10:11 AM, Deucher, Alexander wrote: Add a line like: Fixes: 9032ea09e2d2ef ("drm/amdkfd: add RAS ECC event support") With that added: Reviewed-by: Alex Deucher ________________________________ From: amd-gfx on behalf of Huang, JinHuiEric Sent: Wednesday, March 6, 2019 10:59 AM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Huang, JinHuiEric Subject: [PATCH] drm/amdkfd: fix a compiling error when CONFIG_HSA_AMD disa= lbed It fixes a commpiling error on commit 9032ea09e2d2ef0d10e5cd793713bf2eb21643c5 drm/amdkfd: add RAS ECC event support Change-Id: I8792767726e28eed3a3fcf9072f608701be13c79 Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_amdkfd.c index fe1d736..acf8ae0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c @@ -640,4 +640,8 @@ int kgd2kfd_post_reset(struct kfd_dev *kfd) void kgd2kfd_interrupt(struct kfd_dev *kfd, const void *ih_ring_entry) { } + +void kgd2kfd_set_sram_ecc_flag(struct kfd_dev *kfd) +{ +} #endif -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://nam02.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists.f= reedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=3D02%7C01%7C%7C2cf93= d5576b848c6d66708d6a24e5eb2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C63= 6874854807293349&sdata=3D7nutYNQv0XODz%2BUzQTTbIrahZI%2B6%2BG9cETOEkBnU= AU4%3D&reserved=3D0 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --_000_fd52cc698d17d4b407aae584485a6d7famdcom_ Content-Type: text/html; charset="Windows-1252" Content-ID: <8C817A0D2387BD4090B928851883E129-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> Content-Transfer-Encoding: quoted-printable

Oops. I submitted it moments ago. Thanks for your catch anyway.


Eric


On 2019-03-06 11:34 a.m., William Lewis wrot= e:

Typo in patch description:  s/disalbed/disabled/


On 3/6/19 10:11 AM, Deucher, Alexander wrote= :
Add a line like:

Fixes: 9032ea09e2d2ef ("drm/amdkfd: add RAS ECC event support= ")

With that added:


From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Huang, JinHu= iEric <JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org>
Sent: Wednesday, March 6, 2019 10:59 AM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Huang, JinHuiEric
Subject: [PATCH] drm/amdkfd: fix a compiling error when CONFIG_HSA_A= MD disalbed
 
It fixes a commpiling error on commit
9032ea09e2d2ef0d10e5cd793713bf2eb21643c5
drm/amdkfd: add RAS ECC event support

Change-Id: I8792767726e28eed3a3fcf9072f608701be13c79
Signed-off-by: Eric Huang <JinhuiEric.Huang-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 4 ++++  1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_amdkfd.c
index fe1d736..acf8ae0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -640,4 +640,8 @@ int kgd2kfd_post_reset(struct kfd_dev *kfd)
 void kgd2kfd_interrupt(struct kfd_dev *kfd, const void *ih_ring_entry= )
 {
 }
+
+void kgd2kfd_set_sram_ecc_flag(struct kfd_dev *kfd)
+{
+}
 #endif
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx=

____________________________________=
___________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://nam02.safelinks.protection.outlook.c=
om/?url=3Dhttps%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gf=
x&amp;data=3D02%7C01%7C%7C2cf93d5576b848c6d66708d6a24e5eb2%7C84df9e7fe9=
f640afb435aaaaaaaaaaaa%7C1%7C0%7C636874854807293349&amp;sdata=3D7nutYNQ=
v0XODz%2BUzQTTbIrahZI%2B6%2BG9cETOEkBnUAU4%3D&amp;reserved=3D0

____________________________________=
___________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-=
gfx
--_000_fd52cc698d17d4b407aae584485a6d7famdcom_-- --===============1393888702== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 --===============1393888702==--