From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: ray.huang@amd.com, bp@alien8.de, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
Date: Thu, 7 Jan 2021 21:08:29 +0100 [thread overview]
Message-ID: <ffa9d7f2-fe68-fb6a-8422-82b8949dbe1e@gmail.com> (raw)
In-Reply-To: <X/dN/YFtnVAIllds@phenom.ffwll.local>
Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>> Drivers are not supposed to init the page pool directly any more.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
> Please include reported-by credits and link to the bug reports on
> lore.kernel.org when merging this. Also I guess this should have a Fixes:
> line?
I'm not aware of a bug report, but the reported-by/Fixes lines are
indeed missing.
BTW: Any idea why dim add-link doesn't work?
> And maybe some words on how/why stuff blows up.
Just a typo. I've forgot to remove two lines in radeon while rebasing
and still had the symbols exported so never noticed this.
Christian.
> -Daniel
>
>> ---
>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>> index d4328ff57757..35b715f82ed8 100644
>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>> }
>> rdev->mman.initialized = true;
>>
>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>> - dma_addressing_limited(&rdev->pdev->dev));
>> -
>> r = radeon_ttm_init_vram(rdev);
>> if (r) {
>> DRM_ERROR("Failed initializing VRAM heap.\n");
>> --
>> 2.25.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-07 20:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 18:23 [PATCH 1/2] drm/radeon: stop re-init the TTM page pool Christian König
2021-01-05 18:23 ` [PATCH 2/2] drm/ttm: unexport ttm_pool_init/fini Christian König
2021-01-06 6:35 ` [PATCH 1/2] drm/radeon: stop re-init the TTM page pool Huang Rui
2021-01-07 18:07 ` Daniel Vetter
2021-01-07 20:08 ` Christian König [this message]
2021-01-08 14:31 ` Daniel Vetter
2021-01-08 14:36 ` Christian König
2021-01-08 15:53 ` Daniel Vetter
2021-01-11 10:16 ` Christian König
2021-01-11 16:17 ` Daniel Vetter
2021-01-12 7:53 ` Christian König
2021-01-12 9:16 ` Daniel Vetter
2021-01-09 11:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffa9d7f2-fe68-fb6a-8422-82b8949dbe1e@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bp@alien8.de \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox