From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E444CC47247 for ; Sat, 2 May 2020 07:27:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4CF52137B for ; Sat, 2 May 2020 07:27:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4CF52137B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 88A136E02F; Sat, 2 May 2020 07:27:34 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB5B06E02F for ; Sat, 2 May 2020 07:27:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6B6B0AC91; Sat, 2 May 2020 07:27:32 +0000 (UTC) Date: Sat, 02 May 2020 09:27:31 +0200 Message-ID: From: Takashi Iwai To: Lukas Wunner Subject: Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state In-Reply-To: <20200502071728.fn2fcqvt6aies3zu@wunner.de> References: <20200502071728.fn2fcqvt6aies3zu@wunner.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Zhou, David\(ChunMing\)" , "alsa-devel@alsa-project.org" , Nicholas Johnson , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Takashi Iwai , "Deucher, Alexander" , Alex Deucher , "Koenig, Christian" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Sat, 02 May 2020 09:17:28 +0200, Lukas Wunner wrote: > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device *kdev, > > struct amdgpu_device *adev = dev->dev_private; > > struct drm_audio_component *acomp = data; > > > > + if (!device_link_add(hda_kdev, kdev, DL_FLAG_STATELESS | > > + DL_FLAG_PM_RUNTIME)) { > > + DRM_ERROR("DM: cannot add device link to audio device\n"); > > + return -ENOMEM; > > + } > > + > > Doesn't this duplicate drivers/pci/quirks.c:quirk_gpu_hda() ? Gah, you're right, that was the place I overlooked. It was a typical "false Eureka right-after-wakeup" phenomenon :) Need a vaccine aka coffee... So the runtime PM dependency must be already placed there, and the problem is not the lack of the dependency tree but the really other timing issue. Back to square. thanks, Takashi _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx