AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Leo Li" <sunpeng.li@amd.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drm/amd/display: Fix the brightness read via aux
Date: Sat, 06 Feb 2021 13:29:12 +0100	[thread overview]
Message-ID: <s5h8s811isn.wl-tiwai@suse.de> (raw)
In-Reply-To: <CADnq5_PZFcXG2E28O2PrJRm+twp6Stq71EE+yckEOZbE7NUW6Q@mail.gmail.com>

On Fri, 05 Feb 2021 17:36:44 +0100,
Alex Deucher wrote:
> 
> On Wed, Feb 3, 2021 at 7:42 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > The current code tries to read the brightness value via
> > dc_link_get_backlight_level() no matter whether it's controlled via
> > aux or not, and this results in a bogus value returned.
> > Fix it to read the current value via
> > dc_link_get_backlight_level_nits() for the aux.
> >
> > BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1180749
> > BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1438
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> This looks fine to me.  FWIW, I have a similar patch set here:
> https://cgit.freedesktop.org/~agd5f/linux/log/?h=backlight_wip

I'm fine to scratch mine as long as the issue gets fixed :)

FWIW, the biggest problem so far was the aux channel backlight didn't
work as expected, the actual backlight isn't changed by the backlight
sysfs write.  (And the sysfs read gives a bogus value, but it's not
the cause of the non-working backlight control.)

Does the aux channel backlight really work with the current code?
Or is this rather a device-specific issue (e.g. broken BIOS) and we
might need to come up with a deny list or such?


thanks,

Takashi
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-02-06 12:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 12:42 [PATCH 0/2] drm/amd/display: some backlight fixes Takashi Iwai
2021-02-03 12:42 ` [PATCH 1/2] drm/amd/display: Fix the brightness read via aux Takashi Iwai
2021-02-05 16:36   ` Alex Deucher
2021-02-06 12:29     ` Takashi Iwai [this message]
2021-02-08 15:02       ` Deucher, Alexander
2021-02-03 12:42 ` [PATCH 2/2] drm/amd/display: Add aux_backlight module option Takashi Iwai
2021-02-05 16:34   ` Alex Deucher
2021-02-06 12:25     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8s811isn.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox