From: sashiko-bot@kernel.org
To: "Ce Sun" <cesun102@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: skip uniras block ECC query in GPU reset path
Date: Fri, 13 Nov 2026 13:35:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-212894@kernel.org> (raw)
In-Reply-To: <20261113131151.1807-1-cesun102@amd.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] drm/amdgpu: incomplete reset check in
amdgpu_persistent_edc_harvesting()
- [Low] drm/amdgpu: missing Fixes trailer for GPU reset ECC query
regression
--
commit 6d9c0ce1b3d7514e06ab9efacbe9d580a60d6b1c
Author: Ce Sun <cesun102@amd.com>
> drm/amdgpu: skip uniras block ECC query in GPU reset path
>
> amdgpu_uniras_query_block_ecc doesn't support being called during GPU reset.
>
> Signed-off-by: Ce Sun <cesun102@amd.com>
> Signed-off-by: YiPeng Chai <YiPeng.Chai@amd.com>
[Severity: Low]
This fixes the GPU reset timeout introduced when
amdgpu_ras_query_error_status() was wired to
amdgpu_uniras_query_block_ecc(). Should it carry:
Fixes: fe2ccc7b7b23 ("drm/amdgpu: query block error count of ras module")
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 312566337ab14..6d8b2e24880f6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -3758,6 +3758,10 @@ static int amdgpu_persistent_edc_harvesting(struct amdgpu_device *adev,
> if (!amdgpu_persistent_edc_harvesting_supported(adev))
> return 0;
>
> + if ((amdgpu_in_reset(adev) || amdgpu_ras_in_recovery(adev)) &&
> + amdgpu_uniras_enabled(adev))
> + return 0;
> +
> if (amdgpu_ras_query_error_status(adev, &info) != 0)
> drm_warn(adev_to_drm(adev), "RAS init query failure");
[Severity: Medium]
Should this skip GPU reset unconditionally instead of gating on
amdgpu_uniras_enabled(adev), matching amdgpu_ras_reset_error_count()?
During XGMI reset-on-init (amdgpu_xgmi_reset_on_init_work()), the reset
thread holds down_write(&adev->reset_domain->sem), while UniRAS is not
enabled until amdgpu_ras_resume_after_reset() runs after the reset domain
is unlocked. amdgpu_uniras_enabled(adev) also returns false during reset
on SR-IOV VFs (via amdgpu_virt_ras_remote_uniras_enabled()) and on
non-UniRAS devices. When amdgpu_uniras_enabled(adev) is false here,
amdgpu_ras_query_error_status() falls through to
amdgpu_ras_query_error_status_with_event(), where
down_read_trylock(&adev->reset_domain->sem) fails against the reset
thread's own write lock and logs a false "RAS init query failure" warning
for every RAS block.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113131151.1807-1-cesun102@amd.com?part=1
next prev parent reply other threads:[~2026-11-13 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 13:11 [PATCH] drm/amdgpu: skip uniras block ECC query in GPU reset path Ce Sun
2026-11-13 13:35 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-13 9:54 Ce Sun
2026-11-13 10:49 ` sashiko-bot
2026-11-13 3:28 Ce Sun
2026-11-13 15:45 ` Zhang, Hawking
2026-11-16 1:55 ` Sun, Ce(Overlord)
2026-11-16 3:32 ` Chai, Thomas
2026-11-16 11:06 ` Zhou1, Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212894@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cesun102@amd.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox