From: sashiko-bot@kernel.org
To: "Zhigang Luo" <Zhigang.Luo@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/7] Revert "drm/amdkfd: mark A+A VF VRAM PTEs as system memory"
Date: Fri, 13 Nov 2026 15:16:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-213072@kernel.org> (raw)
In-Reply-To: <20261113145702.323968-2-Zhigang.Luo@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amdkfd: revert commit message cites non-ancestor SHA
daf19be40e04
--
commit 3e660e5d230b226dd7bb0de7b064fd710bf0e2a4
Author: Zhigang Luo <Zhigang.Luo@amd.com>
> Revert "drm/amdkfd: mark A+A VF VRAM PTEs as system memory"
>
> This reverts commit daf19be40e04.
>
> SVM VRAM ranges leave AMDGPU_PTE_SYSTEM clear and then call
> amdgpu_gmc_get_vm_pte() with a NULL buffer object. The GFX 12.1
> PTE helper sets the bit for an A+A VF, so the special case in
> svm_range_get_pte_flags() is the wrong place.
>
> Signed-off-by: Zhigang Luo <zhigang.luo@amd.com>
[Severity: Low]
Commit daf19be40e04 ("drm/amdkfd: mark A+A VF VRAM PTEs as system memory")
is not an ancestor of this branch; the commit in the branch history that
added the amdgpu_virt_vram_is_spm() check in svm_range_get_pte_flags() is
a69f4d4076ea ("drm/amdkfd: mark A+A VF VRAM PTEs as system memory").
Should the revert reference be updated to cite a69f4d4076ea ("drm/amdkfd:
mark A+A VF VRAM PTEs as system memory")?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113145702.323968-1-Zhigang.Luo@amd.com?part=2
next prev parent reply other threads:[~2026-11-13 15:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 14:56 [PATCH 1/7] Revert "drm/amdgpu: mark A+A VF VRAM mappings as system memory" Zhigang Luo
2026-11-13 14:56 ` [PATCH 2/7] Revert "drm/amdkfd: mark A+A VF VRAM PTEs " Zhigang Luo
2026-11-13 15:16 ` sashiko-bot [this message]
2026-11-13 14:56 ` [PATCH 3/7] Revert "drm/amdgpu: take the A+A VF GMC aperture from SRAT" Zhigang Luo
2026-11-13 15:20 ` sashiko-bot
2026-11-13 14:56 ` [PATCH 4/7] drm/amdgpu: set the A+A VF SYSTEM bit in the GFX 12.1 helpers Zhigang Luo
2026-11-13 15:20 ` sashiko-bot
2026-11-16 9:43 ` Christian König
2026-11-13 14:57 ` [PATCH 5/7] drm/amdgpu: fill the A+A VF PDB0 through get_vm_pde Zhigang Luo
2026-11-13 15:14 ` sashiko-bot
2026-11-16 16:12 ` Luo, Zhigang
2026-11-16 9:44 ` Christian König
2026-11-13 14:57 ` [PATCH 6/7] drm/amdgpu: align the sysvm GART start to 8GB Zhigang Luo
2026-11-13 15:05 ` sashiko-bot
2026-11-16 10:09 ` Christian König
2026-11-13 14:57 ` [PATCH 7/7] drm/amdgpu: keep the A+A VF VRAM base at the SRAT address Zhigang Luo
2026-11-13 15:29 ` sashiko-bot
2026-11-16 12:04 ` Christian König
2026-11-13 15:11 ` [PATCH 1/7] Revert "drm/amdgpu: mark A+A VF VRAM mappings as system memory" sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-213072@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Zhigang.Luo@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox