From: sashiko-bot@kernel.org
To: "Junhua Shen" <Junhua.Shen@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 1/2] drm/amdgpu: map KFD userptr read-only when the BO is not writable
Date: Tue, 17 Nov 2026 04:30:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-218189@kernel.org> (raw)
In-Reply-To: <20261117042051.768201-2-Junhua.Shen@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amdgpu: missing Fixes trailer for KFD read-only userptr bug
in init_user_pages()
--
commit 29a249e733b969cc649ffa369fb4f4e2387a5611
Author: Junhua Shen <Junhua.Shen@amd.com>
> drm/amdgpu: map KFD userptr read-only when the BO is not writable
>
> init_user_pages() registers every userptr writable (flags = 0), ignoring
> the KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE flag that get_pte_flags() already
> honors when mapping the BO.
>
> Pass AMDGPU_GEM_USERPTR_READONLY for a read-only allocation, so the
> userptr registration matches the permission already enforced in the page
> table.
>
> Signed-off-by: Junhua Shen <Junhua.Shen@amd.com>
[Severity: Low]
Should this include a Fixes: tag for the commit that introduced the
hardcoded 0 flags argument in init_user_pages()?
Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117042051.768201-1-Junhua.Shen@amd.com?part=1
next prev parent reply other threads:[~2026-11-17 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 4:20 [PATCH v1 0/2] drm/amdkfd: honor read-only intent for userptr and SVM ranges Junhua Shen
2026-11-17 4:20 ` [PATCH v1 1/2] drm/amdgpu: map KFD userptr read-only when the BO is not writable Junhua Shen
2026-11-17 4:30 ` sashiko-bot [this message]
2026-11-17 4:20 ` [PATCH v1 2/2] drm/amdkfd: honor KFD_IOCTL_SVM_FLAG_GPU_RO for read-only SVM ranges Junhua Shen
2026-11-17 4:42 ` sashiko-bot
2026-11-17 17:21 ` [PATCH v1 0/2] drm/amdkfd: honor read-only intent for userptr and " Philip Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218189@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Junhua.Shen@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox