AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
	dri-devel@lists.freedesktop.org
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/sched: Remove the single scheduler special case
Date: Tue, 17 Nov 2026 10:25:20 +0000	[thread overview]
Message-ID: <sashiko-outbox-218613@kernel.org> (raw)
In-Reply-To: <20261117100654.8593-4-tvrtko.ursulin@igalia.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/sched: contradictory sched_list kernel-doc in
  drm_sched_entity_init()
--

commit 51236e2b589e5bb2f95788276a6d8bea43b26e11
Author: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

drm/sched: Remove the single scheduler special case

This commit stores a single scheduler pointer directly in a union with
sched_list in struct drm_sched_entity so that entities with a single
scheduler retain their scheduler reference for runtime priority changes.

> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index a18f637f9e998..6ff455373067f 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -102,7 +102,9 @@ ktime_t drm_sched_entity_stats_job_add_gpu_time(struct drm_sched_job *job)
>   * @guilty: atomic_t set to 1 when a job on this queue
>   *          is found to be guilty causing a timeout
>   *
> - * Note that the &sched_list must have at least one element to schedule the entity.
> + * Note that the &sched_list must have exactly one element to schedule the
> + * entity. Callers which pass more than one scheduler on the @sched_list must
> + * ensure the list remains valid for the lifetime of the entity.

[Severity: Low]
Should this still say "at least one element" rather than "exactly one
element"?  drm_sched_entity_init() accepts one or more schedulers in
sched_list, as described in the following sentence.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117100654.8593-1-tvrtko.ursulin@igalia.com?part=3

  reply	other threads:[~2026-11-17 10:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:06 [PATCH 0/4] drm/sched: Entity handling cleanups Tvrtko Ursulin
2026-11-17 10:06 ` [PATCH 1/4] drm/sched: Disallow initializing entities with un-initialized schedulers Tvrtko Ursulin
2026-11-17 10:46   ` sashiko-bot
2026-11-17 12:11     ` Tvrtko Ursulin
2026-11-17 12:00   ` Philipp Stanner
2026-11-17 12:17     ` Tvrtko Ursulin
2026-11-17 10:06 ` [PATCH 2/4] drm/sched: Ignore stopped entity attempt to change its run-queue Tvrtko Ursulin
2026-11-17 11:53   ` Philipp Stanner
2026-11-17 13:04     ` Tvrtko Ursulin
2026-11-17 10:06 ` [PATCH 3/4] drm/sched: Remove the single scheduler special case Tvrtko Ursulin
2026-11-17 10:25   ` sashiko-bot [this message]
2026-11-17 10:06 ` [PATCH 4/4] drm/sched: Address the fence_seq fixme Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218613@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox