AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] drm: Remove drm_crtc_init()
Date: Tue, 17 Nov 2026 14:34:37 +0000	[thread overview]
Message-ID: <sashiko-outbox-218968@kernel.org> (raw)
In-Reply-To: <20261117140750.541769-3-tzimmermann@suse.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm: build failure in amdgpu DCE files after removing
  drm_crtc_init()
--

commit 6d664862f4e8731c606db322340f68e1b8885e4d
Author: Thomas Zimmermann <tzimmermann@suse.de>

drm: Remove drm_crtc_init()

This commit removes the legacy drm_crtc_init() helper and its associated
default primary plane structures.

> diff --git a/include/drm/drm_modeset_helper.h b/include/drm/drm_modeset_helper.h
> index 7e3d4c5a7f66d..6b9421aee5360 100644
> --- a/include/drm/drm_modeset_helper.h
> +++ b/include/drm/drm_modeset_helper.h
> @@ -37,9 +37,6 @@ void drm_helper_mode_fill_fb_struct(struct drm_device *dev,
>  				    const struct drm_format_info *info,
>  				    const struct drm_mode_fb_cmd2 *mode_cmd);
>  
> -int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
> -		  const struct drm_crtc_funcs *funcs);
> -
>  int drm_mode_config_helper_suspend(struct drm_device *dev);
>  int drm_mode_config_helper_resume(struct drm_device *dev);

[Severity: High]
As reported by kernel test robot on v2 [1], does removing drm_crtc_init()
break the build when CONFIG_DRM_AMDGPU is enabled?

Three legacy DCE display files in drivers/gpu/drm/amd/amdgpu/ still call
drm_crtc_init() in dce_v10_0_crtc_init(), dce_v8_0_crtc_init(), and
dce_v6_0_crtc_init():

drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:dce_v10_0_crtc_init() {
    ...
	drm_crtc_init(adev_to_drm(adev), &amdgpu_crtc->base, &dce_v10_0_crtc_funcs);
    ...
}

[1] https://lore.kernel.org/r/202611130312.g6BELEWG-lkp@intel.com

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117140750.541769-1-tzimmermann@suse.de?part=2

      reply	other threads:[~2026-11-17 14:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:04 [PATCH v3 0/2] drm/radeon: Inline drm_crtc_init() Thomas Zimmermann
2026-11-17 14:04 ` [PATCH v3 1/2] " Thomas Zimmermann
2026-11-17 14:04 ` [PATCH v3 2/2] drm: Remove drm_crtc_init() Thomas Zimmermann
2026-11-17 14:34   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218968@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox