From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 475011EB9F0; Tue, 3 Dec 2024 12:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733229675; cv=none; b=fqUWbwLL4gIf1GsLJsID+AYIdQ6AQ0OZIk4C01SmleA9Gco6Rin9a4ZBPZZ07SKRjCf8baKRKTzA5au8anGnukmppcSZdgsRv0v4B86iQQRu+oeb3GZgHv7cpQ/anc/F2b4UljlLu2Wo0ZgI2qRekpKUTVKdMxSZLx5seWmPZgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733229675; c=relaxed/simple; bh=2uEXSo5be+RCYE8wBlDOJXNuB/VT7ARg3i3C+zGOWYQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mlgiALEaVTYJdwlQ3ce2Hd+GUHfNwe3ZiCAhKF6n6B6SU3Tyi0963R3QVHbVGlJen2i8VyCF6DO98sGU3X/bXBNG8oupkQIMV0KkOVfn1E0OQokbt2HoFFmqCTY266A8c0VclDaFij8a2F6h1AUOKS3GEewqvjBityvYGWYIN44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1Unb6vnj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1Unb6vnj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95C16C4CECF; Tue, 3 Dec 2024 12:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733229675; bh=2uEXSo5be+RCYE8wBlDOJXNuB/VT7ARg3i3C+zGOWYQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1Unb6vnj0waeqg52vL3tNBxqazZ4YLEkRH6amdDr2bx43L5JPTkkH+pB+L4tMzH0J SCb6eYmqeMGHbFRdUm9eKf56OQESdHkQFoMknfazShRPcJP62eT8Z3A5bIfaHIyzv7 mcuUv99lpsVEKyYu6Ycjcf2lp80AbgdlAJGG1ZwM= Date: Tue, 3 Dec 2024 13:41:10 +0100 From: Greg Kroah-Hartman To: Zijun Hu Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "Rafael J. Wysocki" , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Jean Delvare , Guenter Roeck , Martin Tuma , Mauro Carvalho Chehab , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Linus Walleij , Bartosz Golaszewski , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Takashi Sakamoto , Jiri Slaby , Heikki Krogerus , Srinivas Kandagatla , Lee Duncan , Chris Leech , Mike Christie , "James E.J. Bottomley" , "Martin K. Petersen" , Nilesh Javali , Manish Rangankar , GR-QLogic-Storage-Upstream@marvell.com, Davidlohr Bueso , Jonathan Cameron , Alison Schofield , Andreas Larsson , Stuart Yoder , Laurentiu Tudor , Jens Axboe , Sudeep Holla , Cristian Marussi , Ard Biesheuvel , Bjorn Andersson , Mathieu Poirier , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pwm@vger.kernel.org, nvdimm@lists.linux.dev, linux1394-devel@lists.sourceforge.net, linux-serial@vger.kernel.org, linux-sound@vger.kernel.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-cxl@vger.kernel.org, sparclinux@vger.kernel.org, linux-block@vger.kernel.org, arm-scmi@vger.kernel.org, linux-efi@vger.kernel.org, linux-remoteproc@vger.kernel.org, Zijun Hu Subject: Re: [PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages Message-ID: <2024120320-manual-jockey-dfd1@gregkh> References: <20241203-const_dfc_done-v2-0-7436a98c497f@quicinc.com> <9d34bd6f-b120-428a-837b-5a5813e14618@icloud.com> Precedence: bulk X-Mailing-List: arm-scmi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d34bd6f-b120-428a-837b-5a5813e14618@icloud.com> On Tue, Dec 03, 2024 at 08:23:45PM +0800, Zijun Hu wrote: > On 2024/12/3 20:00, Uwe Kleine-König wrote: > > Hello, > > > > On Tue, Dec 03, 2024 at 08:33:22AM +0800, Zijun Hu wrote: > >> This patch series is to constify the following API: > >> struct device *device_find_child(struct device *dev, void *data, > >> int (*match)(struct device *dev, void *data)); > >> To : > >> struct device *device_find_child(struct device *dev, const void *data, > >> device_match_t match); > >> typedef int (*device_match_t)(struct device *dev, const void *data); > > > > This series isn't bisectible. With only the first two patches applied I > > hit: > > yes. such patch series needs to be merge as atomic way. > > Hi Greg, > > is it possible to ONLY merge such patch series by atomic way into your > driver-core tree? Nope! > or squash such patch series into a single patch ? > > various subsystem maintainers may not like squashing way. Agreed, so look into either doing it in a bisectable way if at all possible. As I don't see a full series here, I can't suggest how it needs to happen :( thanks, greg k-h