From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9602B448BAD for ; Wed, 26 Aug 2026 15:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787757473; cv=none; b=oSk/CwTypa2+RuausRI32dK3cveYc085qnSZou02LhCRBa9H83R41T9rzC6GTSFu/jE0uZSrNK6wb/2oqMFAXOuPRkfGAIJzOpI915Sktn14m4UwYl96E8ZOZGf17Qcx4sSG8J/MvZ8ueEWJDWb0tvsKqZxxN6r1CDBccN4zgbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787757473; c=relaxed/simple; bh=Sk8am2Vtc6m9rrLeY1Sbj7klCd/qXHFyxywLnXgPxcU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QO3reyZxe+V4kluSVAGdB6oBKY4bljfJz+vYnyNAyj6ULwf+34kecnXj74o3+laa6Q0+Anwo5QAuOqBI1AZr6vG3k7wg91e8O3ZSYXIRhbgGIJIETvEqMQR8A1u+FP+AElU2gcxjpISE4aSo08JRojQ6LK3DqOxSDIxmLwIcA/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=p5knkjHu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RT+Q3+DZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="p5knkjHu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RT+Q3+DZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67QDuudC1008509 for ; Wed, 26 Aug 2026 15:17:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ACC2N5csm/N7GWXhyzoNg/HYZa0MB3L4DHfq+Va9l/I=; b=p5knkjHuqaYpQxzB H7zvlxnKLQOs1cDx7G1/WbGXm7to0pWBWSR8OKDmeDK/7HsJo6q49HF3qCXkl2pE mjswcW8ddsNNA9po4CQBYyO8rO+rRWohR56Q+LFAFVZjRdwiWhUXmDLxtk/NH2SU I9Hs+ihAtA+F8wsEqoiEBuDfckytb0cP7TETqi/Aorr8CvVi2R1sLbwcf9TwJIQO Pu+iBTFoc/fR0G9oqKuS5sJSoJv1KrGIcf60TvK2XFasrc6EKxYsg1rtJ7TCkR+2 Rzcaf8CJitCIJN6vpV0F/PM/IGcIu3rdEd+c4+XY8/bOhCJQVWufzo4zWgZ+zEXz tY/3uw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9x2n1850-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 15:17:48 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38e22137fb3so2059468a91.0 for ; Wed, 26 Aug 2026 08:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787757468; x=1788362268; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ACC2N5csm/N7GWXhyzoNg/HYZa0MB3L4DHfq+Va9l/I=; b=RT+Q3+DZvckCun3HgDClAVd8dY4dqLTkoxXh1qZVVe977tkQOiKzwRyZKntbGyUI1x ze/O13OIps7tzbTyaTbLQcqtvacUQvLzF5fYyf6i1rO5uxSnKmHOMlR0hUtFZkg9BodQ F8svhi3OL60ty75CsrSsD6jj0ZvYFdbInMuUOksLx3PnAG+ZxHuH5em0EeoyA6wBAJ5H ehY3TFiKNQ2uI8wgcjiEnaC7bx7BWat7aJoMix1rCMyCUcgJU1/ukjBeJqBRZDc8N+Xd o1L6ih1edEg07pn7Py/Odff6sOJcUblKOfZ84mjY3zqXShEluTohOL4OasqwPhceNlVE VBIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787757468; x=1788362268; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ACC2N5csm/N7GWXhyzoNg/HYZa0MB3L4DHfq+Va9l/I=; b=ZWe+bpE/iQ/h+IWiCqMJvucQBbqJ8wQmQ9KSGYCAa+QxLkBqbGS18ZpSCz6I8jSYKL OtQY8vv24LMHOzTfa5BcwpDyzKK9jE4tcHU96SM/KqAawNyF9KftKmZBRDS4qkLgbaHk YlX4EdyDTJi51cV/Xp9FpiCgNitb5bbKfjQPfP+nXRZ3AdSI+C1HfmVWAqDryyrnguxE Dun/NS1IMusmnEtNBSrVkw3Wl43OBMv44ccgKPu9In4TCfUUa0CTx5dZp9L4MltDVzG7 opy/mwllRBaWX94Qvl5wEBXsqil4GwkyM9xVyif6ewr3BwNgnfrtfw6tbVJmpdLsboLG 0wMQ== X-Forwarded-Encrypted: i=1; AHgh+Rpq7VYHcjqOZhpw2R0oPyf11264Q9SjMx+Rk/0CFJM+eKjDCadm3ludm7zW3JgyWvU5lblgwI/glA==@vger.kernel.org X-Gm-Message-State: AFuF++khqgWbSEe1T7lrmk4ko0adnYSe+dBMLykhKpg1gxUn5vguGazY W5p/dn8eCdh/9XKauhLVyRRIB3e6YkGEWqKTZ23C0NeYvhAQySU3pPgokh/bvQ6sHsJlHbMIUX4 4w17okiNLpgQNIuW72wnEeOTOLvote5VhRNTFNhlPhZ36Wg9wh33EUtrdQD9ePA== X-Gm-Gg: AR+sD11Raej9Snd04ZF2zSZwKjQkdpIvRsxlqWzybo1lhtSbPb/279im5c0Yzy4I4Dd Wy/xPhpNx0upK4teq63gubG/L2rTuUbf/HFaH7pVo2VtHo32rmGgukpThkQGQ68OMDx2RZEs2vV 7i4TCg5myjEhyg0dRNS3usR6z0eXiX1EiRggeUFPbBMY2RILDa94c/rfTNi7EeroXMUyA9XoUkh 4RmyrbQHOwHdr/K41q2QFeiTItOrC9XaKBiKJ0Joqe00OtK1BKLVPgVlKHwcNb/OZfWqTZ/CPfC Y6S70FmJX4JCy3d3WTNgB9Xn6I6D3UJZz/rYT8jk11gAuT0Eb8SwY1B4AWtqFg1JklLyYJqIfSN nvpwyyLQFeYas5qG5Zoq9jy2VUdRKsMHM X-Received: by 2002:a17:90b:4c09:b0:37f:e177:f58 with SMTP id 98e67ed59e1d1-3966d3dcdb1mr15426098a91.9.1787757467956; Wed, 26 Aug 2026 08:17:47 -0700 (PDT) X-Received: by 2002:a17:90b:4c09:b0:37f:e177:f58 with SMTP id 98e67ed59e1d1-3966d3dcdb1mr15425980a91.9.1787757467399; Wed, 26 Aug 2026 08:17:47 -0700 (PDT) Received: from [192.168.0.6] ([49.204.111.175]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39646138f87sm8381159a91.3.2026.08.26.08.17.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 08:17:47 -0700 (PDT) Message-ID: <75e6979b-84ed-49ee-83f8-bdceef2cb464@oss.qualcomm.com> Date: Wed, 26 Aug 2026 20:47:38 +0530 Precedence: bulk X-Mailing-List: arm-scmi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] soc: qcom: geni-se: Populate clk_perf_tbl with SE source clock frequencies from perf OPP table To: Konrad Dybcio , Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: mukesh.savaliya@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-0-61171ab1cdce@oss.qualcomm.com> <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-2-61171ab1cdce@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 0_dJTopUSoxRS45K8BcYRwO374O9PcBM X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDEyNyBTYWx0ZWRfXzbZY48oXI0Aq 6gxfM60Y67Jb8iOXl2Vr2ih3tgLsSruEN6WNfZT8xjJut5RV7zl3BAqBfZcmjSICIGCT1NSnWA1 F432Cu6eWESJzt8ktFkOhOFAljF5/AE= X-Proofpoint-GUID: 0_dJTopUSoxRS45K8BcYRwO374O9PcBM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDEyNyBTYWx0ZWRfXycTd6IrP4kPX nbrobct8MNLHUrFiA6YkUJWwPD/QChfl/KV+VSoNBIlp9od1eLYa7XfUH3E+doxFUzx8M55A6Tp qDL0GGjHguaQbHOoiDegMzFmSCwS5YbL5zTaAAvTqN97hu580PXq7U0KfT3pCExj0BIok0EqN8/ JEIn0A+3WmPtMjSPq6V0zxZEIxcDmmLe26AdqBZxiTs4ygjLDZTdkqoEMhGefpQ0ZtTpR20Hln8 dpBb01u0jmlE4FmEX57o6fmCd1ocpAXBoxsCi21AqNtcLP35v5y2AEYbhEptTXuH6RxWwax4k1X h3mj4gy4HTfJd/vcWE/Y2lfxIjpvCveWW9A0zPA9wiexNRj4ftaEhlCdCV9/XS9Vt2XttnyZJmr uang9Cl01KTp56P5yO/DcYXdxRpysqgWz4/z9A6FtT9aaL78ykvOIkkQwYgf5ILxrPA3GgU7XEQ 2oAqjjZd7knGu9EZgyg== X-Authority-Analysis: v=2.4 cv=PPQ/P/qC c=1 sm=1 tr=0 ts=6a8f039d cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=MMW3c9rFXQuugNOjlkEUow==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=rko7XVifj6BEHbDbj-IA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_04,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260127 HI Konrad, On 24-08-2026 20:26, Konrad Dybcio wrote: > On 8/4/26 9:57 PM, Praveen Talari wrote: >> Currently, on the SA8255P platform, protocol drivers attached via >> geni_se_domain_attach() treat each OPP on the perf domain as directly >> corresponding to a protocol value such as a baudrate or requested >> frequency, and simply request that OPP via > [...] > >> @@ -1175,6 +1181,29 @@ int geni_se_domain_attach(struct geni_se *se) >> else if (ret < 0) >> return ret; >> >> + perf_dev = se->pd_list->pd_devs[DOMAIN_IDX_PERF]; >> + >> + num_opps = dev_pm_opp_get_opp_count(perf_dev); >> + if (num_opps <= 0) >> + return num_opps < 0 ? num_opps : -ENODEV; > if (num_opps < 0) > return num_opps; > if (num_opps == 0) > return -ENODEV; > >> + >> + se->clk_perf_tbl = devm_kcalloc(se->dev, num_opps, >> + sizeof(*se->clk_perf_tbl), >> + GFP_KERNEL); >> + if (!se->clk_perf_tbl) >> + return -ENOMEM; >> + >> + for (i = 0, level = 0; i < num_opps; i++, level++) { > One iterator is sufficient here level is not acting as a loop iterator here. It represents the OPP performance level returned by dev_pm_opp_find_level_ceil(), which may advance to a value greater than level + 1 depending on the available OPP table entries. The array index, however, must advance sequentially for each populated entry. Therefore, separate variables are needed. Thanks, Praveen Talari > > Konrad